Re: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock

From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	semen.protsenko@linaro.org
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	kernel-team@android.com,  linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock
Date: Fri, 26 Apr 2024 11:54:57 +0100	[thread overview]
Message-ID: <8023ea8c1eab725baf0389fe34b918bb5dd924c8.camel@linaro.org> (raw)
In-Reply-To: <013f2da9-1d91-4b62-b5b7-d603d0c09aef@kernel.org>

On Thu, 2024-04-25 at 20:18 +0200, Krzysztof Kozlowski wrote:
> On 25/04/2024 20:15, Krzysztof Kozlowski wrote:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            const: google,gs101-pinctrl
> > > +    then:
> > > +      required:
> > > +        - clocks
> > > +        - clock-names
> > 
> > else:
> >   properties:
> >     clocks: false
> >     clock-names: false
> > 
> > but anyway this is all a bit fragile, because pinctrl is not a driver
> > and you rely on initcall ordering.
> 
> It is a driver, although initcall ordering is still there. Anyway, it's
> the first soc requiring clock for pinctrl

If I see it right, E850 has similar gates, and like on gs101 they're currently
also all marked as CLK_IGNORE_UNUSED in the e850 clock driver with a comment that
a driver update is needed. I've added Sam.

Cheers,
Andre'