From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size
Date: Wed, 28 Apr 2021 16:41:24 +0300 [thread overview]
Message-ID: <80622cc2-5585-abaa-42e0-cc6969ed6ae3@linaro.org> (raw)
In-Reply-To: <20210428024755.GJ1908499@yoga>
On 28/04/2021 05:47, Bjorn Andersson wrote:
> On Mon 26 Apr 19:18 CDT 2021, Dmitry Baryshkov wrote:
> [..]
>> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
>> index 92fe844b517b..be578fc4e54f 100644
>> --- a/drivers/gpu/drm/msm/msm_drv.c
>> +++ b/drivers/gpu/drm/msm/msm_drv.c
>> @@ -124,7 +124,7 @@ struct clk *msm_clk_get(struct platform_device *pdev, const char *name)
>> }
>>
>> static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
>> - const char *dbgname, bool quiet)
>> + const char *dbgname, bool quiet, phys_addr_t *psize)
>
> size_t sounds like a better fit for psize...
I was trying to select between size_t and phys_addr_t, settling on the
latter one because it is used for resource size.
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: freedreno@lists.freedesktop.org,
Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <abhinavk@codeaurora.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size
Date: Wed, 28 Apr 2021 16:41:24 +0300 [thread overview]
Message-ID: <80622cc2-5585-abaa-42e0-cc6969ed6ae3@linaro.org> (raw)
In-Reply-To: <20210428024755.GJ1908499@yoga>
On 28/04/2021 05:47, Bjorn Andersson wrote:
> On Mon 26 Apr 19:18 CDT 2021, Dmitry Baryshkov wrote:
> [..]
>> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
>> index 92fe844b517b..be578fc4e54f 100644
>> --- a/drivers/gpu/drm/msm/msm_drv.c
>> +++ b/drivers/gpu/drm/msm/msm_drv.c
>> @@ -124,7 +124,7 @@ struct clk *msm_clk_get(struct platform_device *pdev, const char *name)
>> }
>>
>> static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
>> - const char *dbgname, bool quiet)
>> + const char *dbgname, bool quiet, phys_addr_t *psize)
>
> size_t sounds like a better fit for psize...
I was trying to select between size_t and phys_addr_t, settling on the
latter one because it is used for resource size.
--
With best wishes
Dmitry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-28 13:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 0:18 [PATCH v2 0/4] drm/msm: improve register snapshotting Dmitry Baryshkov
2021-04-27 0:18 ` Dmitry Baryshkov
2021-04-27 0:18 ` [PATCH v2 1/4] drm/msm: pass dump state as a function argument Dmitry Baryshkov
2021-04-27 0:18 ` Dmitry Baryshkov
2021-04-27 0:18 ` [PATCH v2 2/4] drm/msm: make msm_disp_state transient data struct Dmitry Baryshkov
2021-04-27 0:18 ` Dmitry Baryshkov
2021-04-27 19:19 ` [Freedreno] " abhinavk
2021-04-27 19:19 ` abhinavk
2021-04-27 20:29 ` Dmitry Baryshkov
2021-04-27 20:29 ` Dmitry Baryshkov
2021-04-27 22:11 ` abhinavk
2021-04-27 22:11 ` abhinavk
2021-04-27 0:18 ` [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size Dmitry Baryshkov
2021-04-27 0:18 ` Dmitry Baryshkov
2021-04-27 19:29 ` [Freedreno] " abhinavk
2021-04-27 19:29 ` abhinavk
2021-04-27 20:32 ` Dmitry Baryshkov
2021-04-27 20:32 ` Dmitry Baryshkov
2021-04-27 22:12 ` abhinavk
2021-04-27 22:12 ` abhinavk
2021-04-28 2:47 ` Bjorn Andersson
2021-04-28 2:47 ` Bjorn Andersson
2021-04-28 13:41 ` Dmitry Baryshkov [this message]
2021-04-28 13:41 ` Dmitry Baryshkov
2021-04-28 13:59 ` Bjorn Andersson
2021-04-28 13:59 ` Bjorn Andersson
2021-04-28 14:03 ` Dmitry Baryshkov
2021-04-28 14:03 ` Dmitry Baryshkov
2021-04-27 0:18 ` [PATCH v2 4/4] drm/msm/dsi: add DSI PHY registers to snapshot data Dmitry Baryshkov
2021-04-27 0:18 ` Dmitry Baryshkov
2021-04-27 22:14 ` abhinavk
2021-04-27 22:14 ` abhinavk
2021-04-27 19:10 ` [PATCH v2 0/4] drm/msm: improve register snapshotting abhinavk
2021-04-27 19:10 ` abhinavk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80622cc2-5585-abaa-42e0-cc6969ed6ae3@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.