Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller

From: Neil Armstrong <neil.armstrong@linaro.org>
To: zelong dong <zelong.dong@amlogic.com>, Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller
Date: Thu, 2 Mar 2023 10:24:30 +0100	[thread overview]
Message-ID: <80fe197a-3f15-d1b8-ed99-adeb4a8c24d2@linaro.org> (raw)
In-Reply-To: <20230302063402.42708-3-zelong.dong@amlogic.com>

On 02/03/2023 07:34, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
> 
> Add new compatible for Amlogic's Meson-S4 IR Controller
> 
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> ---
>   Documentation/devicetree/bindings/media/meson-ir.txt | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt b/Documentation/devicetree/bindings/media/meson-ir.txt
> index efd9d29a8f10..2a6662edd04d 100644
> --- a/Documentation/devicetree/bindings/media/meson-ir.txt
> +++ b/Documentation/devicetree/bindings/media/meson-ir.txt
> @@ -5,11 +5,14 @@ Required properties:
>   		  - "amlogic,meson6-ir"
>   		  - "amlogic,meson8b-ir"
>   		  - "amlogic,meson-gxbb-ir"
> +		  - "amlogic,meson-s4-ir"
>    - reg		: physical base address and length of the device registers
>    - interrupts	: a single specifier for the interrupt from the device
>   
>   Optional properties:
>    - linux,rc-map-name:	see rc.txt file in the same directory.
> + - amlogic,ir-support-hw-decode: enable hardware IR Decoder, and register
> +				 rc driver as type RC_DRIVER_SCANCODE

AFAIK this is a software parameter since the HW is capable of decoding,
if you want to make the HW decoding a runtime option, please use another way.

>   
>   Example:
>   

Please base changes on top of https://lore.kernel.org/all/20221117-b4-amlogic-bindings-convert-v3-4-e28dd31e3bed@linaro.org/

Thanks,
Neil