From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kernel@gpiccoli.net, senozhatsky@chromium.org,
rostedt@goodmis.org, john.ogness@linutronix.de,
feng.tang@intel.com, kexec@lists.infradead.org,
dyoung@redhat.com, keescook@chromium.org, anton@enomsg.org,
ccross@android.com, tony.luck@intel.com
Subject: Re: [PATCH V2] panic: Move panic_print before kmsg dumpers
Date: Fri, 14 Jan 2022 09:32:58 -0300 [thread overview]
Message-ID: <811109b0-ada6-83b4-6d6d-b26b156d279d@igalia.com> (raw)
In-Reply-To: <20220114122651.GB17817@pathway.suse.cz>
On 14/01/2022 09:26, Petr Mladek wrote:
> [...]
> I see. OK, it makes sense to call it after the panic notifiers when
> they are used. It would be nice to mention the above in the commit
> message and explain why the 2nd call is there.
>
> Just an idea. It might be better to move the 1st call below
> if (!_crash_kexec_post_notifiers). It would make it more
> clear that it is intended for this code path. I mean:
>
> if (!_crash_kexec_post_notifiers) {
> /* ... */
> if (kexec_crash_loaded())
> panic_print_sys_info(false);
>
> __crash_kexec(NULL);
> ...
>
> Best Regards,
> Petr
Perfect Petr, thanks again for the very good ideas! I'll work on V3 and
submit today.
Cheers,
Guilherme
WARNING: multiple messages have this Message-ID (diff)
From: Guilherme G. Piccoli <gpiccoli@igalia.com>
To: kexec@lists.infradead.org
Subject: [PATCH V2] panic: Move panic_print before kmsg dumpers
Date: Fri, 14 Jan 2022 09:32:58 -0300 [thread overview]
Message-ID: <811109b0-ada6-83b4-6d6d-b26b156d279d@igalia.com> (raw)
In-Reply-To: <20220114122651.GB17817@pathway.suse.cz>
On 14/01/2022 09:26, Petr Mladek wrote:
> [...]
> I see. OK, it makes sense to call it after the panic notifiers when
> they are used. It would be nice to mention the above in the commit
> message and explain why the 2nd call is there.
>
> Just an idea. It might be better to move the 1st call below
> if (!_crash_kexec_post_notifiers). It would make it more
> clear that it is intended for this code path. I mean:
>
> if (!_crash_kexec_post_notifiers) {
> /* ... */
> if (kexec_crash_loaded())
> panic_print_sys_info(false);
>
> __crash_kexec(NULL);
> ...
>
> Best Regards,
> Petr
Perfect Petr, thanks again for the very good ideas! I'll work on V3 and
submit today.
Cheers,
Guilherme
next prev parent reply other threads:[~2022-01-14 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 21:28 [PATCH V2] panic: Move panic_print before kmsg dumpers Guilherme G. Piccoli
2022-01-06 21:28 ` Guilherme G. Piccoli
2022-01-13 11:50 ` Petr Mladek
2022-01-13 11:50 ` Petr Mladek
2022-01-13 12:34 ` Guilherme G. Piccoli
2022-01-13 12:34 ` Guilherme G. Piccoli
2022-01-13 14:22 ` Petr Mladek
2022-01-13 14:22 ` Petr Mladek
2022-01-13 15:15 ` Guilherme G. Piccoli
2022-01-13 15:15 ` Guilherme G. Piccoli
2022-01-14 12:26 ` Petr Mladek
2022-01-14 12:26 ` Petr Mladek
2022-01-14 12:32 ` Guilherme G. Piccoli [this message]
2022-01-14 12:32 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=811109b0-ada6-83b4-6d6d-b26b156d279d@igalia.com \
--to=gpiccoli@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=dyoung@redhat.com \
--cc=feng.tang@intel.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.