Re: [PATCH v2 2/2] iio: adc: ad7173: add AD7173 driver - Ceclan Dumitru-Ioan

From: Ceclan Dumitru-Ioan <mitrutzceclan@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org,
	linux-gpio@vger.kernel.org,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michael Walle" <michael@walle.cc>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"ChiaEn Wu" <chiaen_wu@richtek.com>,
	"Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add AD7173 driver
Date: Thu, 28 Sep 2023 16:29:03 +0300	[thread overview]
Message-ID: <823f03d7-2af4-f4f6-4e74-9beb299ab0e8@gmail.com> (raw)
In-Reply-To: <20230928125443.615006-2-mitrutzceclan@gmail.com>

On 9/28/23 15:54, Dumitru Ceclan wrote:
> The AD7173 family offer a complete integrated Sigma-Delta ADC solution
> which can be used in high precision, low noise single channel
> applications or higher speed multiplexed applications. The Sigma-Delta
> ADC is intended primarily for measurement of signals close to DC but also
> delivers outstanding performance with input bandwidths out to ~10kHz.
> 
> Signed-off-by: Dumitru Ceclan <mitrutzceclan@gmail.com>

Forgot changelog
V1 -> V2

 - keep original out-of-tree AD7173 naming
 - remove gpio_cleanup
 - handle 32bit realbits offset case
 - use iio_device_claim_direct_mode, drop own mutex
 - use dev_err_probe
 - cleanup headers include
 - use GENMASK() and FIELD_PREP()
 - use HZ_PER_MHZ
 - change #ifdef GPIOLIB to if( IS_ENABLED(CONFIG_GPIOLIB)) 
 - use gpio-regmap
 - change boolean flag in info struct to number of gpios
 - NIH memset64
 - use struct pointers for config comparison
 - use spi_write_then_read for ADC reset
 - use stack allocated buffer for reset
 - define constant for reset sequence size
 - use kcalloc instead of kzalloc
 - change of naming to fw of dt parse function
 - change de-referencing chain to local variable dev in multiple locations
 - drop write_raw_get_fmt
 - add driver private data to spi_device_id table
 - use fsleep() instead of usleep_range()
 - put config value inline
 - align read/write raw arguments
 - remove zeroed values from channel templates structure
 - define constants for temperature sensor positive and negative inputs
 - always enable temperature channel
 - configure spi clock phase and polarity from driver

 misc changes (test bit, return disable all, indentation fix, change statements to single line)