Re: [RFC PATCH 1/5] entry: Pass pt_regs to irqentry_exit_cond_resched()

From: Rik van Riel <riel@surriel.com>
To: ira.weiny@intel.com, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC PATCH 1/5] entry: Pass pt_regs to irqentry_exit_cond_resched()
Date: Fri, 05 Aug 2022 14:33:32 -0400	[thread overview]
Message-ID: <82b27eafe952c9f5a8ea6a8bcd902a38e2b2c77a.camel@surriel.com> (raw)
In-Reply-To: <20220805173009.3128098-2-ira.weiny@intel.com>

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Fri, 2022-08-05 at 10:30 -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Auxiliary pt_regs space needs to be manipulated by the generic
> entry/exit code.
> 
> Ideally irqentry_exit() would take care of handling any auxiliary
> pt_regs on exit.  Unfortunately, irqentry_exit() is not the only exit
> from exception path.  The call to irqentry_exit_cond_resched() from
> xen_pv_evtchn_do_upcall() bypasses irqentry_exit().
> 
> Make irqentry_exit_cond_resched() symmetrical with irqentry_enter()
> by
> passing pt_regs to it.  This makes irqentry_exit_cond_resched()
> capable
> of handling auxiliary pt_regs in future patches.
> 
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Acked-by: Rik van Riel <riel@surriel.com>

-- 
All Rights Reversed.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]