From: Paul Durrant <Paul.Durrant@citrix.com> To: 'Jan Beulich' <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org> Cc: Kevin Tian <kevin.tian@intel.com> Subject: Re: [PATCH] VT-d: suppress individual flushes during hwdom setup Date: Thu, 2 May 2019 13:12:23 +0000 [thread overview] Message-ID: <8305316c7a2848418c030b048dff498a@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <5CCAE256020000780022B35B@prv1-mh.provo.novell.com> > -----Original Message----- > From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf Of Jan Beulich > Sent: 02 May 2019 13:28 > To: xen-devel <xen-devel@lists.xenproject.org> > Cc: Kevin Tian <kevin.tian@intel.com> > Subject: [Xen-devel] [PATCH] VT-d: suppress individual flushes during hwdom setup > > There's an invocation of iommu_flush_all() immediately afterwards. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1310,8 +1310,11 @@ static void __hwdom_init intel_iommu_hwd > > setup_hwdom_pci_devices(d, setup_hwdom_device); > setup_hwdom_rmrr(d); > + > /* Make sure workarounds are applied before enabling the IOMMU(s). */ > + this_cpu(iommu_dont_flush_iotlb) = true; > arch_iommu_hwdom_init(d); > + this_cpu(iommu_dont_flush_iotlb) = false; There should be no need for this. arch_iommu_hwdom_init() is using iommu_map(), which no longer does implicit flushing. Paul > > if ( iommu_flush_all() ) > printk(XENLOG_WARNING VTDPREFIX > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Paul Durrant <Paul.Durrant@citrix.com> To: 'Jan Beulich' <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org> Cc: Kevin Tian <kevin.tian@intel.com> Subject: Re: [Xen-devel] [PATCH] VT-d: suppress individual flushes during hwdom setup Date: Thu, 2 May 2019 13:12:23 +0000 [thread overview] Message-ID: <8305316c7a2848418c030b048dff498a@AMSPEX02CL03.citrite.net> (raw) Message-ID: <20190502131223.Wkyyl4HZQrcpbQDDFfXbSieTOeqM5uWgZFiwzBaguY8@z> (raw) In-Reply-To: <5CCAE256020000780022B35B@prv1-mh.provo.novell.com> > -----Original Message----- > From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf Of Jan Beulich > Sent: 02 May 2019 13:28 > To: xen-devel <xen-devel@lists.xenproject.org> > Cc: Kevin Tian <kevin.tian@intel.com> > Subject: [Xen-devel] [PATCH] VT-d: suppress individual flushes during hwdom setup > > There's an invocation of iommu_flush_all() immediately afterwards. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1310,8 +1310,11 @@ static void __hwdom_init intel_iommu_hwd > > setup_hwdom_pci_devices(d, setup_hwdom_device); > setup_hwdom_rmrr(d); > + > /* Make sure workarounds are applied before enabling the IOMMU(s). */ > + this_cpu(iommu_dont_flush_iotlb) = true; > arch_iommu_hwdom_init(d); > + this_cpu(iommu_dont_flush_iotlb) = false; There should be no need for this. arch_iommu_hwdom_init() is using iommu_map(), which no longer does implicit flushing. Paul > > if ( iommu_flush_all() ) > printk(XENLOG_WARNING VTDPREFIX > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-02 13:14 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-02 12:28 [PATCH] VT-d: suppress individual flushes during hwdom setup Jan Beulich 2019-05-02 12:28 ` [Xen-devel] " Jan Beulich 2019-05-02 13:08 ` Roger Pau Monné 2019-05-02 13:08 ` [Xen-devel] " Roger Pau Monné 2019-05-02 13:35 ` Jan Beulich 2019-05-02 13:35 ` [Xen-devel] " Jan Beulich 2019-05-02 13:12 ` Paul Durrant [this message] 2019-05-02 13:12 ` Paul Durrant 2019-05-02 13:41 ` Jan Beulich 2019-05-02 13:41 ` [Xen-devel] " Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8305316c7a2848418c030b048dff498a@AMSPEX02CL03.citrite.net \ --to=paul.durrant@citrix.com \ --cc=JBeulich@suse.com \ --cc=kevin.tian@intel.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.