From: Marc Kleine-Budde <mkl@pengutronix.de> To: Faiz Abbas <faiz_abbas@ti.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org Cc: mark.rutland@arm.com, nm@ti.com, catalin.marinas@arm.com, sriram.dash@samsung.com, t-kristo@ti.com, robh+dt@kernel.org, dmurphy@ti.com, davem@davemloft.net, wg@grandegger.com Subject: Re: [PATCH 0/3] Add Support for MCAN in AM654x-idk Date: Thu, 23 Jan 2020 12:54:27 +0100 [thread overview] Message-ID: <8316b645-72a8-7348-ad4c-1a84535b8b3f@pengutronix.de> (raw) In-Reply-To: <f6bf75f0-68ea-0b61-ed43-9ad894016cfd@ti.com> [-- Attachment #1.1.1: Type: text/plain, Size: 1991 bytes --] On 1/23/20 12:46 PM, Faiz Abbas wrote: > Marc, > > On 23/01/20 4:47 pm, Marc Kleine-Budde wrote: >> On 1/22/20 9:03 AM, Faiz Abbas wrote: >>> This series adds driver patches to support MCAN in TI's AM654x-idk. >>> >>> Faiz Abbas (3): >>> dt-bindings: net: can: m_can: Add Documentation for stb-gpios >>> can: m_can: m_can_platform: Add support for enabling transceiver >>> through the STB line >>> arm64: defconfig: Add Support for Bosch M_CAN controllers >>> >>> Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++ >>> arch/arm64/configs/defconfig | 3 +++ >>> drivers/net/can/m_can/m_can_platform.c | 12 ++++++++++++ >>> 3 files changed, 17 insertions(+) >> >> What about adding support for xceiver-supply as done in several other >> drivers (ti_hecc.c, flexcan.c, mcp251x.c)? And using this for the stb line? > > Looks like you had given this feedback a long time ago and I forgot > about it. Sorry about that :-) > > https://lore.kernel.org/patchwork/patch/1006238/ > > But now that I think about it, its kinda weird that we are modelling > part of the transceiver as a separate child node > (Documentation/devicetree/bindings/net/can/can-transceiver.txt) and the > other parts as a regulator. We need a regulator, as there are dual phy chips with a single enable line. > Anyone looking at the transceiver node would figure thats where the > enable gpio/regulator node needs to go instead of the parent node. > Shouldn't we have all transceiver properties under the same node? Feel free to add support for the regulator to the transceiver node and convert the existing drivers to accept both bindings. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de> To: Faiz Abbas <faiz_abbas@ti.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org Cc: catalin.marinas@arm.com, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net, wg@grandegger.com, sriram.dash@samsung.com, dmurphy@ti.com, nm@ti.com, t-kristo@ti.com Subject: Re: [PATCH 0/3] Add Support for MCAN in AM654x-idk Date: Thu, 23 Jan 2020 12:54:27 +0100 [thread overview] Message-ID: <8316b645-72a8-7348-ad4c-1a84535b8b3f@pengutronix.de> (raw) In-Reply-To: <f6bf75f0-68ea-0b61-ed43-9ad894016cfd@ti.com> [-- Attachment #1.1: Type: text/plain, Size: 1991 bytes --] On 1/23/20 12:46 PM, Faiz Abbas wrote: > Marc, > > On 23/01/20 4:47 pm, Marc Kleine-Budde wrote: >> On 1/22/20 9:03 AM, Faiz Abbas wrote: >>> This series adds driver patches to support MCAN in TI's AM654x-idk. >>> >>> Faiz Abbas (3): >>> dt-bindings: net: can: m_can: Add Documentation for stb-gpios >>> can: m_can: m_can_platform: Add support for enabling transceiver >>> through the STB line >>> arm64: defconfig: Add Support for Bosch M_CAN controllers >>> >>> Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++ >>> arch/arm64/configs/defconfig | 3 +++ >>> drivers/net/can/m_can/m_can_platform.c | 12 ++++++++++++ >>> 3 files changed, 17 insertions(+) >> >> What about adding support for xceiver-supply as done in several other >> drivers (ti_hecc.c, flexcan.c, mcp251x.c)? And using this for the stb line? > > Looks like you had given this feedback a long time ago and I forgot > about it. Sorry about that :-) > > https://lore.kernel.org/patchwork/patch/1006238/ > > But now that I think about it, its kinda weird that we are modelling > part of the transceiver as a separate child node > (Documentation/devicetree/bindings/net/can/can-transceiver.txt) and the > other parts as a regulator. We need a regulator, as there are dual phy chips with a single enable line. > Anyone looking at the transceiver node would figure thats where the > enable gpio/regulator node needs to go instead of the parent node. > Shouldn't we have all transceiver properties under the same node? Feel free to add support for the regulator to the transceiver node and convert the existing drivers to accept both bindings. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-23 11:54 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-22 8:03 [PATCH 0/3] Add Support for MCAN in AM654x-idk Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 8:03 ` [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 13:35 ` Dan Murphy 2020-01-22 13:35 ` Dan Murphy 2020-01-22 13:35 ` Dan Murphy 2020-01-22 14:24 ` Sekhar Nori 2020-01-22 14:24 ` Sekhar Nori 2020-01-22 14:24 ` Sekhar Nori 2020-01-22 14:34 ` Dan Murphy 2020-01-22 14:34 ` Dan Murphy 2020-01-22 14:34 ` Dan Murphy 2020-01-23 7:39 ` Faiz Abbas 2020-01-23 7:39 ` Faiz Abbas 2020-01-23 7:39 ` Faiz Abbas [not found] ` <57baeedc-9f51-7b92-f190-c0bbd8525a16-l0cyMroinI0@public.gmane.org> 2020-02-03 12:06 ` Rob Herring 2020-02-03 12:06 ` Rob Herring 2020-02-03 12:06 ` Rob Herring 2020-02-17 13:53 ` Faiz Abbas 2020-02-17 13:53 ` Faiz Abbas 2020-01-22 8:03 ` [PATCH 2/3] can: m_can: m_can_platform: Add support for enabling transceiver through the STB line Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas [not found] ` <20200122080310.24653-3-faiz_abbas-l0cyMroinI0@public.gmane.org> 2020-01-22 14:53 ` Sriram Dash 2020-01-22 14:53 ` Sriram Dash 2020-01-22 14:53 ` Sriram Dash 2020-01-22 8:03 ` [PATCH 3/3] arm64: defconfig: Add Support for Bosch M_CAN controllers Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-22 8:03 ` Faiz Abbas 2020-01-23 11:17 ` [PATCH 0/3] Add Support for MCAN in AM654x-idk Marc Kleine-Budde 2020-01-23 11:17 ` Marc Kleine-Budde 2020-01-23 11:46 ` Faiz Abbas 2020-01-23 11:46 ` Faiz Abbas 2020-01-23 11:46 ` Faiz Abbas 2020-01-23 11:54 ` Marc Kleine-Budde [this message] 2020-01-23 11:54 ` Marc Kleine-Budde
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8316b645-72a8-7348-ad4c-1a84535b8b3f@pengutronix.de \ --to=mkl@pengutronix.de \ --cc=catalin.marinas@arm.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=faiz_abbas@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=netdev@vger.kernel.org \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=sriram.dash@samsung.com \ --cc=t-kristo@ti.com \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.