From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, bjorn.andersson@linaro.org Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/msm/dp: fix event thread stuck in wait_event after kthread_stop() Date: Wed, 4 May 2022 21:38:05 +0300 [thread overview] Message-ID: <834eeda0-12b0-3f16-8ca2-89175c1de186@linaro.org> (raw) In-Reply-To: <1651595136-24312-1-git-send-email-quic_khsieh@quicinc.com> On 03/05/2022 19:25, Kuogee Hsieh wrote: > Event thread supposed to exit from its while loop after kthread_stop(). > However there may has possibility that event thread is pending in the > middle of wait_event due to condition checking never become true. > To make sure event thread exit its loop after kthread_stop(), this > patch OR kthread_should_stop() into wait_event's condition checking > so that event thread will exit its loop after kernal_stop(). > > Changes in v2: > -- correct spelling error at commit title > > Changes in v3: > -- remove unnecessary parenthesis > -- while(1) to replace while (!kthread_should_stop()) > > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Fixes: 570d3e5d28db ("drm/msm/dp: stop event kernel thread when DP unbind") > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Let's do it properly: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index c388323..da5c03a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1103,15 +1103,20 @@ static int hpd_event_thread(void *data) > > dp_priv = (struct dp_display_private *)data; > > - while (!kthread_should_stop()) { > + while (1) { > if (timeout_mode) { > wait_event_timeout(dp_priv->event_q, > - (dp_priv->event_pndx == dp_priv->event_gndx), > - EVENT_TIMEOUT); > + (dp_priv->event_pndx == dp_priv->event_gndx) || > + kthread_should_stop(), EVENT_TIMEOUT); > } else { > wait_event_interruptible(dp_priv->event_q, > - (dp_priv->event_pndx != dp_priv->event_gndx)); > + (dp_priv->event_pndx != dp_priv->event_gndx) || > + kthread_should_stop()); > } > + > + if (kthread_should_stop()) > + break; > + > spin_lock_irqsave(&dp_priv->event_lock, flag); > todo = &dp_priv->event_list[dp_priv->event_gndx]; > if (todo->delay) { -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@linux.ie, agross@kernel.org, bjorn.andersson@linaro.org Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, quic_aravindh@quicinc.com, freedreno@lists.freedesktop.org Subject: Re: [PATCH v3] drm/msm/dp: fix event thread stuck in wait_event after kthread_stop() Date: Wed, 4 May 2022 21:38:05 +0300 [thread overview] Message-ID: <834eeda0-12b0-3f16-8ca2-89175c1de186@linaro.org> (raw) In-Reply-To: <1651595136-24312-1-git-send-email-quic_khsieh@quicinc.com> On 03/05/2022 19:25, Kuogee Hsieh wrote: > Event thread supposed to exit from its while loop after kthread_stop(). > However there may has possibility that event thread is pending in the > middle of wait_event due to condition checking never become true. > To make sure event thread exit its loop after kthread_stop(), this > patch OR kthread_should_stop() into wait_event's condition checking > so that event thread will exit its loop after kernal_stop(). > > Changes in v2: > -- correct spelling error at commit title > > Changes in v3: > -- remove unnecessary parenthesis > -- while(1) to replace while (!kthread_should_stop()) > > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Fixes: 570d3e5d28db ("drm/msm/dp: stop event kernel thread when DP unbind") > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Let's do it properly: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index c388323..da5c03a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1103,15 +1103,20 @@ static int hpd_event_thread(void *data) > > dp_priv = (struct dp_display_private *)data; > > - while (!kthread_should_stop()) { > + while (1) { > if (timeout_mode) { > wait_event_timeout(dp_priv->event_q, > - (dp_priv->event_pndx == dp_priv->event_gndx), > - EVENT_TIMEOUT); > + (dp_priv->event_pndx == dp_priv->event_gndx) || > + kthread_should_stop(), EVENT_TIMEOUT); > } else { > wait_event_interruptible(dp_priv->event_q, > - (dp_priv->event_pndx != dp_priv->event_gndx)); > + (dp_priv->event_pndx != dp_priv->event_gndx) || > + kthread_should_stop()); > } > + > + if (kthread_should_stop()) > + break; > + > spin_lock_irqsave(&dp_priv->event_lock, flag); > todo = &dp_priv->event_list[dp_priv->event_gndx]; > if (todo->delay) { -- With best wishes Dmitry
next prev parent reply other threads:[~2022-05-04 18:38 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 16:25 [PATCH v3] drm/msm/dp: fix event thread stuck in wait_event after kthread_stop() Kuogee Hsieh 2022-05-03 16:25 ` Kuogee Hsieh 2022-05-04 18:26 ` Dmitry Baryshkov 2022-05-04 18:26 ` Dmitry Baryshkov 2022-05-04 18:38 ` Dmitry Baryshkov [this message] 2022-05-04 18:38 ` Dmitry Baryshkov 2022-05-04 18:44 ` Stephen Boyd 2022-05-04 18:44 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=834eeda0-12b0-3f16-8ca2-89175c1de186@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_aravindh@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.