From: Kumar Gala <galak@codeaurora.org>
To: Andy Gross <agross@codeaurora.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, Sagar Dharia <sdharia@codeaurora.org>,
Daniel Sneddon <dsneddon@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [Patch v2 3/3] spi: qup: Add support for v1.1.1
Date: Fri, 13 Jun 2014 11:45:09 -0500 [thread overview]
Message-ID: <83D400F5-EEC1-4559-96CA-3016EF9BCD90@codeaurora.org> (raw)
In-Reply-To: <1402601652-24641-4-git-send-email-agross@codeaurora.org>
On Jun 12, 2014, at 2:34 PM, Andy Gross <agross@codeaurora.org> wrote:
> This patch adds support for v1.1.1 of the SPI QUP controller.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
> .../devicetree/bindings/spi/qcom,spi-qup.txt | 6 +++-
> drivers/spi/spi-qup.c | 36 ++++++++++++--------
> 2 files changed, 27 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> index bee6ff2..e2c88df 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> @@ -7,7 +7,11 @@ SPI in master mode supports up to 50MHz, up to four chip selects, programmable
> data path from 4 bits to 32 bits and numerous protocol variants.
>
> Required properties:
> -- compatible: Should contain "qcom,spi-qup-v2.1.1" or "qcom,spi-qup-v2.2.1"
> +- compatible: Should contain:
> + "qcom,spi-qup-v1.1.1" for 8660, 8960 and 8064.
> + "qcom,spi-qup-v2.1.1" for 8974 and later
> + "qcom,spi-qup-v2.2.1" for 8974 v2 and later.
> +
We should probably try to be a bit more clear about ipq/apq/msm here.
> - reg: Should contain base register location and length
> - interrupts: Interrupt number used by this controller
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: galak@codeaurora.org (Kumar Gala)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v2 3/3] spi: qup: Add support for v1.1.1
Date: Fri, 13 Jun 2014 11:45:09 -0500 [thread overview]
Message-ID: <83D400F5-EEC1-4559-96CA-3016EF9BCD90@codeaurora.org> (raw)
In-Reply-To: <1402601652-24641-4-git-send-email-agross@codeaurora.org>
On Jun 12, 2014, at 2:34 PM, Andy Gross <agross@codeaurora.org> wrote:
> This patch adds support for v1.1.1 of the SPI QUP controller.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
> .../devicetree/bindings/spi/qcom,spi-qup.txt | 6 +++-
> drivers/spi/spi-qup.c | 36 ++++++++++++--------
> 2 files changed, 27 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> index bee6ff2..e2c88df 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> @@ -7,7 +7,11 @@ SPI in master mode supports up to 50MHz, up to four chip selects, programmable
> data path from 4 bits to 32 bits and numerous protocol variants.
>
> Required properties:
> -- compatible: Should contain "qcom,spi-qup-v2.1.1" or "qcom,spi-qup-v2.2.1"
> +- compatible: Should contain:
> + "qcom,spi-qup-v1.1.1" for 8660, 8960 and 8064.
> + "qcom,spi-qup-v2.1.1" for 8974 and later
> + "qcom,spi-qup-v2.2.1" for 8974 v2 and later.
> +
We should probably try to be a bit more clear about ipq/apq/msm here.
> - reg: Should contain base register location and length
> - interrupts: Interrupt number used by this controller
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2014-06-13 16:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:34 [Patch v2 0/3] spi: qup: Fixes and new version support Andy Gross
2014-06-12 19:34 ` Andy Gross
2014-06-12 19:34 ` Andy Gross
2014-06-12 19:34 ` [Patch v2 1/3] spi: qup: Remove chip select function Andy Gross
2014-06-12 19:34 ` Andy Gross
2014-06-21 10:13 ` Mark Brown
2014-06-21 10:13 ` Mark Brown
[not found] ` <20140621101303.GE5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-21 18:56 ` Andy Gross
2014-06-21 18:56 ` Andy Gross
2014-06-21 18:56 ` Andy Gross
[not found] ` <20140621185646.GA2601-zC7DfRvBq/JWk0Htik3J/w@public.gmane.org>
2014-06-22 10:47 ` Mark Brown
2014-06-22 10:47 ` Mark Brown
2014-06-22 10:47 ` Mark Brown
2014-06-12 19:34 ` [Patch v2 2/3] spi: qup: Fix order of spi_register_master Andy Gross
2014-06-12 19:34 ` Andy Gross
2014-06-21 10:12 ` Mark Brown
2014-06-21 10:12 ` Mark Brown
2014-06-12 19:34 ` [Patch v2 3/3] spi: qup: Add support for v1.1.1 Andy Gross
2014-06-12 19:34 ` Andy Gross
2014-06-13 16:45 ` Kumar Gala [this message]
2014-06-13 16:45 ` Kumar Gala
[not found] ` <1402601652-24641-4-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-06-21 10:13 ` Mark Brown
2014-06-21 10:13 ` Mark Brown
2014-06-21 10:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83D400F5-EEC1-4559-96CA-3016EF9BCD90@codeaurora.org \
--to=galak@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=dsneddon@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.