Re: [PATCH 1/2] drm: update drm_show_memory_stats() for dma-bufs

From: Felix Kuehling <felix.kuehling@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: update drm_show_memory_stats() for dma-bufs
Date: Wed, 13 Dec 2023 16:28:44 -0500	[thread overview]
Message-ID: <83dc5d87-6374-4558-83c1-202c0b1add5f@amd.com> (raw)
In-Reply-To: <20231207180225.439482-2-alexander.deucher@amd.com>

On 2023-12-07 13:02, Alex Deucher wrote:
> Show buffers as shared if they are shared via dma-buf as well
> (e.g., shared with v4l or some other subsystem).

You can add KFD to that list. With the in-progress CUDA11 VM changes and 
improved interop between KFD and render nodes, sharing DMABufs between 
KFD and render nodes will become much more common.

Regards,
   Felix

>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Rob Clark <robdclark@gmail.com>
> ---
>   drivers/gpu/drm/drm_file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 5ddaffd32586..5d5f93b9c263 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -973,7 +973,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct drm_file *file)
>   					DRM_GEM_OBJECT_PURGEABLE;
>   		}
>   
> -		if (obj->handle_count > 1) {
> +		if ((obj->handle_count > 1) || obj->dma_buf) {
>   			status.shared += obj->size;
>   		} else {
>   			status.private += obj->size;