Re: [PATCH 0/2] fdinfo shared stats

From: Alex Deucher <alexdeucher@gmail.com>
To: Alex Deucher <alexander.deucher@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] fdinfo shared stats
Date: Wed, 13 Dec 2023 16:13:46 -0500	[thread overview]
Message-ID: <CADnq5_PdmDWyJsDvtvCbNguExt2aydXy_rZOPHii5imMtt_Z+A@mail.gmail.com> (raw)
In-Reply-To: <20231207180225.439482-1-alexander.deucher@amd.com>

On Thu, Dec 7, 2023 at 1:03 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> We had a request to add shared buffer stats to fdinfo for amdgpu and
> while implementing that, Christian mentioned that just looking at
> the GEM handle count doesn't take into account buffers shared with other
> subsystems like V4L or RDMA.  Those subsystems don't use GEM, so it
> doesn't really matter from a GPU top perspective, but it's more
> correct if you actually want to see shared buffers.

Any thoughts on this?  Seem reasonable?

Alex

>
> Alex Deucher (2):
>   drm: update drm_show_memory_stats() for dma-bufs
>   drm/amdgpu: add shared fdinfo stats
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c |  4 ++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 +++++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  6 ++++++
>  drivers/gpu/drm/drm_file.c                 |  2 +-
>  4 files changed, 22 insertions(+), 1 deletion(-)
>
> --
> 2.42.0
>