From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Tong Tiangen <tongtiangen@huawei.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Mark Rutland <mark.rutland@arm.com>, "James Morse" <james.morse@arm.com>, Andrew Morton <akpm@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Robin Murphy <robin.murphy@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Michael Ellerman <mpe@ellerman.id.au>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, "x86@kernel.org" <x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com> Cc: Xie XiuQi <xiexiuqi@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Guohanjun <guohanjun@huawei.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH -next v4 1/7] x86, powerpc: fix function define in copy_mc_to_user Date: Thu, 5 May 2022 09:21:11 +0800 [thread overview] Message-ID: <83e5bbe7-0880-3534-897a-156a4d2b4451@huawei.com> (raw) In-Reply-To: <48f2779d-bc62-c7f5-c40e-7238a16b90fb@huawei.com> On 2022/5/3 9:06, Tong Tiangen wrote: > > > 在 2022/5/2 22:24, Christophe Leroy 写道: >> >> >> Le 20/04/2022 à 05:04, Tong Tiangen a écrit : >>> x86/powerpc has it's implementation of copy_mc_to_user but not use >>> #define >>> to declare. >>> >>> This may cause problems, for example, if other architectures open >>> CONFIG_ARCH_HAS_COPY_MC, but want to use copy_mc_to_user() outside the >>> architecture, the code add to include/linux/uaddess.h is as follows: >>> >>> #ifndef copy_mc_to_user >>> static inline unsigned long __must_check >>> copy_mc_to_user(void *dst, const void *src, size_t cnt) >>> { >>> ... >>> } >>> #endif >>> >>> Then this definition will conflict with the implementation of >>> x86/powerpc >>> and cause compilation errors as follow: >>> >>> Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to >>> copy_mc_to_{user, kernel}()") >> >> I don't understand, what does it fix really ? What was the >> (existing/real) bug introduced by that patch and that your are fixing ? >> >> If those defined had been expected and missing, we would have had a >> build failure. If you have one, can you describe it ? > It could prevent future problems when patch3 is introduced, and yes,for now, this patch won't fix any issue,we could drop the fix tag, and update the changelog. > There will be build failure after patch 3 is added, there is a little > confusing for a reader of this commit in isolation. > In the next version, I will put this patch after patch 3. This is an alternative. > > Thanks, > Tong. > .
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Tong Tiangen <tongtiangen@huawei.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Mark Rutland <mark.rutland@arm.com>, "James Morse" <james.morse@arm.com>, Andrew Morton <akpm@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Robin Murphy <robin.murphy@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Michael Ellerman <mpe@ellerman.id.au>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, "x86@kernel.org" <x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com> Cc: Xie XiuQi <xiexiuqi@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Guohanjun <guohanjun@huawei.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH -next v4 1/7] x86, powerpc: fix function define in copy_mc_to_user Date: Thu, 5 May 2022 09:21:11 +0800 [thread overview] Message-ID: <83e5bbe7-0880-3534-897a-156a4d2b4451@huawei.com> (raw) In-Reply-To: <48f2779d-bc62-c7f5-c40e-7238a16b90fb@huawei.com> On 2022/5/3 9:06, Tong Tiangen wrote: > > > 在 2022/5/2 22:24, Christophe Leroy 写道: >> >> >> Le 20/04/2022 à 05:04, Tong Tiangen a écrit : >>> x86/powerpc has it's implementation of copy_mc_to_user but not use >>> #define >>> to declare. >>> >>> This may cause problems, for example, if other architectures open >>> CONFIG_ARCH_HAS_COPY_MC, but want to use copy_mc_to_user() outside the >>> architecture, the code add to include/linux/uaddess.h is as follows: >>> >>> #ifndef copy_mc_to_user >>> static inline unsigned long __must_check >>> copy_mc_to_user(void *dst, const void *src, size_t cnt) >>> { >>> ... >>> } >>> #endif >>> >>> Then this definition will conflict with the implementation of >>> x86/powerpc >>> and cause compilation errors as follow: >>> >>> Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to >>> copy_mc_to_{user, kernel}()") >> >> I don't understand, what does it fix really ? What was the >> (existing/real) bug introduced by that patch and that your are fixing ? >> >> If those defined had been expected and missing, we would have had a >> build failure. If you have one, can you describe it ? > It could prevent future problems when patch3 is introduced, and yes,for now, this patch won't fix any issue,we could drop the fix tag, and update the changelog. > There will be build failure after patch 3 is added, there is a little > confusing for a reader of this commit in isolation. > In the next version, I will put this patch after patch 3. This is an alternative. > > Thanks, > Tong. > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-05 1:21 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-20 3:04 [PATCH -next v4 0/7]arm64: add machine check safe support Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` [PATCH -next v4 1/7] x86, powerpc: fix function define in copy_mc_to_user Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-22 9:45 ` Michael Ellerman 2022-04-22 9:45 ` Michael Ellerman 2022-04-22 9:45 ` Michael Ellerman 2022-04-24 1:16 ` Tong Tiangen 2022-04-24 1:16 ` Tong Tiangen 2022-04-24 1:16 ` Tong Tiangen 2022-05-02 14:24 ` Christophe Leroy 2022-05-02 14:24 ` Christophe Leroy 2022-05-03 1:06 ` Tong Tiangen 2022-05-03 1:06 ` Tong Tiangen 2022-05-05 1:21 ` Kefeng Wang [this message] 2022-05-05 1:21 ` Kefeng Wang 2022-04-20 3:04 ` [PATCH -next v4 2/7] arm64: fix types in copy_highpage() Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` [PATCH -next v4 3/7] arm64: add support for machine check error safe Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-05-13 15:26 ` Mark Rutland 2022-05-13 15:26 ` Mark Rutland 2022-05-13 15:26 ` Mark Rutland 2022-05-19 6:29 ` Tong Tiangen 2022-05-19 6:29 ` Tong Tiangen 2022-05-19 6:29 ` Tong Tiangen 2022-05-25 8:30 ` Mark Rutland 2022-05-25 8:30 ` Mark Rutland 2022-05-25 8:30 ` Mark Rutland 2022-05-26 3:36 ` Tong Tiangen 2022-05-26 3:36 ` Tong Tiangen 2022-05-26 3:36 ` Tong Tiangen 2022-05-26 9:50 ` Mark Rutland 2022-05-26 9:50 ` Mark Rutland 2022-05-26 9:50 ` Mark Rutland 2022-05-27 1:40 ` Tong Tiangen 2022-05-27 1:40 ` Tong Tiangen 2022-05-27 1:40 ` Tong Tiangen 2022-04-20 3:04 ` [PATCH -next v4 4/7] arm64: add copy_{to, from}_user to machine check safe Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-05-04 10:26 ` Catalin Marinas 2022-05-04 10:26 ` Catalin Marinas 2022-05-04 10:26 ` Catalin Marinas 2022-05-05 6:39 ` Tong Tiangen 2022-05-05 6:39 ` Tong Tiangen 2022-05-05 6:39 ` Tong Tiangen 2022-05-05 13:41 ` Catalin Marinas 2022-05-05 13:41 ` Catalin Marinas 2022-05-05 13:41 ` Catalin Marinas 2022-05-05 14:33 ` Tong Tiangen 2022-05-05 14:33 ` Tong Tiangen 2022-05-05 14:33 ` Tong Tiangen 2022-05-13 15:31 ` Mark Rutland 2022-05-13 15:31 ` Mark Rutland 2022-05-13 15:31 ` Mark Rutland 2022-05-19 6:53 ` Tong Tiangen 2022-05-19 6:53 ` Tong Tiangen 2022-05-19 6:53 ` Tong Tiangen 2022-04-20 3:04 ` [PATCH -next v4 5/7] arm64: mte: Clean up user tag accessors Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-05-13 15:36 ` Mark Rutland 2022-05-13 15:36 ` Mark Rutland 2022-05-13 15:36 ` Mark Rutland 2022-04-20 3:04 ` [PATCH -next v4 6/7] arm64: add {get, put}_user to machine check safe Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-05-13 15:39 ` Mark Rutland 2022-05-13 15:39 ` Mark Rutland 2022-05-13 15:39 ` Mark Rutland 2022-05-19 7:09 ` Tong Tiangen 2022-05-19 7:09 ` Tong Tiangen 2022-05-19 7:09 ` Tong Tiangen 2022-04-20 3:04 ` [PATCH -next v4 7/7] arm64: add cow " Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-04-20 3:04 ` Tong Tiangen 2022-05-13 15:44 ` Mark Rutland 2022-05-13 15:44 ` Mark Rutland 2022-05-13 15:44 ` Mark Rutland 2022-05-19 10:38 ` Tong Tiangen 2022-05-19 10:38 ` Tong Tiangen 2022-05-19 10:38 ` Tong Tiangen 2022-04-27 9:09 ` [PATCH -next v4 0/7]arm64: add machine check safe support Tong Tiangen 2022-04-27 9:09 ` Tong Tiangen 2022-04-27 9:09 ` Tong Tiangen 2022-05-04 19:58 ` (subset) " Catalin Marinas 2022-05-04 19:58 ` Catalin Marinas 2022-05-04 19:58 ` Catalin Marinas 2022-05-16 18:45 ` Catalin Marinas 2022-05-16 18:45 ` Catalin Marinas 2022-05-16 18:45 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=83e5bbe7-0880-3534-897a-156a4d2b4451@huawei.com \ --to=wangkefeng.wang@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=christophe.leroy@csgroup.eu \ --cc=dave.hansen@linux.intel.com \ --cc=guohanjun@huawei.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=robin.murphy@arm.com \ --cc=tglx@linutronix.de \ --cc=tongtiangen@huawei.com \ --cc=viro@zeniv.linux.org.uk \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=xiexiuqi@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.