From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
Doug Ledford <dledford@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Laurence Oberman <loberman@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()
Date: Wed, 26 Oct 2016 20:05:14 -0700 [thread overview]
Message-ID: <8404f2d1-5bc3-6c84-7ca0-24e7672ff67d@acm.org> (raw)
In-Reply-To: <CACVXFVNyRnJFnsSO9TNksE5GNy7TJKL=iZnqrv38=u0XCrW7jA@mail.gmail.com>
On 10/26/16 19:48, Ming Lei wrote:
> On Thu, Oct 27, 2016 at 10:40 AM, Bart Van Assche <bvanassche@acm.org> wrote:
>> If you have a look at the later patches in this series then you will see
>> that the dm core and the NVMe driver have been modified such that
>> blk_mq_stop_hw_queues(q) is called immediately before
>> blk_mq_quiesce_queue(q) is called.
>
> Cause any current and future users of blk_mq_quiesce_queue(q)
> have to set the flag via blk_mq_stop_hw_queues(q), why not set
> the flag explicitly in blk_mq_quiesce_queue(q)?
Hello Ming,
I'll leave it to Jens to decide whether I should repost the patch series
with this change integrated or whether to realize this change with a
follow-up patch.
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jens Axboe <axboe-b10kYP2dOMg@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
James Bottomley
<jejb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
"Martin K. Petersen"
<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Keith Busch <keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Laurence Oberman
<loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()
Date: Wed, 26 Oct 2016 20:05:14 -0700 [thread overview]
Message-ID: <8404f2d1-5bc3-6c84-7ca0-24e7672ff67d@acm.org> (raw)
In-Reply-To: <CACVXFVNyRnJFnsSO9TNksE5GNy7TJKL=iZnqrv38=u0XCrW7jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/26/16 19:48, Ming Lei wrote:
> On Thu, Oct 27, 2016 at 10:40 AM, Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org> wrote:
>> If you have a look at the later patches in this series then you will see
>> that the dm core and the NVMe driver have been modified such that
>> blk_mq_stop_hw_queues(q) is called immediately before
>> blk_mq_quiesce_queue(q) is called.
>
> Cause any current and future users of blk_mq_quiesce_queue(q)
> have to set the flag via blk_mq_stop_hw_queues(q), why not set
> the flag explicitly in blk_mq_quiesce_queue(q)?
Hello Ming,
I'll leave it to Jens to decide whether I should repost the patch series
with this change integrated or whether to realize this change with a
follow-up patch.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()
Date: Wed, 26 Oct 2016 20:05:14 -0700 [thread overview]
Message-ID: <8404f2d1-5bc3-6c84-7ca0-24e7672ff67d@acm.org> (raw)
In-Reply-To: <CACVXFVNyRnJFnsSO9TNksE5GNy7TJKL=iZnqrv38=u0XCrW7jA@mail.gmail.com>
On 10/26/16 19:48, Ming Lei wrote:
> On Thu, Oct 27, 2016@10:40 AM, Bart Van Assche <bvanassche@acm.org> wrote:
>> If you have a look at the later patches in this series then you will see
>> that the dm core and the NVMe driver have been modified such that
>> blk_mq_stop_hw_queues(q) is called immediately before
>> blk_mq_quiesce_queue(q) is called.
>
> Cause any current and future users of blk_mq_quiesce_queue(q)
> have to set the flag via blk_mq_stop_hw_queues(q), why not set
> the flag explicitly in blk_mq_quiesce_queue(q)?
Hello Ming,
I'll leave it to Jens to decide whether I should repost the patch series
with this change integrated or whether to realize this change with a
follow-up patch.
Bart.
next prev parent reply other threads:[~2016-10-27 3:17 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 22:49 [PATCH v4 0/12] Fix race conditions related to stopping block layer queues Bart Van Assche
2016-10-26 22:49 ` Bart Van Assche
2016-10-26 22:49 ` Bart Van Assche
2016-10-26 22:50 ` [PATCH 01/12] blk-mq: Do not invoke .queue_rq() for a stopped queue Bart Van Assche
2016-10-26 22:50 ` Bart Van Assche
2016-10-26 22:50 ` Bart Van Assche
2016-10-27 5:47 ` Hannes Reinecke
2016-10-27 5:47 ` Hannes Reinecke
2016-10-27 8:14 ` Johannes Thumshirn
2016-10-27 8:14 ` Johannes Thumshirn
2016-10-27 8:14 ` Johannes Thumshirn
2016-10-27 12:14 ` Sagi Grimberg
2016-10-27 12:14 ` Sagi Grimberg
2016-10-27 12:14 ` Sagi Grimberg
2016-10-26 22:51 ` [PATCH 02/12] blk-mq: Introduce blk_mq_hctx_stopped() Bart Van Assche
2016-10-26 22:51 ` Bart Van Assche
2016-10-26 22:51 ` Bart Van Assche
2016-10-27 1:33 ` Ming Lei
2016-10-27 1:33 ` Ming Lei
2016-10-27 5:48 ` Hannes Reinecke
2016-10-27 8:15 ` Johannes Thumshirn
2016-10-27 8:15 ` Johannes Thumshirn
2016-10-27 8:15 ` Johannes Thumshirn
2016-10-27 12:15 ` Sagi Grimberg
2016-10-27 12:15 ` Sagi Grimberg
2016-10-27 12:15 ` Sagi Grimberg
2016-10-27 12:40 ` Christoph Hellwig
2016-10-27 12:40 ` Christoph Hellwig
2016-10-27 12:40 ` Christoph Hellwig
2016-10-26 22:52 ` [PATCH 03/12] blk-mq: Introduce blk_mq_queue_stopped() Bart Van Assche
2016-10-26 22:52 ` Bart Van Assche
2016-10-26 22:52 ` Bart Van Assche
2016-10-27 5:49 ` Hannes Reinecke
2016-10-27 5:49 ` Hannes Reinecke
2016-10-27 8:16 ` Johannes Thumshirn
2016-10-27 8:16 ` Johannes Thumshirn
2016-10-27 8:16 ` Johannes Thumshirn
2016-10-26 22:52 ` [PATCH 04/12] blk-mq: Move more code into blk_mq_direct_issue_request() Bart Van Assche
2016-10-26 22:52 ` Bart Van Assche
2016-10-27 5:50 ` Hannes Reinecke
2016-10-27 5:50 ` Hannes Reinecke
2016-10-27 5:50 ` Hannes Reinecke
2016-10-27 8:17 ` Johannes Thumshirn
2016-10-27 8:17 ` Johannes Thumshirn
2016-10-27 8:17 ` Johannes Thumshirn
2016-10-27 8:18 ` Johannes Thumshirn
2016-10-27 8:18 ` Johannes Thumshirn
2016-10-27 8:18 ` Johannes Thumshirn
2016-10-27 12:16 ` Sagi Grimberg
2016-10-27 12:16 ` Sagi Grimberg
2016-10-27 12:16 ` Sagi Grimberg
2016-10-27 12:40 ` Christoph Hellwig
2016-10-27 12:40 ` Christoph Hellwig
2016-10-27 12:40 ` Christoph Hellwig
2016-10-26 22:53 ` [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue() Bart Van Assche
2016-10-26 22:53 ` Bart Van Assche
2016-10-27 1:30 ` Ming Lei
2016-10-27 1:30 ` Ming Lei
2016-10-27 1:30 ` Ming Lei
2016-10-27 2:04 ` Bart Van Assche
2016-10-27 2:04 ` Bart Van Assche
2016-10-27 2:04 ` Bart Van Assche
2016-10-27 2:31 ` Ming Lei
2016-10-27 2:31 ` Ming Lei
2016-10-27 2:40 ` Bart Van Assche
2016-10-27 2:40 ` Bart Van Assche
2016-10-27 2:40 ` Bart Van Assche
2016-10-27 2:48 ` Ming Lei
2016-10-27 2:48 ` Ming Lei
2016-10-27 3:05 ` Bart Van Assche [this message]
2016-10-27 3:05 ` Bart Van Assche
2016-10-27 3:05 ` Bart Van Assche
2016-10-27 12:42 ` Christoph Hellwig
2016-10-27 12:42 ` Christoph Hellwig
2016-10-27 12:42 ` Christoph Hellwig
2016-10-27 13:16 ` Ming Lei
2016-10-27 13:16 ` Ming Lei
2016-10-27 13:16 ` Ming Lei
2016-10-27 5:52 ` Hannes Reinecke
2016-10-27 5:52 ` Hannes Reinecke
2016-10-27 5:52 ` Hannes Reinecke
2016-10-27 15:56 ` Bart Van Assche
2016-10-27 15:56 ` Bart Van Assche
2016-10-27 15:56 ` Bart Van Assche
2016-10-27 12:41 ` Christoph Hellwig
2016-10-27 12:41 ` Christoph Hellwig
2016-10-27 12:41 ` Christoph Hellwig
2016-10-26 22:53 ` [PATCH 06/12] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request() Bart Van Assche
2016-10-26 22:53 ` Bart Van Assche
2016-10-26 22:53 ` Bart Van Assche
2016-10-27 7:26 ` Hannes Reinecke
2016-10-27 7:26 ` Hannes Reinecke
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 12:44 ` Christoph Hellwig
2016-10-27 12:44 ` Christoph Hellwig
2016-10-27 12:44 ` Christoph Hellwig
2016-10-26 22:54 ` [PATCH 07/12] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-26 22:54 ` Bart Van Assche
2016-10-27 7:27 ` Hannes Reinecke
2016-10-27 7:27 ` Hannes Reinecke
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 14:01 ` Mike Snitzer
2016-10-27 14:01 ` Mike Snitzer
2016-10-27 14:01 ` Mike Snitzer
2016-10-26 22:54 ` [PATCH 08/12] dm: Fix a race condition related to stopping and starting queues Bart Van Assche
2016-10-26 22:54 ` Bart Van Assche
2016-10-27 14:01 ` Mike Snitzer
2016-10-27 14:01 ` Mike Snitzer
2016-10-27 14:01 ` Mike Snitzer
2016-10-26 22:55 ` [PATCH 09/12] SRP transport: Move queuecommand() wait code to SCSI core Bart Van Assche
2016-10-26 22:55 ` Bart Van Assche
2016-10-26 22:55 ` Bart Van Assche
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 12:20 ` Sagi Grimberg
2016-10-27 12:20 ` Sagi Grimberg
2016-10-27 12:20 ` Sagi Grimberg
2016-10-26 22:55 ` [PATCH 10/12] SRP transport, scsi-mq: Wait for .queue_rq() if necessary Bart Van Assche
2016-10-26 22:55 ` Bart Van Assche
2016-10-26 22:55 ` Bart Van Assche
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 12:19 ` Sagi Grimberg
2016-10-27 12:19 ` Sagi Grimberg
2016-10-27 12:19 ` Sagi Grimberg
2016-10-26 22:56 ` [PATCH 11/12] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-26 22:56 ` Bart Van Assche
2016-10-26 22:56 ` Bart Van Assche
2016-10-27 12:19 ` Sagi Grimberg
2016-10-27 12:19 ` Sagi Grimberg
2016-10-27 12:19 ` Sagi Grimberg
2016-10-28 16:01 ` Keith Busch
2016-10-28 16:01 ` Keith Busch
2016-10-28 18:51 ` Bart Van Assche
2016-10-28 18:51 ` Bart Van Assche
2016-10-28 21:06 ` Keith Busch
2016-10-28 21:06 ` Keith Busch
2016-10-26 22:56 ` [PATCH 12/12] nvme: Fix a race condition related to stopping queues Bart Van Assche
2016-10-26 22:56 ` Bart Van Assche
2016-10-26 22:56 ` Bart Van Assche
2016-10-26 23:28 ` [PATCH v4 0/12] Fix race conditions related to stopping block layer queues Jens Axboe
2016-10-26 23:28 ` Jens Axboe
2016-10-26 23:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8404f2d1-5bc3-6c84-7ca0-24e7672ff67d@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@fb.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.