Re: [PATCH 1/4] drm/i915: don't block resume on fb console resume

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: don't block resume on fb console resume
Date: Fri, 02 Nov 2012 13:35:58 +0000	[thread overview]
Message-ID: <84c8a8$6cfk8a@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1351723265-4086-1-git-send-email-jbarnes@virtuousgeek.org>

On Wed, 31 Oct 2012 15:41:02 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The console lock can be contended, so rather than prevent other drivers
> after us from being held up, queue the console suspend into the global
> work queue that can happen anytime.  I've measured this to take around
> 200ms on my T420.  Combined with the ring freq/turbo change, we should
> save almost 1/2 a second on resume.

Hmm, I'd rather not postpone the work unless actually contended,
otherwise we may end up just increasing the resume time whilst avoiding
the blame. Perhaps:
  if (console_trylock() {
      intel_fbdev_set_suspend(dev, 0);
      console_unlock();
  } else
     schedule_work(&dev_priv->console_resume_work);
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre