From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3
Date: Fri, 02 Nov 2012 15:16:36 +0000 [thread overview]
Message-ID: <eeac1e$4s7bs7@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1351723265-4086-4-git-send-email-jbarnes@virtuousgeek.org>
On Wed, 31 Oct 2012 15:41:05 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The BIOS shouldn't be touching this memory across suspend/resume, so
> just leave it alone. This saves us ~6ms on resume on my T420 (retested
> with write combined PTEs).
>
> v2: change gtt restore default on pre-gen4 (Chris)
> move needs_gtt_restore flag into dev_priv
> v3: make sure we restore GTT on resume from hibernate (Daniel)
> use opregion support as the cutoff for restore from resume (Chris)
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
My troublesome PNV of yore remains happy with this patch, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Bikeshed: intel_bios_has_opregion(), as we test for this in different
locations in different ways.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-02 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 22:41 [PATCH 1/4] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-31 22:41 ` [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v3 Jesse Barnes
2012-11-02 13:37 ` Chris Wilson
2012-10-31 22:41 ` [PATCH 3/4] drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex Jesse Barnes
2012-11-02 13:38 ` Chris Wilson
2012-10-31 22:41 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3 Jesse Barnes
2012-11-02 15:16 ` Chris Wilson [this message]
2012-11-02 16:40 ` Jesse Barnes
2012-11-02 13:35 ` [PATCH 1/4] drm/i915: don't block resume on fb console resume Chris Wilson
2012-11-04 21:16 ` Paul Menzel
2012-11-04 23:12 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$4s7bs7@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.