From: Matthias Brugger <matthias.bgg@gmail.com> To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org> Cc: Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com, youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH v7 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Date: Tue, 22 Nov 2022 17:24:59 +0100 [thread overview] Message-ID: <8549c4b4-bc0a-ab6d-dceb-e694af2e8148@gmail.com> (raw) In-Reply-To: <20221018024258.19073-2-yong.wu@mediatek.com> On 18/10/2022 04:42, Yong Wu wrote: > Add platform_device_put to match with of_find_device_by_node. > > Meanwhile, I add a new variable "pcommdev" which is for smi common device. > Otherwise, "platform_device_put(plarbdev)" for smi-common dev may be not > readable. And add a checking for whether pcommdev is NULL. > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/iommu/mtk_iommu.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 5a4e00e4bbbc..3189b585725f 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -1043,7 +1043,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > struct mtk_iommu_data *data) > { > struct device_node *larbnode, *smicomm_node, *smi_subcomm_node; > - struct platform_device *plarbdev; > + struct platform_device *plarbdev, *pcommdev; > struct device_link *link; > int i, larb_nr, ret; > > @@ -1074,12 +1074,14 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > } > if (!plarbdev->dev.driver) { > of_node_put(larbnode); > + platform_device_put(plarbdev); > return -EPROBE_DEFER; > } > data->larb_imu[id].dev = &plarbdev->dev; > > component_match_add_release(dev, match, component_release_of, > component_compare_of, larbnode); > + platform_device_put(plarbdev); > } > > /* Get smi-(sub)-common dev from the last larb. */ > @@ -1097,12 +1099,15 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > else > smicomm_node = smi_subcomm_node; > > - plarbdev = of_find_device_by_node(smicomm_node); > + pcommdev = of_find_device_by_node(smicomm_node); > of_node_put(smicomm_node); > - data->smicomm_dev = &plarbdev->dev; > + if (!pcommdev) > + return -ENODEV; > + data->smicomm_dev = &pcommdev->dev; > > link = device_link_add(data->smicomm_dev, dev, > DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME); > + platform_device_put(pcommdev); > if (!link) { > dev_err(dev, "Unable to link %s.\n", dev_name(data->smicomm_dev)); > return -EINVAL;
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com> To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org> Cc: Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com, youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH v7 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Date: Tue, 22 Nov 2022 17:24:59 +0100 [thread overview] Message-ID: <8549c4b4-bc0a-ab6d-dceb-e694af2e8148@gmail.com> (raw) In-Reply-To: <20221018024258.19073-2-yong.wu@mediatek.com> On 18/10/2022 04:42, Yong Wu wrote: > Add platform_device_put to match with of_find_device_by_node. > > Meanwhile, I add a new variable "pcommdev" which is for smi common device. > Otherwise, "platform_device_put(plarbdev)" for smi-common dev may be not > readable. And add a checking for whether pcommdev is NULL. > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/iommu/mtk_iommu.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 5a4e00e4bbbc..3189b585725f 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -1043,7 +1043,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > struct mtk_iommu_data *data) > { > struct device_node *larbnode, *smicomm_node, *smi_subcomm_node; > - struct platform_device *plarbdev; > + struct platform_device *plarbdev, *pcommdev; > struct device_link *link; > int i, larb_nr, ret; > > @@ -1074,12 +1074,14 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > } > if (!plarbdev->dev.driver) { > of_node_put(larbnode); > + platform_device_put(plarbdev); > return -EPROBE_DEFER; > } > data->larb_imu[id].dev = &plarbdev->dev; > > component_match_add_release(dev, match, component_release_of, > component_compare_of, larbnode); > + platform_device_put(plarbdev); > } > > /* Get smi-(sub)-common dev from the last larb. */ > @@ -1097,12 +1099,15 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > else > smicomm_node = smi_subcomm_node; > > - plarbdev = of_find_device_by_node(smicomm_node); > + pcommdev = of_find_device_by_node(smicomm_node); > of_node_put(smicomm_node); > - data->smicomm_dev = &plarbdev->dev; > + if (!pcommdev) > + return -ENODEV; > + data->smicomm_dev = &pcommdev->dev; > > link = device_link_add(data->smicomm_dev, dev, > DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME); > + platform_device_put(pcommdev); > if (!link) { > dev_err(dev, "Unable to link %s.\n", dev_name(data->smicomm_dev)); > return -EINVAL; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-22 16:25 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-18 2:42 [PATCH v7 0/6] iommu/mediatek: Improve safety from invalid dts input Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-10-18 2:42 ` [PATCH v7 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 16:24 ` Matthias Brugger [this message] 2022-11-22 16:24 ` Matthias Brugger 2022-10-18 2:42 ` [PATCH v7 2/6] iommu/mediatek: Use component_match_add Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 16:28 ` Matthias Brugger 2022-11-22 16:28 ` Matthias Brugger 2022-10-18 2:42 ` [PATCH v7 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 16:32 ` Matthias Brugger 2022-11-22 16:32 ` Matthias Brugger 2022-10-18 2:42 ` [PATCH v7 4/6] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 16:43 ` Matthias Brugger 2022-11-22 16:43 ` Matthias Brugger 2022-10-18 2:42 ` [PATCH v7 5/6] iommu/mediatek: Improve safety for mediatek,smi property in larb nodes Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 16:49 ` Matthias Brugger 2022-11-22 16:49 ` Matthias Brugger 2022-10-18 2:42 ` [PATCH v7 6/6] iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data Yong Wu 2022-10-18 2:42 ` Yong Wu 2022-11-22 1:13 ` [PATCH v7 0/6] iommu/mediatek: Improve safety from invalid dts input Yong Wu (吴勇) 2022-11-22 1:13 ` Yong Wu (吴勇) 2022-11-22 8:30 ` joro 2022-11-22 8:30 ` joro 2022-12-05 10:46 ` Joerg Roedel 2022-12-05 10:46 ` Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8549c4b4-bc0a-ab6d-dceb-e694af2e8148@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=anan.sun@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=chengci.xu@mediatek.com \ --cc=dan.carpenter@oracle.com \ --cc=groeck@chromium.org \ --cc=iommu@lists.linux.dev \ --cc=joro@8bytes.org \ --cc=libo.kang@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mingyuan.ma@mediatek.com \ --cc=robin.murphy@arm.com \ --cc=will@kernel.org \ --cc=xueqi.zhang@mediatek.com \ --cc=yf.wang@mediatek.com \ --cc=yong.wu@mediatek.com \ --cc=youlin.pei@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.