From: hpa@zytor.com
To: Andy Lutomirski <luto@kernel.org>, Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Biederman <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
kexec@lists.infradead.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Christoph Hellwig <hch@lst.de>, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro
Date: Sat, 19 Sep 2020 10:14:13 -0700 [thread overview]
Message-ID: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> (raw)
In-Reply-To: <CALCETrVDqHG2chDsLWBHF39SXh6vjzE_xcEs+AWgOg5531BLuQ@mail.gmail.com>
On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski <luto@kernel.org> wrote:
>On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig <hch@infradead.org>
>wrote:
>>
>> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote:
>> > sys_move_pages() is an optional syscall, and once we remove
>> > the compat version of it in favor of the native one with an
>> > in_compat_syscall() check, the x32 syscall table refers to
>> > a __x32_sys_move_pages symbol that may not exist when the
>> > syscall is disabled.
>> >
>> > Change the COND_SYSCALL() definition on x86 to also include
>> > the redirection for x32.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Adding the x86 maintainers and Brian Gerst. Brian proposed another
>> problem to the mess that most of the compat syscall handlers used by
>> x32 here:
>>
>> https://lkml.org/lkml/2020/6/16/664
>>
>> hpa didn't particularly like it, but with your and my pending series
>> we'll soon use more native than compat syscalls for x32, so something
>> will need to change..
>
>I'm fine with either solution.
My main objection was naming. x64 is a widely used synonym for x86-64, and so that is confusing.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
WARNING: multiple messages have this Message-ID (diff)
From: hpa@zytor.com
To: Andy Lutomirski <luto@kernel.org>, Christoph Hellwig <hch@infradead.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Brian Gerst <brgerst@gmail.com>,
kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Borislav Petkov <bp@alien8.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro
Date: Sat, 19 Sep 2020 10:14:13 -0700 [thread overview]
Message-ID: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> (raw)
In-Reply-To: <CALCETrVDqHG2chDsLWBHF39SXh6vjzE_xcEs+AWgOg5531BLuQ@mail.gmail.com>
On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski <luto@kernel.org> wrote:
>On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig <hch@infradead.org>
>wrote:
>>
>> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote:
>> > sys_move_pages() is an optional syscall, and once we remove
>> > the compat version of it in favor of the native one with an
>> > in_compat_syscall() check, the x32 syscall table refers to
>> > a __x32_sys_move_pages symbol that may not exist when the
>> > syscall is disabled.
>> >
>> > Change the COND_SYSCALL() definition on x86 to also include
>> > the redirection for x32.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Adding the x86 maintainers and Brian Gerst. Brian proposed another
>> problem to the mess that most of the compat syscall handlers used by
>> x32 here:
>>
>> https://lkml.org/lkml/2020/6/16/664
>>
>> hpa didn't particularly like it, but with your and my pending series
>> we'll soon use more native than compat syscalls for x32, so something
>> will need to change..
>
>I'm fine with either solution.
My main objection was naming. x64 is a widely used synonym for x86-64, and so that is confusing.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: hpa@zytor.com
To: Andy Lutomirski <luto@kernel.org>, Christoph Hellwig <hch@infradead.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Brian Gerst <brgerst@gmail.com>,
kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Borislav Petkov <bp@alien8.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro
Date: Sat, 19 Sep 2020 10:14:13 -0700 [thread overview]
Message-ID: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> (raw)
In-Reply-To: <CALCETrVDqHG2chDsLWBHF39SXh6vjzE_xcEs+AWgOg5531BLuQ@mail.gmail.com>
On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski <luto@kernel.org> wrote:
>On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig <hch@infradead.org>
>wrote:
>>
>> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote:
>> > sys_move_pages() is an optional syscall, and once we remove
>> > the compat version of it in favor of the native one with an
>> > in_compat_syscall() check, the x32 syscall table refers to
>> > a __x32_sys_move_pages symbol that may not exist when the
>> > syscall is disabled.
>> >
>> > Change the COND_SYSCALL() definition on x86 to also include
>> > the redirection for x32.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Adding the x86 maintainers and Brian Gerst. Brian proposed another
>> problem to the mess that most of the compat syscall handlers used by
>> x32 here:
>>
>> https://lkml.org/lkml/2020/6/16/664
>>
>> hpa didn't particularly like it, but with your and my pending series
>> we'll soon use more native than compat syscalls for x32, so something
>> will need to change..
>
>I'm fine with either solution.
My main objection was naming. x64 is a widely used synonym for x86-64, and so that is confusing.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-09-19 18:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:24 [PATCH 0/4] syscalls: remove compat_alloc_user_space callers Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-19 5:35 ` Christoph Hellwig
2020-09-19 5:35 ` Christoph Hellwig
2020-09-19 5:35 ` Christoph Hellwig
2020-09-19 16:23 ` Andy Lutomirski
2020-09-19 16:23 ` Andy Lutomirski
2020-09-19 16:23 ` Andy Lutomirski
2020-09-19 16:23 ` Andy Lutomirski
2020-09-19 17:14 ` hpa [this message]
2020-09-19 17:14 ` hpa
2020-09-19 17:14 ` hpa
2020-09-19 17:39 ` Andy Lutomirski
2020-09-19 17:39 ` Andy Lutomirski
2020-09-19 17:39 ` Andy Lutomirski
2020-09-19 17:45 ` Brian Gerst
2020-09-19 17:45 ` Brian Gerst
2020-09-19 17:45 ` Brian Gerst
2020-09-19 17:45 ` Brian Gerst
2020-09-18 13:24 ` [PATCH 2/4] kexec: remove compat_sys_kexec_load syscall Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-19 5:37 ` Christoph Hellwig
2020-09-19 5:37 ` Christoph Hellwig
2020-09-19 5:37 ` Christoph Hellwig
2020-09-26 21:10 ` Arnd Bergmann
2020-09-26 21:10 ` Arnd Bergmann
2020-09-26 21:10 ` Arnd Bergmann
2020-09-26 21:10 ` Arnd Bergmann
2020-09-18 13:24 ` [PATCH 3/4] mm: remove compat_sys_move_pages Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-19 5:38 ` Christoph Hellwig
2020-09-19 5:38 ` Christoph Hellwig
2020-09-19 5:38 ` Christoph Hellwig
2020-09-26 15:21 ` Arnd Bergmann
2020-09-26 15:21 ` Arnd Bergmann
2020-09-26 15:21 ` Arnd Bergmann
2020-09-26 15:21 ` Arnd Bergmann
2020-09-18 13:24 ` [PATCH 4/4] mm: remove compat numa syscalls Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-18 13:24 ` Arnd Bergmann
2020-09-19 5:41 ` Christoph Hellwig
2020-09-19 5:41 ` Christoph Hellwig
2020-09-19 5:41 ` Christoph Hellwig
2020-09-26 15:14 ` Arnd Bergmann
2020-09-26 15:14 ` Arnd Bergmann
2020-09-26 15:14 ` Arnd Bergmann
2020-09-26 15:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=ebiederm@xmission.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kexec@lists.infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.