Re: [PATCH v2 14/16] ASoC: codecs: wsa881x: add runtime pm support

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	quic_srivasam@quicinc.com
Subject: Re: [PATCH v2 14/16] ASoC: codecs: wsa881x: add runtime pm support
Date: Thu, 24 Feb 2022 16:13:50 +0000	[thread overview]
Message-ID: <86253ac7-ef06-974e-9b2d-6575ad5b7195@linaro.org> (raw)
In-Reply-To: <522ab282-ecc2-4186-2d77-f6241e255109@linux.intel.com>


On 24/02/2022 15:29, Pierre-Louis Bossart wrote:
> 
> 
> On 2/24/22 05:17, Srinivas Kandagatla wrote:
>> WSA881x codecs can not cope up with clk stop and requires a full reset after suspend.
>> WSA SoundWire Controller connected to this instances do a full soft reset on suspend.
> 
> is it the manager or peripheral that cannot cope with clock stop?
> 
>> @@ -1124,6 +1136,7 @@ static int wsa881x_probe(struct sdw_slave *pdev,
>>   	pdev->prop.sink_ports = GENMASK(WSA881X_MAX_SWR_PORTS, 0);
>>   	pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop;
>>   	pdev->prop.scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY;
>> +	pdev->prop.simple_clk_stop_capable = true;
> 
> here it's pretty clear the peripheral is capable of supporting clock
> stop, no?
> 
> Something's not clear between the commit message and the code.
True, This should be removed along with attempting to call clock stop 
functions from WSA SoundWire controller suspend that does not support 
clock stop.

--srini