From: Richard Weinberger <richard@nod.at> To: "Rafał Miłecki" <zajec5@gmail.com> Cc: Michael Walle <michael@walle.cc>, linux-mtd <linux-mtd@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls Date: Mon, 22 Mar 2021 18:54:12 +0100 (CET) [thread overview] Message-ID: <867376179.104878.1616435652773.JavaMail.zimbra@nod.at> (raw) In-Reply-To: <9fb7a635-75ed-2840-b751-3ab8764f0890@gmail.com> ----- Ursprüngliche Mail ----- > Von: "Rafał Miłecki" <zajec5@gmail.com> > An: "Michael Walle" <michael@walle.cc>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" > <linux-kernel@vger.kernel.org> > CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, > "Greg Kroah-Hartman" <gregkh@linuxfoundation.org> > Gesendet: Montag, 22. März 2021 17:39:41 > Betreff: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls > On 03.03.2021 16:57, Michael Walle wrote: >> MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require >> write permission. Depending on the hardware MEMLOCK might even be >> write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK >> is always write-once. >> >> MEMSETBADBLOCK modifies the bad block table. >> >> Fixes: f7e6b19bc764 ("mtd: properly check all write ioctls for permissions") >> Signed-off-by: Michael Walle <michael@walle.cc> > > Should be fine for OpenWrt tools to my best knowledge (and quick testing). > > Acked-by: Rafał Miłecki <rafal@milecki.pl> Nice! Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at> To: "Rafał Miłecki" <zajec5@gmail.com> Cc: Michael Walle <michael@walle.cc>, linux-mtd <linux-mtd@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls Date: Mon, 22 Mar 2021 18:54:12 +0100 (CET) [thread overview] Message-ID: <867376179.104878.1616435652773.JavaMail.zimbra@nod.at> (raw) In-Reply-To: <9fb7a635-75ed-2840-b751-3ab8764f0890@gmail.com> ----- Ursprüngliche Mail ----- > Von: "Rafał Miłecki" <zajec5@gmail.com> > An: "Michael Walle" <michael@walle.cc>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" > <linux-kernel@vger.kernel.org> > CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, > "Greg Kroah-Hartman" <gregkh@linuxfoundation.org> > Gesendet: Montag, 22. März 2021 17:39:41 > Betreff: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls > On 03.03.2021 16:57, Michael Walle wrote: >> MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require >> write permission. Depending on the hardware MEMLOCK might even be >> write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK >> is always write-once. >> >> MEMSETBADBLOCK modifies the bad block table. >> >> Fixes: f7e6b19bc764 ("mtd: properly check all write ioctls for permissions") >> Signed-off-by: Michael Walle <michael@walle.cc> > > Should be fine for OpenWrt tools to my best knowledge (and quick testing). > > Acked-by: Rafał Miłecki <rafal@milecki.pl> Nice! Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-22 17:55 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-03 15:57 [PATCH] mtd: require write permissions for locking and badblock ioctls Michael Walle 2021-03-03 15:57 ` Michael Walle 2021-03-03 16:08 ` Greg Kroah-Hartman 2021-03-03 16:08 ` Greg Kroah-Hartman 2021-03-03 16:17 ` Richard Weinberger 2021-03-03 16:17 ` Richard Weinberger 2021-03-03 16:25 ` Michael Walle 2021-03-03 16:25 ` Michael Walle 2021-03-03 16:34 ` Richard Weinberger 2021-03-03 16:34 ` Richard Weinberger 2021-03-22 16:39 ` Rafał Miłecki 2021-03-22 16:39 ` Rafał Miłecki 2021-03-22 17:54 ` Richard Weinberger [this message] 2021-03-22 17:54 ` Richard Weinberger 2021-03-28 17:28 ` Miquel Raynal 2021-03-28 17:28 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=867376179.104878.1616435652773.JavaMail.zimbra@nod.at \ --to=richard@nod.at \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=vigneshr@ti.com \ --cc=zajec5@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.