From: Marc Zyngier <maz@kernel.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Douglas Anderson <dianders@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allen-KH Cheng <allen-kh.cheng@mediatek.com>, linux-mediatek@lists.infradead.org, Eddie Huang <eddie.huang@mediatek.com>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, wenst@chromium.org, yidilin@chromium.org, Tinghan Shen <tinghan.shen@mediatek.com>, jwerner@chromium.org, Weiyi Lu <weiyi.lu@mediatek.com>, Ben Ho <Ben.Ho@mediatek.com>, Seiya Wang <seiya.wang@mediatek.com>, linux-kernel@vger.kernel.org, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: Re: [PATCH v2 2/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Date: Tue, 30 May 2023 10:46:37 +0100 [thread overview] Message-ID: <868rd6cfsy.wl-maz@kernel.org> (raw) In-Reply-To: <CAMuHMdWM_t7uQqkesM3fnSK7THrmLszA7U54==A0-98xPH90Bw@mail.gmail.com> On Tue, 30 May 2023 09:29:02 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Douglas, > > On Mon, May 15, 2023 at 10:16 PM Douglas Anderson <dianders@chromium.org> wrote: > > Some Chromebooks with Mediatek SoCs have a problem where the firmware > > doesn't properly save/restore certain GICR registers. Newer > > Chromebooks should fix this issue and we may be able to do firmware > > updates for old Chromebooks. At the moment, the only known issue with > > these Chromebooks is that we can't enable "pseudo NMIs" since the > > priority register can be lost. Enabling "pseudo NMIs" on Chromebooks > > with the problematic firmware causes crashes and freezes. > > > > Let's detect devices with this problem and then disable "pseudo NMIs" > > on them. We'll detect the problem by looking for the presence of the > > "mediatek,broken-save-restore-fw" property in the GIC device tree > > node. Any devices with fixed firmware will not have this property. > > > > Our detection plan works because we never bake a Chromebook's device > > tree into firmware. Instead, device trees are always bundled with the > > kernel. We'll update the device trees of all affected Chromebooks and > > then we'll never enable "pseudo NMI" on a kernel that is bundled with > > old device trees. When a firmware update is shipped that fixes this > > issue it will know to patch the device tree to remove the property. > > > > In order to make this work, the quick detection mechanism of the GICv3 > > code is extended to be able to look for properties in addition to > > looking at "compatible". > > > > Reviewed-by: Julius Werner <jwerner@chromium.org> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Changes in v2: > > - mediatek,gicr-save-quirk => mediatek,broken-save-restore-fw > > Thanks for your patch, which is now commit 44bd78dd2b8897f5 > ("irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ > firmware issues") in v6.4-rc4. > > This causes enabling an unrelated workaround on R-Car V4H: > > GIC: enabling workaround for GICv3: Cavium erratum 38539 > > > --- a/drivers/irqchip/irq-gic-common.c > > +++ b/drivers/irqchip/irq-gic-common.c > > @@ -16,7 +16,11 @@ void gic_enable_of_quirks(const struct device_node *np, > > const struct gic_quirk *quirks, void *data) > > { > > for (; quirks->desc; quirks++) { > > - if (!of_device_is_compatible(np, quirks->compatible)) > > + if (quirks->compatible && > > + !of_device_is_compatible(np, quirks->compatible)) > > + continue; > > + if (quirks->property && > > + !of_property_read_bool(np, quirks->property)) > > continue; > > Presumably the loop should continue if none of quirks-compatible > or quirks->property is set? Indeed, thanks for pointing that out. Can you give the following hack a go (compile tested only)? diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c index de47b51cdadb..7b591736ab58 100644 --- a/drivers/irqchip/irq-gic-common.c +++ b/drivers/irqchip/irq-gic-common.c @@ -16,6 +16,8 @@ void gic_enable_of_quirks(const struct device_node *np, const struct gic_quirk *quirks, void *data) { for (; quirks->desc; quirks++) { + if (!quirks->compatible && !quirks->property) + continue; if (quirks->compatible && !of_device_is_compatible(np, quirks->compatible)) continue; If that works for you, I'll queue it ASAP. Cheers, M. -- Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Douglas Anderson <dianders@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allen-KH Cheng <allen-kh.cheng@mediatek.com>, linux-mediatek@lists.infradead.org, Eddie Huang <eddie.huang@mediatek.com>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, wenst@chromium.org, yidilin@chromium.org, Tinghan Shen <tinghan.shen@mediatek.com>, jwerner@chromium.org, Weiyi Lu <weiyi.lu@mediatek.com>, Ben Ho <Ben.Ho@mediatek.com>, Seiya Wang <seiya.wang@mediatek.com>, linux-kernel@vger.kernel.org, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: Re: [PATCH v2 2/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Date: Tue, 30 May 2023 10:46:37 +0100 [thread overview] Message-ID: <868rd6cfsy.wl-maz@kernel.org> (raw) In-Reply-To: <CAMuHMdWM_t7uQqkesM3fnSK7THrmLszA7U54==A0-98xPH90Bw@mail.gmail.com> On Tue, 30 May 2023 09:29:02 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Douglas, > > On Mon, May 15, 2023 at 10:16 PM Douglas Anderson <dianders@chromium.org> wrote: > > Some Chromebooks with Mediatek SoCs have a problem where the firmware > > doesn't properly save/restore certain GICR registers. Newer > > Chromebooks should fix this issue and we may be able to do firmware > > updates for old Chromebooks. At the moment, the only known issue with > > these Chromebooks is that we can't enable "pseudo NMIs" since the > > priority register can be lost. Enabling "pseudo NMIs" on Chromebooks > > with the problematic firmware causes crashes and freezes. > > > > Let's detect devices with this problem and then disable "pseudo NMIs" > > on them. We'll detect the problem by looking for the presence of the > > "mediatek,broken-save-restore-fw" property in the GIC device tree > > node. Any devices with fixed firmware will not have this property. > > > > Our detection plan works because we never bake a Chromebook's device > > tree into firmware. Instead, device trees are always bundled with the > > kernel. We'll update the device trees of all affected Chromebooks and > > then we'll never enable "pseudo NMI" on a kernel that is bundled with > > old device trees. When a firmware update is shipped that fixes this > > issue it will know to patch the device tree to remove the property. > > > > In order to make this work, the quick detection mechanism of the GICv3 > > code is extended to be able to look for properties in addition to > > looking at "compatible". > > > > Reviewed-by: Julius Werner <jwerner@chromium.org> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Changes in v2: > > - mediatek,gicr-save-quirk => mediatek,broken-save-restore-fw > > Thanks for your patch, which is now commit 44bd78dd2b8897f5 > ("irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ > firmware issues") in v6.4-rc4. > > This causes enabling an unrelated workaround on R-Car V4H: > > GIC: enabling workaround for GICv3: Cavium erratum 38539 > > > --- a/drivers/irqchip/irq-gic-common.c > > +++ b/drivers/irqchip/irq-gic-common.c > > @@ -16,7 +16,11 @@ void gic_enable_of_quirks(const struct device_node *np, > > const struct gic_quirk *quirks, void *data) > > { > > for (; quirks->desc; quirks++) { > > - if (!of_device_is_compatible(np, quirks->compatible)) > > + if (quirks->compatible && > > + !of_device_is_compatible(np, quirks->compatible)) > > + continue; > > + if (quirks->property && > > + !of_property_read_bool(np, quirks->property)) > > continue; > > Presumably the loop should continue if none of quirks-compatible > or quirks->property is set? Indeed, thanks for pointing that out. Can you give the following hack a go (compile tested only)? diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c index de47b51cdadb..7b591736ab58 100644 --- a/drivers/irqchip/irq-gic-common.c +++ b/drivers/irqchip/irq-gic-common.c @@ -16,6 +16,8 @@ void gic_enable_of_quirks(const struct device_node *np, const struct gic_quirk *quirks, void *data) { for (; quirks->desc; quirks++) { + if (!quirks->compatible && !quirks->property) + continue; if (quirks->compatible && !of_device_is_compatible(np, quirks->compatible)) continue; If that works for you, I'll queue it ASAP. Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-30 9:46 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-15 20:13 [PATCH v2 0/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek Chromebooks w/ bad FW Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-15 20:13 ` [PATCH v2 1/5] dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-16 10:22 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Douglas Anderson 2023-05-16 13:24 ` [PATCH v2 1/5] " AngeloGioacchino Del Regno 2023-05-16 13:24 ` AngeloGioacchino Del Regno 2023-05-15 20:13 ` [PATCH v2 2/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-16 10:22 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Douglas Anderson 2023-05-16 13:23 ` [PATCH v2 2/5] " AngeloGioacchino Del Regno 2023-05-16 13:23 ` AngeloGioacchino Del Regno 2023-05-16 14:19 ` Doug Anderson 2023-05-16 14:19 ` Doug Anderson 2023-05-16 14:57 ` Marc Zyngier 2023-05-16 14:57 ` Marc Zyngier 2023-05-30 8:29 ` Geert Uytterhoeven 2023-05-30 8:29 ` Geert Uytterhoeven 2023-05-30 9:46 ` Marc Zyngier [this message] 2023-05-30 9:46 ` Marc Zyngier 2023-05-30 9:58 ` Geert Uytterhoeven 2023-05-30 9:58 ` Geert Uytterhoeven 2023-05-30 16:36 ` Doug Anderson 2023-05-30 16:36 ` Doug Anderson 2023-05-15 20:13 ` [PATCH v2 3/5] arm64: dts: mediatek: mt8183: Add mediatek,broken-save-restore-fw to kukui Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-15 20:13 ` [PATCH v2 4/5] arm64: dts: mediatek: mt8192: Add mediatek,broken-save-restore-fw to asurada Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-15 20:13 ` [PATCH v2 5/5] arm64: dts: mediatek: mt8195: Add mediatek,broken-save-restore-fw to cherry Douglas Anderson 2023-05-15 20:13 ` Douglas Anderson 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-16 13:18 ` AngeloGioacchino Del Regno 2023-05-16 9:58 ` [PATCH v2 0/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek Chromebooks w/ bad FW Marc Zyngier 2023-05-16 9:58 ` Marc Zyngier 2023-05-29 15:41 ` Matthias Brugger 2023-05-29 15:41 ` Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=868rd6cfsy.wl-maz@kernel.org \ --to=maz@kernel.org \ --cc=Ben.Ho@mediatek.com \ --cc=allen-kh.cheng@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=eddie.huang@mediatek.com \ --cc=geert@linux-m68k.org \ --cc=hsin-hsiung.wang@mediatek.com \ --cc=jwerner@chromium.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=seiya.wang@mediatek.com \ --cc=tglx@linutronix.de \ --cc=tinghan.shen@mediatek.com \ --cc=weiyi.lu@mediatek.com \ --cc=wenst@chromium.org \ --cc=yidilin@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.