From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ia64: fix sparse warnings with cmpxchg() & xchg()
Date: Mon, 06 Jun 2022 09:53:32 +0200 [thread overview]
Message-ID: <871qw2xm6b.fsf@toke.dk> (raw)
In-Reply-To: <20220605160738.79736-1-luc.vanoostenryck@gmail.com>
Luc Van Oostenryck <luc.vanoostenryck@gmail.com> writes:
> On IA64, new sparse's warnings where issued after fixing
> some __rcu annotations in kernel/bpf/.
>
> These new warnings are false positives and appear on IA64 because
> on this architecture, the macros for cmpxchg() and xchg() make
> casts that ignore sparse annotations.
>
> This patch contains the minimal patch to fix this issue:
> adding a missing cast and some missing '__force'.
>
> Link: https://lore.kernel.org/r/20220601120013.bq5a3ynbkc3hngm5@mail
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Ah, thank you for taking care of this! :)
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ia64: fix sparse warnings with cmpxchg() & xchg()
Date: Mon, 06 Jun 2022 07:53:32 +0000 [thread overview]
Message-ID: <871qw2xm6b.fsf@toke.dk> (raw)
In-Reply-To: <20220605160738.79736-1-luc.vanoostenryck@gmail.com>
Luc Van Oostenryck <luc.vanoostenryck@gmail.com> writes:
> On IA64, new sparse's warnings where issued after fixing
> some __rcu annotations in kernel/bpf/.
>
> These new warnings are false positives and appear on IA64 because
> on this architecture, the macros for cmpxchg() and xchg() make
> casts that ignore sparse annotations.
>
> This patch contains the minimal patch to fix this issue:
> adding a missing cast and some missing '__force'.
>
> Link: https://lore.kernel.org/r/20220601120013.bq5a3ynbkc3hngm5@mail
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Ah, thank you for taking care of this! :)
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2022-06-06 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 12:30 kernel/bpf/devmap.c:1030:40: sparse: sparse: cast removes address space '__rcu' of expression kernel test robot
2022-05-23 10:30 ` Toke Høiland-Jørgensen
2022-05-23 10:30 ` Toke Høiland-Jørgensen
2022-05-24 20:51 ` Paul E. McKenney
2022-05-24 20:51 ` Paul E. McKenney
2022-06-01 0:38 ` Luc Van Oostenryck
2022-06-01 0:38 ` Luc Van Oostenryck
2022-06-01 10:26 ` Toke Høiland-Jørgensen
2022-06-01 10:26 ` Toke Høiland-Jørgensen
2022-06-01 11:59 ` Luc Van Oostenryck
2022-06-01 12:00 ` Luc Van Oostenryck
2022-06-01 12:00 ` Luc Van Oostenryck
2022-06-05 16:07 ` [PATCH] ia64: fix sparse warnings with cmpxchg() & xchg() Luc Van Oostenryck
2022-06-05 16:07 ` Luc Van Oostenryck
2022-06-05 19:58 ` Paul E. McKenney
2022-06-05 19:58 ` Paul E. McKenney
2022-06-06 7:53 ` Toke Høiland-Jørgensen [this message]
2022-06-06 7:53 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qw2xm6b.fsf@toke.dk \
--to=toke@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.