From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Gustavo Sousa <gustavo.sousa@intel.com>
Subject: Re: [PATCH] drm/i915/display: move dmc_firmware_path to display params
Date: Tue, 02 Apr 2024 11:47:08 +0300 [thread overview]
Message-ID: <8734s4f8xf.fsf@intel.com> (raw)
In-Reply-To: <3bvm45xgjhlwuwc2hhenysknzm2reaj5yn6anvyzmerpi44vgb@jjnbrf2ejnk5>
On Fri, 22 Mar 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> oh, now I understand. You mean that xe module doesn't have the param
> because it's only declared in drivers/gpu/drm/i915/i915_params.c.
>
> Could you extend the commit message with something like this?
>
> The dmc_firmware_path parameter is clearly a display parameter. Move it
> there so it's available to both i915 and xe modules ....
>
> thanks
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks for the review, pushed to drm-intel-next with an amended commit
message.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-02 8:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 16:18 [PATCH] drm/i915/display: move dmc_firmware_path to display params Jani Nikula
2024-03-21 16:20 ` Jani Nikula
2024-03-22 4:34 ` Lucas De Marchi
2024-03-22 8:48 ` Jani Nikula
2024-03-22 16:06 ` Lucas De Marchi
2024-03-22 18:32 ` Lucas De Marchi
2024-04-02 8:47 ` Jani Nikula [this message]
2024-03-21 19:35 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-21 19:35 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-21 19:36 ` ✓ CI.KUnit: success " Patchwork
2024-03-21 19:47 ` ✓ CI.Build: " Patchwork
2024-03-21 19:49 ` ✓ CI.Hooks: " Patchwork
2024-03-21 19:51 ` ✗ CI.checksparse: warning " Patchwork
2024-03-21 20:14 ` ✓ CI.BAT: success " Patchwork
2024-03-21 23:52 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-03-21 23:52 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-22 0:02 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734s4f8xf.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.