Re: [PATCH] drm/i915/display: move dmc_firmware_path to display params

From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>,
	Gustavo Sousa <gustavo.sousa@intel.com>
Subject: Re: [PATCH] drm/i915/display: move dmc_firmware_path to display params
Date: Fri, 22 Mar 2024 11:06:20 -0500	[thread overview]
Message-ID: <b7o4x73ht2wv6t52h44dofzu36oic3bfazfilt2o4oxuj3zxzg@rzwm4a7cro7p> (raw)
In-Reply-To: <87v85elkic.fsf@intel.com>

On Fri, Mar 22, 2024 at 10:48:43AM +0200, Jani Nikula wrote:
>On Thu, 21 Mar 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> On Thu, Mar 21, 2024 at 06:20:57PM +0200, Jani Nikula wrote:
>>>On Thu, 21 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>>>> The dmc_firmware_path parameter is clearly a display parameter. Move it
>>>> there. This also cleans up the ugly member in struct xe_device.
>>>
>>>Hmm, does this actually fix the parameter on xe?!
>>
>> not sure what you meant here. Patches makes sense to me.
>
>Unless I'm mistaken, the parameter currently does not work on xe at
>all. I only realized after posting the patch that this probably fixes
>that issue too.

+Gustavo

I never really tried the dmc_firmware_path param, but current code
contains:

drivers/gpu/drm/i915/display/intel_dmc.c:       if (err == -ENOENT && !i915->params.dmc_firmware_path) {
drivers/gpu/drm/i915/display/intel_dmc.c:       if (i915->params.dmc_firmware_path) {
drivers/gpu/drm/i915/display/intel_dmc.c:               if (strlen(i915->params.dmc_firmware_path) == 0) {
drivers/gpu/drm/i915/display/intel_dmc.c:               dmc->fw_path = i915->params.dmc_firmware_path;
drivers/gpu/drm/i915/i915_params.c:i915_param_named_unsafe(dmc_firmware_path, charp, 0400,
drivers/gpu/drm/i915/i915_params.h:     param(char *, dmc_firmware_path, NULL, 0400) \
drivers/gpu/drm/xe/xe_device_types.h:           const char *dmc_firmware_path;

So dmc_firmware_path is only dealt with inside display... it would be
odd if it was not working. I'll double check.

Lucas De Marchi