From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: Jes Sorensen <jes.sorensen@gmail.com>,
linux-wireless@vger.kernel.org, chris.chiu@canonical.com,
Barry Day <briselec@gmail.com>
Subject: Re: [PATCH 1/4] wifi: rtl8xxxu: gen2: Turn on the rate control
Date: Wed, 28 Sep 2022 11:39:31 +0300 [thread overview]
Message-ID: <8735cb7v0c.fsf@kernel.org> (raw)
In-Reply-To: <5ba1e0f4-6eda-43bb-d426-e2a9447cd06e@gmail.com> (Bitterblue Smith's message of "Tue, 27 Sep 2022 22:49:05 +0300")
Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> On 25/09/2022 19:53, Jes Sorensen wrote:
>> On 9/18/22 08:35, Bitterblue Smith wrote:
>>> Inform the firmware when connecting to a network. This makes the
>>> firmware enable the rate control, which makes the upload faster.
>>>
>>> Don't inform the firmware when disconnecting from a network, because
>>> that makes reconnecting impossible for some reason:
>>
>> Have you dug through the vendor driver to see what it does here?
>>
>> Thanks,
>> Jes
>>
>
> I hadn't investigated, but since you asked :) I looked into it today.
>
> The vendor driver doesn't do anything weird. Our report_connect
> function *should* work.
>
> And it turns out it does work! I restored the original form of the
> function to test something and reconnecting worked. I couldn't
> reproduce the problem anymore. Not much has changed in rtl8xxxu since
> the last time I tried this, so it was easy to find the reason: fixing
> the queue selection [0] fixed the reconnecting problem. Before, it was
> sending the auth attempts using queue 0x7 (TXDESC_QUEUE_VO). With the
> queue selection fix it uses queue 0x12 (TXDESC_QUEUE_MGNT). Perhaps
> queue 0x7 is not functional when the firmware knows it's not connected
> to a network?
>
> I guess I have to send a different patch for this now.
So what should I do with this patchset? Can I take patches 2-4?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-09-28 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 12:26 [PATCH 0/4] wifi: rtl8xxxu: A few improvements Bitterblue Smith
2022-09-18 12:35 ` [PATCH 1/4] wifi: rtl8xxxu: gen2: Turn on the rate control Bitterblue Smith
2022-09-25 16:53 ` Jes Sorensen
2022-09-27 19:49 ` Bitterblue Smith
2022-09-28 8:39 ` Kalle Valo [this message]
2022-09-28 9:52 ` Bitterblue Smith
2022-09-28 11:07 ` Kalle Valo
2022-09-18 12:40 ` [PATCH 2/4] wifi: rtl8xxxu: gen2: Enable 40 MHz channel width Bitterblue Smith
2022-09-25 16:55 ` Jes Sorensen
2022-09-29 6:18 ` Kalle Valo
2022-09-18 12:42 ` [PATCH 3/4] wifi: rtl8xxxu: Fix AIFS written to REG_EDCA_*_PARAM Bitterblue Smith
2022-09-25 16:56 ` Jes Sorensen
2022-09-26 9:24 ` Kalle Valo
2022-09-18 12:47 ` [PATCH 4/4] wifi: rtl8xxxu: Improve rtl8xxxu_queue_select Bitterblue Smith
2022-09-25 16:57 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735cb7v0c.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=briselec@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.