From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Jes Sorensen <Jes.Sorensen@gmail.com>,
chris.chiu@canonical.com
Subject: Re: [PATCH 3/4] wifi: rtl8xxxu: Fix AIFS written to REG_EDCA_*_PARAM
Date: Mon, 26 Sep 2022 12:24:41 +0300 [thread overview]
Message-ID: <877d1q7ajq.fsf@kernel.org> (raw)
In-Reply-To: <038cc03f-3567-77ba-a7bd-c4930e3b2fad@gmail.com> (Bitterblue Smith's message of "Sun, 18 Sep 2022 15:42:25 +0300")
Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> ieee80211_tx_queue_params.aifs is not supposed to be written directly
> to the REG_EDCA_*_PARAM registers. Instead process it like the vendor
> drivers do. It's kinda hacky but it works.
>
> This change boosts the download speed and makes it more stable.
>
> Tested with RTL8188FU but all the other supported chips should also
> benefit.
>
> Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)")
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
[...]
> +static void rtl8xxxu_set_aifs(struct rtl8xxxu_priv *priv, u8 slot_time)
> +{
> + u32 reg_edca_param[IEEE80211_NUM_ACS] = {
> + [IEEE80211_AC_VO] = REG_EDCA_VO_PARAM,
> + [IEEE80211_AC_VI] = REG_EDCA_VI_PARAM,
> + [IEEE80211_AC_BE] = REG_EDCA_BE_PARAM,
> + [IEEE80211_AC_BK] = REG_EDCA_BK_PARAM,
> + };
static const?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-09-26 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 12:26 [PATCH 0/4] wifi: rtl8xxxu: A few improvements Bitterblue Smith
2022-09-18 12:35 ` [PATCH 1/4] wifi: rtl8xxxu: gen2: Turn on the rate control Bitterblue Smith
2022-09-25 16:53 ` Jes Sorensen
2022-09-27 19:49 ` Bitterblue Smith
2022-09-28 8:39 ` Kalle Valo
2022-09-28 9:52 ` Bitterblue Smith
2022-09-28 11:07 ` Kalle Valo
2022-09-18 12:40 ` [PATCH 2/4] wifi: rtl8xxxu: gen2: Enable 40 MHz channel width Bitterblue Smith
2022-09-25 16:55 ` Jes Sorensen
2022-09-29 6:18 ` Kalle Valo
2022-09-18 12:42 ` [PATCH 3/4] wifi: rtl8xxxu: Fix AIFS written to REG_EDCA_*_PARAM Bitterblue Smith
2022-09-25 16:56 ` Jes Sorensen
2022-09-26 9:24 ` Kalle Valo [this message]
2022-09-18 12:47 ` [PATCH 4/4] wifi: rtl8xxxu: Improve rtl8xxxu_queue_select Bitterblue Smith
2022-09-25 16:57 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d1q7ajq.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jes.Sorensen@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.