From: Michael Ellerman <mpe@ellerman.id.au> To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, David Hildenbrand <david@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Michal Hocko <mhocko@kernel.org>, Oscar Salvador <osalvador@suse.de>, "Rafael J. Wysocki" <rafael@kernel.org>, Baoquan He <bhe@redhat.com>, Wei Yang <richard.weiyang@gmail.com> Subject: Re: [PATCH v2 4/8] powernv/memtrace: always online added memory blocks Date: Thu, 19 Mar 2020 20:49:47 +1100 [thread overview] Message-ID: <8736a4eksk.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <20200317104942.11178-5-david@redhat.com> David Hildenbrand <david@redhat.com> writes: > Let's always try to online the re-added memory blocks. In case add_memory() > already onlined the added memory blocks, the first device_online() call > will fail and stop processing the remaining memory blocks. > > This avoids manually having to check memhp_auto_online. > > Note: PPC always onlines all hotplugged memory directly from the kernel > as well - something that is handled by user space on other > architectures. > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Baoquan He <bhe@redhat.com> > Cc: Wei Yang <richard.weiyang@gmail.com> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > arch/powerpc/platforms/powernv/memtrace.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Fine by me. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers > diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c > index d6d64f8718e6..13b369d2cc45 100644 > --- a/arch/powerpc/platforms/powernv/memtrace.c > +++ b/arch/powerpc/platforms/powernv/memtrace.c > @@ -231,16 +231,10 @@ static int memtrace_online(void) > continue; > } > > - /* > - * If kernel isn't compiled with the auto online option > - * we need to online the memory ourselves. > - */ > - if (!memhp_auto_online) { > - lock_device_hotplug(); > - walk_memory_blocks(ent->start, ent->size, NULL, > - online_mem_block); > - unlock_device_hotplug(); > - } > + lock_device_hotplug(); > + walk_memory_blocks(ent->start, ent->size, NULL, > + online_mem_block); > + unlock_device_hotplug(); > > /* > * Memory was added successfully so clean up references to it > -- > 2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au> To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org Cc: linux-hyperv@vger.kernel.org, Baoquan He <bhe@redhat.com>, David Hildenbrand <david@redhat.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org, Paul Mackerras <paulus@samba.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Wei Yang <richard.weiyang@gmail.com>, linuxppc-dev@lists.ozlabs.org, Oscar Salvador <osalvador@suse.de> Subject: Re: [PATCH v2 4/8] powernv/memtrace: always online added memory blocks Date: Thu, 19 Mar 2020 20:49:47 +1100 [thread overview] Message-ID: <8736a4eksk.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <20200317104942.11178-5-david@redhat.com> David Hildenbrand <david@redhat.com> writes: > Let's always try to online the re-added memory blocks. In case add_memory() > already onlined the added memory blocks, the first device_online() call > will fail and stop processing the remaining memory blocks. > > This avoids manually having to check memhp_auto_online. > > Note: PPC always onlines all hotplugged memory directly from the kernel > as well - something that is handled by user space on other > architectures. > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Baoquan He <bhe@redhat.com> > Cc: Wei Yang <richard.weiyang@gmail.com> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > arch/powerpc/platforms/powernv/memtrace.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Fine by me. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers > diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c > index d6d64f8718e6..13b369d2cc45 100644 > --- a/arch/powerpc/platforms/powernv/memtrace.c > +++ b/arch/powerpc/platforms/powernv/memtrace.c > @@ -231,16 +231,10 @@ static int memtrace_online(void) > continue; > } > > - /* > - * If kernel isn't compiled with the auto online option > - * we need to online the memory ourselves. > - */ > - if (!memhp_auto_online) { > - lock_device_hotplug(); > - walk_memory_blocks(ent->start, ent->size, NULL, > - online_mem_block); > - unlock_device_hotplug(); > - } > + lock_device_hotplug(); > + walk_memory_blocks(ent->start, ent->size, NULL, > + online_mem_block); > + unlock_device_hotplug(); > > /* > * Memory was added successfully so clean up references to it > -- > 2.24.1
next prev parent reply other threads:[~2020-03-19 9:49 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-17 10:49 [PATCH v2 0/8] mm/memory_hotplug: allow to specify a default online_type David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:49 ` [PATCH v2 1/8] drivers/base/memory: rename MMOP_ONLINE_KEEP to MMOP_ONLINE David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:49 ` [PATCH v2 2/8] drivers/base/memory: map MMOP_OFFLINE to 0 David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:49 ` [PATCH v2 3/8] drivers/base/memory: store mapping between MMOP_* and string in an array David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:49 ` [PATCH v2 4/8] powernv/memtrace: always online added memory blocks David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:58 ` Michal Hocko 2020-03-17 10:58 ` Michal Hocko 2020-03-17 22:04 ` Wei Yang 2020-03-17 22:04 ` Wei Yang 2020-03-19 9:49 ` Michael Ellerman [this message] 2020-03-19 9:49 ` Michael Ellerman 2020-03-17 10:49 ` [PATCH v2 5/8] hv_balloon: don't check for memhp_auto_online manually David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 16:29 ` Vitaly Kuznetsov 2020-03-17 16:29 ` Vitaly Kuznetsov 2020-03-17 16:33 ` David Hildenbrand 2020-03-17 16:33 ` David Hildenbrand 2020-03-17 18:46 ` David Hildenbrand 2020-03-17 18:46 ` David Hildenbrand 2020-03-17 10:49 ` [PATCH v2 6/8] mm/memory_hotplug: unexport memhp_auto_online David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 10:59 ` Michal Hocko 2020-03-17 10:59 ` Michal Hocko 2020-03-17 22:24 ` Wei Yang 2020-03-17 22:24 ` Wei Yang 2020-03-17 10:49 ` [PATCH v2 7/8] mm/memory_hotplug: convert memhp_auto_online to store an online_type David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 11:00 ` Michal Hocko 2020-03-17 11:00 ` Michal Hocko 2020-03-17 10:49 ` [PATCH v2 8/8] mm/memory_hotplug: allow to specify a default online_type David Hildenbrand 2020-03-17 10:49 ` David Hildenbrand 2020-03-17 11:01 ` Michal Hocko 2020-03-17 11:01 ` Michal Hocko 2020-03-17 11:05 ` David Hildenbrand 2020-03-17 11:05 ` David Hildenbrand 2020-03-17 11:08 ` David Hildenbrand 2020-03-17 11:08 ` David Hildenbrand 2020-03-18 13:05 ` [PATCH v2 0/8] " Baoquan He 2020-03-18 13:05 ` Baoquan He 2020-03-18 13:50 ` David Hildenbrand 2020-03-18 13:50 ` David Hildenbrand 2020-03-18 14:50 ` Baoquan He 2020-03-18 14:50 ` Baoquan He 2020-03-18 13:54 ` Michal Hocko 2020-03-18 13:54 ` Michal Hocko 2020-03-18 14:41 ` Baoquan He 2020-03-18 14:41 ` Baoquan He 2020-03-18 13:58 ` Vitaly Kuznetsov 2020-03-18 13:58 ` Vitaly Kuznetsov 2020-03-18 14:41 ` Baoquan He 2020-03-18 14:41 ` Baoquan He 2020-03-18 15:00 ` Vitaly Kuznetsov 2020-03-18 15:00 ` Vitaly Kuznetsov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8736a4eksk.fsf@mpe.ellerman.id.au \ --to=mpe@ellerman.id.au \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=bhe@redhat.com \ --cc=david@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mhocko@kernel.org \ --cc=osalvador@suse.de \ --cc=paulus@samba.org \ --cc=rafael@kernel.org \ --cc=richard.weiyang@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.