From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Miquel RAYNAL <miquel.raynal@free-electrons.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@free-electrons.com, andrew@lunn.ch,
marc.zyngier@arm.com, jaz@semihalf.com, hannah@marvell.com,
nadavh@marvell.com, neta@marvell.com, mark.rutland@arm.com,
zbodek@gmail.com
Subject: Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin
Date: Thu, 03 Aug 2017 14:23:07 +0200 [thread overview]
Message-ID: <873798alhw.fsf@free-electrons.com> (raw)
In-Reply-To: <20170802191608.58aa312e@xps13> (Miquel RAYNAL's message of "Wed, 2 Aug 2017 19:16:08 +0200")
Hi Marcin,
On mer., août 02 2017, Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote:
> Hi,
>
> On Fri, 21 Jul 2017 01:50:36 +0200
> Marcin Wojtas <mw@semihalf.com> wrote:
>
>> The ESPRESSObin board exposes one of the SDHCI interfaces
>> via J1 uSD slot. This patch enables it.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Signed-off-by: Zbigniew Bodek <zbodek@gmail.com>
>
> Tested-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Applied on mvebu/dt64 (I also removed the "no-1-8-v" property while
applying it becauseit was obviously wrong)
Thanks,
Gregory
>
>> ---
>> .../boot/dts/marvell/armada-3720-espressobin.dts | 26
>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
>> b1af3f98..6d0caf1 100644 ---
>> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
>> +45,7 @@
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> #include "armada-372x.dtsi"
>>
>> / {
>> @@ -59,6 +60,20 @@
>> device_type = "memory";
>> reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
>> };
>> +
>> + vcc_sd_reg1: regulator {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vcc_sd1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> +
>> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
>> + gpios-states = <0>;
>> + states = <1800000 0x1
>> + 3300000 0x0>;
>> + enable-active-high;
>> + };
>> };
>>
>> /* J9 */
>> @@ -71,6 +86,17 @@
>> status = "okay";
>> };
>>
>> +/* J1 */
>> +&sdhci1 {
>> + wp-inverted;
>> + bus-width = <4>;
>> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
>> + no-1-8-v;
>> + marvell,pad-type = "sd";
>> + vqmmc-supply = <&vcc_sd_reg1>;
>> + status = "okay";
>> +};
>> +
>> /* Exported on the micro USB connector J5 through an FTDI */
>> &uart0 {
>> status = "okay";
>
>
>
> --
> Miquel Raynal, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin
Date: Thu, 03 Aug 2017 14:23:07 +0200 [thread overview]
Message-ID: <873798alhw.fsf@free-electrons.com> (raw)
In-Reply-To: <20170802191608.58aa312e@xps13> (Miquel RAYNAL's message of "Wed, 2 Aug 2017 19:16:08 +0200")
Hi Marcin,
On mer., ao?t 02 2017, Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote:
> Hi,
>
> On Fri, 21 Jul 2017 01:50:36 +0200
> Marcin Wojtas <mw@semihalf.com> wrote:
>
>> The ESPRESSObin board exposes one of the SDHCI interfaces
>> via J1 uSD slot. This patch enables it.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Signed-off-by: Zbigniew Bodek <zbodek@gmail.com>
>
> Tested-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Applied on mvebu/dt64 (I also removed the "no-1-8-v" property while
applying it becauseit was obviously wrong)
Thanks,
Gregory
>
>> ---
>> .../boot/dts/marvell/armada-3720-espressobin.dts | 26
>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
>> b1af3f98..6d0caf1 100644 ---
>> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
>> +45,7 @@
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> #include "armada-372x.dtsi"
>>
>> / {
>> @@ -59,6 +60,20 @@
>> device_type = "memory";
>> reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
>> };
>> +
>> + vcc_sd_reg1: regulator {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vcc_sd1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> +
>> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
>> + gpios-states = <0>;
>> + states = <1800000 0x1
>> + 3300000 0x0>;
>> + enable-active-high;
>> + };
>> };
>>
>> /* J9 */
>> @@ -71,6 +86,17 @@
>> status = "okay";
>> };
>>
>> +/* J1 */
>> +&sdhci1 {
>> + wp-inverted;
>> + bus-width = <4>;
>> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
>> + no-1-8-v;
>> + marvell,pad-type = "sd";
>> + vqmmc-supply = <&vcc_sd_reg1>;
>> + status = "okay";
>> +};
>> +
>> /* Exported on the micro USB connector J5 through an FTDI */
>> &uart0 {
>> status = "okay";
>
>
>
> --
> Miquel Raynal, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-08-03 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 23:50 [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin Marcin Wojtas
2017-07-20 23:50 ` Marcin Wojtas
2017-08-02 17:16 ` Miquel RAYNAL
2017-08-02 17:16 ` Miquel RAYNAL
2017-08-03 12:23 ` Gregory CLEMENT [this message]
2017-08-03 12:23 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873798alhw.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=hannah@marvell.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=neta@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zbodek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.