From: Kalle Valo <kvalo@qca.qualcomm.com> To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org> Subject: Re: [PATCH v2 6/8] ath10k: add support to send addba request Date: Mon, 12 Jan 2015 13:42:20 +0200 [thread overview] Message-ID: <87387gfco3.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1419407949-32367-7-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Wed, 24 Dec 2014 13:29:07 +0530") Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > This per-station debugfs entry helps to send addba request in manual > mode. Need to pass two configuration parameters (tid, buffer size) > as input. > > To send addba, > > echo 1 32 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ > stations/XX:XX:XX:XX:XX:XX/addba > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> [...] > + ret = sscanf(buf, "%u %u", &tid, &buf_size); > + if (ret != 2) { > + ath10k_warn(ar, "ex: echo <tid> <buffer size> >addba\n"); > + return -EINVAL; > + } > + > + /* Valid TID values are 0 through 15 */ > + if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) { > + ath10k_warn(ar, "Invalid TID %u\n", tid); > + return -EINVAL; > + } It's preferred that the driver doesn't print anything based on wrong user input, so I removed these two warning messages: --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c @@ -97,16 +97,12 @@ static ssize_t ath10k_dbg_sta_write_addba(struct file *file, buf[sizeof(buf) - 1] = '\0'; ret = sscanf(buf, "%u %u", &tid, &buf_size); - if (ret != 2) { - ath10k_warn(ar, "ex: echo <tid> <buffer size> >addba\n"); + if (ret != 2) return -EINVAL; - } /* Valid TID values are 0 through 15 */ - if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) { - ath10k_warn(ar, "Invalid TID %u\n", tid); + if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) return -EINVAL; - } mutex_lock(&ar->conf_mutex); if ((ar->state != ATH10K_STATE_ON) || -- Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com> To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2 6/8] ath10k: add support to send addba request Date: Mon, 12 Jan 2015 13:42:20 +0200 [thread overview] Message-ID: <87387gfco3.fsf@kamboji.qca.qualcomm.com> (raw) In-Reply-To: <1419407949-32367-7-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Wed, 24 Dec 2014 13:29:07 +0530") Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > This per-station debugfs entry helps to send addba request in manual > mode. Need to pass two configuration parameters (tid, buffer size) > as input. > > To send addba, > > echo 1 32 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ > stations/XX:XX:XX:XX:XX:XX/addba > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> [...] > + ret = sscanf(buf, "%u %u", &tid, &buf_size); > + if (ret != 2) { > + ath10k_warn(ar, "ex: echo <tid> <buffer size> >addba\n"); > + return -EINVAL; > + } > + > + /* Valid TID values are 0 through 15 */ > + if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) { > + ath10k_warn(ar, "Invalid TID %u\n", tid); > + return -EINVAL; > + } It's preferred that the driver doesn't print anything based on wrong user input, so I removed these two warning messages: --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c @@ -97,16 +97,12 @@ static ssize_t ath10k_dbg_sta_write_addba(struct file *file, buf[sizeof(buf) - 1] = '\0'; ret = sscanf(buf, "%u %u", &tid, &buf_size); - if (ret != 2) { - ath10k_warn(ar, "ex: echo <tid> <buffer size> >addba\n"); + if (ret != 2) return -EINVAL; - } /* Valid TID values are 0 through 15 */ - if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) { - ath10k_warn(ar, "Invalid TID %u\n", tid); + if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) return -EINVAL; - } mutex_lock(&ar->conf_mutex); if ((ar->state != ATH10K_STATE_ON) || -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-01-12 11:42 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-24 7:59 [PATCH v2 0/8] ath10k: add per station debugfs support Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2014-12-24 7:59 ` [PATCH v2 1/8] ath10k: add wmi support for addba_clear_resp Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2014-12-24 7:59 ` [PATCH v2 2/8] ath10k: add wmi support for addba_send Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2014-12-24 7:59 ` [PATCH v2 3/8] ath10k: add wmi support for addba_set_resp Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2014-12-24 7:59 ` [PATCH v2 4/8] ath10k: add wmi support for delba_send Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2014-12-24 7:59 ` [PATCH v2 5/8] ath10k: Implement sta_add_debugfs Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2015-01-12 11:37 ` Kalle Valo 2015-01-12 11:37 ` Kalle Valo 2014-12-24 7:59 ` [PATCH v2 6/8] ath10k: add support to send addba request Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2015-01-12 11:42 ` Kalle Valo [this message] 2015-01-12 11:42 ` Kalle Valo 2014-12-24 7:59 ` [PATCH v2 7/8] ath10k: add support to send addba response Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2015-01-12 11:43 ` Kalle Valo 2015-01-12 11:43 ` Kalle Valo 2014-12-24 7:59 ` [PATCH v2 8/8] ath10k: add support to send delba Rajkumar Manoharan 2014-12-24 7:59 ` Rajkumar Manoharan 2015-01-12 11:45 ` Kalle Valo 2015-01-12 11:45 ` Kalle Valo 2015-01-13 14:15 ` [PATCH v2 0/8] ath10k: add per station debugfs support Kalle Valo 2015-01-13 14:15 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87387gfco3.fsf@kamboji.qca.qualcomm.com \ --to=kvalo@qca.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=rmanohar@qti.qualcomm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.