From: Michael Ellerman <mpe@ellerman.id.au>
To: Tim.Bird@sony.com, shuah@kernel.org, cristian.marussi@arm.com,
linux-kselftest@vger.kernel.org
Subject: RE: kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set
Date: Thu, 28 Nov 2019 15:17:20 +1100 [thread overview]
Message-ID: <874kyo1vov.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ECADFF3FD767C149AD96A924E7EA6EAF982B3745@USCULXMSG17.am.sony.com>
<Tim.Bird@sony.com> writes:
>> -----Original Message-----
>> From: linux-kselftest-owner@vger.kernel.org [mailto:linux-kselftest-
>> owner@vger.kernel.org] On Behalf Of shuah
>> Sent: Wednesday, November 27, 2019 5:33 PM
>> To: Cristian Marussi <cristian.marussi@arm.com>; Michael Ellerman
>> <mpe@ellerman.id.au>; Bird, Tim <Tim.Bird@sony.com>; linux-
>> kselftest@vger.kernel.org; shuah <shuah@kernel.org>
>> Subject: Re: kselftest: failed to build with -C tool/testing/selftests when
>> KBUILD_OUTPUT is set
>>
>> On 11/27/19 9:53 AM, Cristian Marussi wrote:
...
>> > Well I'm not sure if it covers all the build cases/scenario for CIs and I have
>> > only verified that this specific failure seems to work using the toplevel Makefile
>> > targets (since the offending commit uses abs-objtree).
>> > Anyway $ ./kselftest_install.sh is broken too as of now.
>>
>> With the revert, it will go back to not having support for relative
>> paths :(
>>
>> I will look into reverting the offending commit or fixing it.
>
> There may not be many people using relative paths for KBUILD_OUTPUT.
> I was affected by it, and it's quite handy given some of the mechanisms in
> my CI system, but it's not that hard to work around. (That is, I can just
> convert relative paths to absolute paths in a few key places in my
> CI, before calling the kernel make.)
>
> Given that I'm the only person (seemingly) who reported this, and I'm ok
> working around it, I think a revert is OK for now.
I think that would be best at this stage, every day this is unfixed is
another day that selftests aren't getting built and tested.
It should just be a matter of passing your output directory to
`realpath` somewhere in your script.
cheers
next prev parent reply other threads:[~2019-11-28 4:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:33 kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set Cristian Marussi
2019-11-27 3:54 ` Michael Ellerman
2019-11-27 10:54 ` Cristian Marussi
2019-11-27 16:04 ` shuah
2019-11-27 16:23 ` Cristian Marussi
2019-11-27 16:42 ` shuah
2019-11-27 16:53 ` Cristian Marussi
2019-11-27 17:32 ` shuah
2019-11-27 17:57 ` Tim.Bird
2019-11-27 18:16 ` shuah
2019-11-27 18:48 ` Cristian Marussi
2019-11-28 4:17 ` Michael Ellerman [this message]
2019-11-28 4:20 ` Michael Ellerman
2019-11-28 23:33 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kyo1vov.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Tim.Bird@sony.com \
--cc=cristian.marussi@arm.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.