From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, mikhail_durnev@mentor.com, joe@perches.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node_count()'
Date: 19 Oct 2021 08:13:35 +0900 [thread overview]
Message-ID: <875ytusz8g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr>
Hi
> If we return before the end of the 'for_each_child_of_node()' iterator, the
> reference taken on 'np' must be released.
>
> Add the missing 'of_node_put()' call.
>
> Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, broonie@kernel.org,
mikhail_durnev@mentor.com, joe@perches.com
Subject: Re: [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node_count()'
Date: 19 Oct 2021 08:13:35 +0900 [thread overview]
Message-ID: <875ytusz8g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <4c0e893cbfa21dc76c1ede0b6f4f8cff42209299.1634586167.git.christophe.jaillet@wanadoo.fr>
Hi
> If we return before the end of the 'for_each_child_of_node()' iterator, the
> reference taken on 'np' must be released.
>
> Add the missing 'of_node_put()' call.
>
> Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2021-10-18 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:44 [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node_count()' Christophe JAILLET
2021-10-18 19:44 ` Christophe JAILLET
2021-10-18 23:13 ` Kuninori Morimoto [this message]
2021-10-18 23:13 ` Kuninori Morimoto
2021-11-02 18:30 ` Mark Brown
2021-11-02 18:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ytusz8g.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail_durnev@mentor.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.