From: Simon South <simon@simonsouth.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
bbrezillon@kernel.org, linux-rockchip@lists.infradead.org,
thierry.reding@gmail.com, tpiepho@gmail.com,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing
Date: Tue, 22 Dec 2020 11:26:59 -0500 [thread overview]
Message-ID: <875z4trelo.fsf@simonsouth.net> (raw)
In-Reply-To: <20201221085047.nyl7hacd4imp37qi@pengutronix.de> ("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Mon, 21 Dec 2020 09:50:47 +0100")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> I wonder if the commit log should be more detailed about this, after
> reading it I thought the effect of the bug would be that the PWM stops
> even though it should oscillate.
Your understanding is correct; this was the result of confusion on my
part. I'll write a new commit message.
>> Also refactor the code slightly to eliminate goto targets as the
>> error handlers no longer share any recovery steps.
>
> This however makes it hard to review the patch. Maybe this refactoring
> can be split out?
I'll give this another shot, too.
--
Simon South
simon@simonsouth.net
WARNING: multiple messages have this Message-ID (diff)
From: Simon South <simon@simonsouth.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
bbrezillon@kernel.org, linux-rockchip@lists.infradead.org,
thierry.reding@gmail.com, tpiepho@gmail.com,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing
Date: Tue, 22 Dec 2020 11:26:59 -0500 [thread overview]
Message-ID: <875z4trelo.fsf@simonsouth.net> (raw)
In-Reply-To: <20201221085047.nyl7hacd4imp37qi@pengutronix.de> ("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Mon, 21 Dec 2020 09:50:47 +0100")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> I wonder if the commit log should be more detailed about this, after
> reading it I thought the effect of the bug would be that the PWM stops
> even though it should oscillate.
Your understanding is correct; this was the result of confusion on my
part. I'll write a new commit message.
>> Also refactor the code slightly to eliminate goto targets as the
>> error handlers no longer share any recovery steps.
>
> This however makes it hard to review the patch. Maybe this refactoring
> can be split out?
I'll give this another shot, too.
--
Simon South
simon@simonsouth.net
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Simon South <simon@simonsouth.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
bbrezillon@kernel.org, linux-rockchip@lists.infradead.org,
thierry.reding@gmail.com, tpiepho@gmail.com,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing
Date: Tue, 22 Dec 2020 11:26:59 -0500 [thread overview]
Message-ID: <875z4trelo.fsf@simonsouth.net> (raw)
In-Reply-To: <20201221085047.nyl7hacd4imp37qi@pengutronix.de> ("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Mon, 21 Dec 2020 09:50:47 +0100")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> I wonder if the commit log should be more detailed about this, after
> reading it I thought the effect of the bug would be that the PWM stops
> even though it should oscillate.
Your understanding is correct; this was the result of confusion on my
part. I'll write a new commit message.
>> Also refactor the code slightly to eliminate goto targets as the
>> error handlers no longer share any recovery steps.
>
> This however makes it hard to review the patch. Maybe this refactoring
> can be split out?
I'll give this another shot, too.
--
Simon South
simon@simonsouth.net
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-22 16:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 20:44 [PATCH v2 0/3] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-19 20:44 ` Simon South
2020-12-19 20:44 ` Simon South
2020-12-19 20:44 ` [PATCH v2 1/3] pwm: rockchip: Enable APB clock during register access while probing Simon South
2020-12-19 20:44 ` Simon South
2020-12-19 20:44 ` Simon South
2020-12-21 8:22 ` Uwe Kleine-König
2020-12-21 8:22 ` Uwe Kleine-König
2020-12-21 8:22 ` Uwe Kleine-König
2020-12-19 20:44 ` [PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-19 20:44 ` Simon South
2020-12-19 20:44 ` Simon South
2020-12-21 8:50 ` Uwe Kleine-König
2020-12-21 8:50 ` Uwe Kleine-König
2020-12-21 8:50 ` Uwe Kleine-König
2020-12-22 16:26 ` Simon South [this message]
2020-12-22 16:26 ` Simon South
2020-12-22 16:26 ` Simon South
2020-12-19 20:44 ` [PATCH v2 3/3] pwm: rockchip: Do not start PWMs not already running Simon South
2020-12-19 20:44 ` Simon South
2020-12-19 20:44 ` Simon South
2020-12-21 9:05 ` Uwe Kleine-König
2020-12-21 9:05 ` Uwe Kleine-König
2020-12-21 9:05 ` Uwe Kleine-König
2020-12-22 16:32 ` Simon South
2020-12-22 16:32 ` Simon South
2020-12-22 16:32 ` Simon South
2020-12-22 17:23 ` Robin Murphy
2020-12-22 17:23 ` Robin Murphy
2020-12-22 17:23 ` Robin Murphy
2020-12-22 17:43 ` Simon South
2020-12-22 17:43 ` Simon South
2020-12-22 17:43 ` Simon South
2020-12-21 9:16 ` [PATCH v2 0/3] pwm: rockchip: Eliminate potential race condition when probing Uwe Kleine-König
2020-12-21 9:16 ` Uwe Kleine-König
2020-12-21 9:16 ` Uwe Kleine-König
2020-12-22 16:34 ` Simon South
2020-12-22 16:34 ` Simon South
2020-12-22 16:34 ` Simon South
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z4trelo.fsf@simonsouth.net \
--to=simon@simonsouth.net \
--cc=bbrezillon@kernel.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=thierry.reding@gmail.com \
--cc=tpiepho@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.