From: Markus Armbruster <armbru@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/4] vl.c: make find_default_machine() local
Date: Mon, 08 Apr 2019 10:59:48 +0200 [thread overview]
Message-ID: <875zroub23.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190405064121.23662-2-richardw.yang@linux.intel.com> (Wei Yang's message of "Fri, 5 Apr 2019 14:41:18 +0800")
Wei Yang <richardw.yang@linux.intel.com> writes:
> Function find_default_machine() is introduced by commit 2c8cffa599b7
> "vl: make find_default_machine externally visible", and it was used
> outside of vl.c until commit a904410af5f1 "pc_sysfw: remove the rom_only
> property".
>
> Commit a904410af5f1 "pc_sysfw: remove the rom_only property" removed the
> only user of find_default_machine() outside vl.c, but neglected to make
> it static. Do that now.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/4] vl.c: make find_default_machine() local
Date: Mon, 08 Apr 2019 10:59:48 +0200 [thread overview]
Message-ID: <875zroub23.fsf@dusky.pond.sub.org> (raw)
Message-ID: <20190408085948.d7CaBhWntbkbCqYz0-nQayjxLgW7ZbQSwbpT5e8SJi8@z> (raw)
In-Reply-To: <20190405064121.23662-2-richardw.yang@linux.intel.com> (Wei Yang's message of "Fri, 5 Apr 2019 14:41:18 +0800")
Wei Yang <richardw.yang@linux.intel.com> writes:
> Function find_default_machine() is introduced by commit 2c8cffa599b7
> "vl: make find_default_machine externally visible", and it was used
> outside of vl.c until commit a904410af5f1 "pc_sysfw: remove the rom_only
> property".
>
> Commit a904410af5f1 "pc_sysfw: remove the rom_only property" removed the
> only user of find_default_machine() outside vl.c, but neglected to make
> it static. Do that now.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2019-04-08 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 6:41 [Qemu-devel] [PATCH v2 0/4] cleanup select_machine Wei Yang
2019-04-05 6:41 ` Wei Yang
2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 1/4] vl.c: make find_default_machine() local Wei Yang
2019-04-05 6:41 ` Wei Yang
2019-04-08 8:59 ` Markus Armbruster [this message]
2019-04-08 8:59 ` Markus Armbruster
2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 2/4] vl.c: allocate TYPE_MACHINE list once during bootup Wei Yang
2019-04-05 6:41 ` Wei Yang
2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 3/4] vl: Clean up after previous commit Wei Yang
2019-04-05 6:41 ` Wei Yang
2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 4/4] vl: Simplify machine_parse() Wei Yang
2019-04-05 6:41 ` Wei Yang
2019-04-12 20:42 ` [Qemu-devel] [PATCH v2 0/4] cleanup select_machine Eduardo Habkost
2019-04-12 20:42 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zroub23.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.