From: Thomas Gleixner <tglx@linutronix.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Vinod Koul <vkoul@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
Date: Wed, 08 Dec 2021 18:53:07 +0100 [thread overview]
Message-ID: <877dcf0yrg.ffs@tglx> (raw)
In-Reply-To: <20211208155314.GX6385@nvidia.com>
On Wed, Dec 08 2021 at 11:53, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:
>> static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
>> {
>> - struct msi_desc *msidesc = first_pci_msi_entry(dev);
>> -
>> - if (msidesc->pci.msi_attrib.is_msix)
>> + if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
>> xen_pci_frontend_disable_msix(dev);
>> else
>> xen_pci_frontend_disable_msi(dev);
>
> Same remark as for power, we have a pci_dev, so can it be
> dev->msix_enabled?
Yes, let me rework that.
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Nishanth Menon <nm@ti.com>, Mark Rutland <mark.rutland@arm.com>,
Stuart Yoder <stuyoder@gmail.com>,
linux-pci@vger.kernel.org, Will Deacon <will@kernel.org>,
Ashok Raj <ashok.raj@intel.com>, Marc Zygnier <maz@kernel.org>,
Sinan Kaya <okaya@kernel.org>,
iommu@lists.linux-foundation.org,
Bjorn Helgaas <helgaas@kernel.org>,
Megha Dey <megha.dey@intel.com>,
xen-devel@lists.xenproject.org, Kevin Tian <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cedric Le Goater <clg@kaod.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Juergen Gross <jgross@suse.com>, Tero Kristo <kristo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
Date: Wed, 08 Dec 2021 18:53:07 +0100 [thread overview]
Message-ID: <877dcf0yrg.ffs@tglx> (raw)
In-Reply-To: <20211208155314.GX6385@nvidia.com>
On Wed, Dec 08 2021 at 11:53, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:
>> static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
>> {
>> - struct msi_desc *msidesc = first_pci_msi_entry(dev);
>> -
>> - if (msidesc->pci.msi_attrib.is_msix)
>> + if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
>> xen_pci_frontend_disable_msix(dev);
>> else
>> xen_pci_frontend_disable_msi(dev);
>
> Same remark as for power, we have a pci_dev, so can it be
> dev->msix_enabled?
Yes, let me rework that.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Vinod Koul <vkoul@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
Date: Wed, 08 Dec 2021 18:53:07 +0100 [thread overview]
Message-ID: <877dcf0yrg.ffs@tglx> (raw)
In-Reply-To: <20211208155314.GX6385@nvidia.com>
On Wed, Dec 08 2021 at 11:53, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:
>> static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
>> {
>> - struct msi_desc *msidesc = first_pci_msi_entry(dev);
>> -
>> - if (msidesc->pci.msi_attrib.is_msix)
>> + if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
>> xen_pci_frontend_disable_msix(dev);
>> else
>> xen_pci_frontend_disable_msi(dev);
>
> Same remark as for power, we have a pci_dev, so can it be
> dev->msix_enabled?
Yes, let me rework that.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-08 17:53 UTC|newest]
Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 22:38 [patch V2 00/36] genirq/msi, PCI/MSI: Spring cleaning - Part 2 Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:38 ` [patch V2 01/36] device: Move MSI related data into a struct Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:38 ` [patch V2 02/36] device: Add device::msi_data pointer and struct msi_device_data Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:38 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 03/36] PCI/MSI: Allocate MSI device data on first use Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 21:03 ` Bjorn Helgaas
2021-12-07 21:03 ` Bjorn Helgaas
2021-12-07 21:03 ` Bjorn Helgaas
2021-12-06 22:39 ` [patch V2 04/36] platform-msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 05/36] bus: fsl-mc-msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 06/36] soc: ti: ti_sci_inta_msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 07/36] genirq/msi: Provide msi_device_populate/destroy_sysfs() Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 08/36] PCI/MSI: Let the irq code handle sysfs groups Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-06 22:39 ` [patch V2 09/36] platform-msi: Let the core " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 10/36] genirq/msi: Remove the original sysfs interfaces Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 11/36] platform-msi: Rename functions and clarify comments Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 12/36] platform-msi: Store platform private data pointer in msi_device_data Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 13/36] genirq/msi: Consolidate MSI descriptor data Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 14/36] platform-msi: Use msi_desc::msi_index Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 15/36] bus: fsl-mc-msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 16/36] soc: ti: ti_sci_inta_msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 17/36] PCI/MSI: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-07 21:04 ` Bjorn Helgaas
2021-12-06 22:39 ` [patch V2 18/36] genirq/msi: Add msi_device_data::properties Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 9:04 ` Cédric Le Goater
2021-12-07 9:04 ` Cédric Le Goater
2021-12-07 9:04 ` Cédric Le Goater
2021-12-07 12:47 ` Thomas Gleixner
2021-12-07 12:47 ` Thomas Gleixner
2021-12-07 12:47 ` Thomas Gleixner
2021-12-07 12:53 ` Thomas Gleixner
2021-12-07 12:53 ` Thomas Gleixner
2021-12-07 12:53 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 19/36] PCI/MSI: Store properties in device::msi::data Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-08 15:58 ` Jason Gunthorpe
2021-12-08 15:58 ` Jason Gunthorpe
2021-12-08 15:58 ` Jason Gunthorpe via iommu
2021-12-09 17:53 ` Thomas Gleixner
2021-12-09 17:53 ` Thomas Gleixner
2021-12-09 17:53 ` Thomas Gleixner
2021-12-09 21:02 ` Thomas Gleixner
2021-12-09 21:02 ` Thomas Gleixner
2021-12-09 21:02 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 20/36] x86/pci/XEN: Use device MSI properties Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-08 15:53 ` Jason Gunthorpe
2021-12-08 15:53 ` Jason Gunthorpe
2021-12-08 15:53 ` Jason Gunthorpe via iommu
2021-12-08 17:53 ` Thomas Gleixner [this message]
2021-12-08 17:53 ` Thomas Gleixner
2021-12-08 17:53 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 21/36] x86/apic/msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-08 15:45 ` Jason Gunthorpe
2021-12-08 15:45 ` Jason Gunthorpe
2021-12-08 15:45 ` Jason Gunthorpe via iommu
2021-12-06 22:39 ` [patch V2 22/36] genirq/msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-08 15:54 ` Jason Gunthorpe
2021-12-08 15:54 ` Jason Gunthorpe
2021-12-08 15:54 ` Jason Gunthorpe via iommu
2021-12-06 22:39 ` [patch V2 24/36] powerpc/pseries/msi: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-08 15:51 ` Jason Gunthorpe
2021-12-08 15:51 ` Jason Gunthorpe
2021-12-08 15:51 ` Jason Gunthorpe via iommu
2021-12-06 22:39 ` [patch V2 25/36] PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUS Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-06 22:39 ` [patch V2 26/36] powerpc/pseries/msi: Let core code check for contiguous entries Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-06 22:39 ` [patch V2 27/36] genirq/msi: Provide interface to retrieve Linux interrupt number Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:51 ` Greg Kroah-Hartman
2021-12-07 7:51 ` Greg Kroah-Hartman
2021-12-07 7:51 ` Greg Kroah-Hartman
2021-12-06 22:39 ` [patch V2 28/36] PCI/MSI: Use __msi_get_virq() in pci_get_vector() Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 7:52 ` Greg Kroah-Hartman
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-07 21:05 ` Bjorn Helgaas
2021-12-06 22:39 ` [patch V2 29/36] PCI/MSI: Simplify pci_irq_get_affinity() Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-07 17:42 ` Cédric Le Goater
2021-12-07 17:42 ` Cédric Le Goater
2021-12-07 17:42 ` Cédric Le Goater
2021-12-07 21:19 ` Thomas Gleixner
2021-12-07 21:19 ` Thomas Gleixner
2021-12-07 21:19 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 30/36] dmaengine: mv_xor_v2: Get rid of msi_desc abuse Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 31/36] perf/smmuv3: Use msi_get_virq() Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 32/36] iommu/arm-smmu-v3: " Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 33/36] mailbox: bcm-flexrm-mailbox: Rework MSI interrupt handling Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 34/36] bus: fsl-mc: fsl-mc-allocator: Rework MSI handling Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 35/36] soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq() Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` [patch V2 36/36] dmaengine: qcom_hidma: Cleanup MSI handling Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
2021-12-06 22:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dcf0yrg.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=clg@kaod.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jgg@nvidia.com \
--cc=jgross@suse.com \
--cc=kevin.tian@intel.com \
--cc=kristo@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=megha.dey@intel.com \
--cc=nm@ti.com \
--cc=okaya@kernel.org \
--cc=robin.murphy@arm.com \
--cc=ssantosh@kernel.org \
--cc=stuyoder@gmail.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.