From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Paul Durrant" <paul@xen.org>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands
Date: Mon, 05 Oct 2020 12:55:14 +0200 [thread overview]
Message-ID: <877ds5djsd.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <0c54aa06-372c-ab81-0974-34340adb7b55@redhat.com> (Paolo Bonzini's message of "Mon, 5 Oct 2020 10:46:02 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/10/20 10:01, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> Reduce the machine code pulled into qemu-storage-daemon.
>> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
>> Juan for PATCH 5. David already ACKed.
>>
>> Can do the pull request.
>>
>
> If it counts, :) for patch 1-4:
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Generally these patches to remove code from user-mode emulators
> fall into the "if it builds it's fine" bucket, since I assume
> we want the "misc" subschema to be as small as possible.
Moving stuff out of qapi/misc.json is good as long as the new home makes
sense. So, if it builds *and* the maintainers of the new home think it
makes sense to have it there, it's fine.
I don't think we should aim for eliminating every last bit of unused
generated code from every program. We should aim for a sensible split
into sub-modules. Unused generated code in a program can be a sign for
a less than sensible split.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Paul Durrant" <paul@xen.org>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands
Date: Mon, 05 Oct 2020 12:55:14 +0200 [thread overview]
Message-ID: <877ds5djsd.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <0c54aa06-372c-ab81-0974-34340adb7b55@redhat.com> (Paolo Bonzini's message of "Mon, 5 Oct 2020 10:46:02 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/10/20 10:01, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> Reduce the machine code pulled into qemu-storage-daemon.
>> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
>> Juan for PATCH 5. David already ACKed.
>>
>> Can do the pull request.
>>
>
> If it counts, :) for patch 1-4:
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Generally these patches to remove code from user-mode emulators
> fall into the "if it builds it's fine" bucket, since I assume
> we want the "misc" subschema to be as small as possible.
Moving stuff out of qapi/misc.json is good as long as the new home makes
sense. So, if it builds *and* the maintainers of the new home think it
makes sense to have it there, it's fine.
I don't think we should aim for eliminating every last bit of unused
generated code from every program. We should aim for a sensible split
into sub-modules. Unused generated code in a program can be a sign for
a less than sensible split.
next prev parent reply other threads:[~2020-10-05 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 13:39 [PATCH 0/5] qapi: Restrict machine (and migration) specific commands Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 13:39 ` [PATCH 1/5] qapi: Restrict 'inject-nmi' command to machine code Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 13:39 ` [PATCH 2/5] qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 13:39 ` [PATCH 3/5] qapi: Restrict '(p)memsave' command to machine code Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 13:39 ` [PATCH 4/5] qapi: Restrict 'query-kvm' " Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 13:39 ` [PATCH 5/5] qapi: Restrict Xen migration commands to migration.json Philippe Mathieu-Daudé
2020-10-02 13:39 ` Philippe Mathieu-Daudé
2020-10-02 17:04 ` Dr. David Alan Gilbert
2020-10-02 17:04 ` Dr. David Alan Gilbert
2020-10-05 8:01 ` [PATCH 0/5] qapi: Restrict machine (and migration) specific commands Markus Armbruster
2020-10-05 8:01 ` Markus Armbruster
2020-10-05 8:46 ` Paolo Bonzini
2020-10-05 8:46 ` Paolo Bonzini
2020-10-05 10:55 ` Markus Armbruster [this message]
2020-10-05 10:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ds5djsd.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.