From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kan Yan <kyan@google.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
ath10k@lists.infradead.org, John Crispin <john@phrozen.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Felix Fietkau <nbd@nbd.name>,
Rajkumar Manoharan <rmanohar@codeaurora.org>,
Kevin Hayes <kevinhayes@google.com>
Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue
Date: Wed, 23 Oct 2019 23:09:08 +0200 [thread overview]
Message-ID: <877e4vmaob.fsf@toke.dk> (raw)
In-Reply-To: <CA+iem5vU-K-+sSSeNugy5ZZF_nH5vuaXW3J_WC=1WWhdkHOgjw@mail.gmail.com>
Kan Yan <kyan@google.com> writes:
>>
>> Aha! Turns out I was doing the sta lookup completely wrong in
>> ieee80211_report_used_skb(); so anything frames that were dropped and
>> went through there would not get its airtime subtracted correctly. Will
>> send a v6 with a fix :)
>
> Awesome, thanks! That looks very promising. The symptom I see with
> previous patch is the interface's pending airtime count looks fine, but the
> station's airtime get wrong, either due to airtime is credited to the wrong
> station or wrong AC.
Right, if the interface count is fine that means it's not a missing call
to the subtraction. So hopefully it will be fixed with v6 :)
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kan Yan <kyan@google.com>
Cc: Rajkumar Manoharan <rmanohar@codeaurora.org>,
Kevin Hayes <kevinhayes@google.com>,
Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
John Crispin <john@phrozen.org>,
Johannes Berg <johannes@sipsolutions.net>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue
Date: Wed, 23 Oct 2019 23:09:08 +0200 [thread overview]
Message-ID: <877e4vmaob.fsf@toke.dk> (raw)
In-Reply-To: <CA+iem5vU-K-+sSSeNugy5ZZF_nH5vuaXW3J_WC=1WWhdkHOgjw@mail.gmail.com>
Kan Yan <kyan@google.com> writes:
>>
>> Aha! Turns out I was doing the sta lookup completely wrong in
>> ieee80211_report_used_skb(); so anything frames that were dropped and
>> went through there would not get its airtime subtracted correctly. Will
>> send a v6 with a fix :)
>
> Awesome, thanks! That looks very promising. The symptom I see with
> previous patch is the interface's pending airtime count looks fine, but the
> station's airtime get wrong, either due to airtime is credited to the wrong
> station or wrong AC.
Right, if the interface count is fine that means it's not a missing call
to the subtraction. So hopefully it will be fixed with v6 :)
-Toke
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-10-23 21:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 11:37 [PATCH v4 0/4] Add Airtime Queue Limits (AQL) to mac80211 Toke Høiland-Jørgensen
2019-10-19 11:37 ` Toke Høiland-Jørgensen
2019-10-19 11:37 ` [PATCH v4 1/4] mac80211: Shrink the size of ack_frame_id to make room for tx_time_est Toke Høiland-Jørgensen
2019-10-19 11:37 ` Toke Høiland-Jørgensen
2019-10-19 11:37 ` [PATCH v4 2/4] mac80211: Import airtime calculation code from mt76 Toke Høiland-Jørgensen
2019-10-19 11:37 ` Toke Høiland-Jørgensen
2019-10-21 22:14 ` kbuild test robot
2019-10-21 22:14 ` kbuild test robot
2019-10-21 22:14 ` kbuild test robot
2019-10-21 22:14 ` [RFC PATCH] mac80211: ieee80211_calc_rx_airtime() can be static kbuild test robot
2019-10-21 22:14 ` kbuild test robot
2019-10-21 22:14 ` kbuild test robot
2019-10-19 11:37 ` [PATCH v4 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) Toke Høiland-Jørgensen
2019-10-19 11:37 ` Toke Høiland-Jørgensen
2019-10-19 11:37 ` [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue Toke Høiland-Jørgensen
2019-10-19 11:37 ` Toke Høiland-Jørgensen
2019-10-22 6:20 ` Kan Yan
2019-10-22 6:20 ` Kan Yan
2019-10-22 7:14 ` Toke Høiland-Jørgensen
2019-10-22 7:14 ` Toke Høiland-Jørgensen
2019-10-22 11:35 ` Toke Høiland-Jørgensen
2019-10-22 11:35 ` Toke Høiland-Jørgensen
2019-10-23 6:41 ` Kan Yan
2019-10-23 6:41 ` Kan Yan
2019-10-23 8:18 ` Toke Høiland-Jørgensen
2019-10-23 8:18 ` Toke Høiland-Jørgensen
2019-10-23 9:52 ` Toke Høiland-Jørgensen
2019-10-23 9:52 ` Toke Høiland-Jørgensen
2019-10-23 15:43 ` Kan Yan
2019-10-23 15:43 ` Kan Yan
[not found] ` <CA+iem5vU-K-+sSSeNugy5ZZF_nH5vuaXW3J_WC=1WWhdkHOgjw@mail.gmail.com>
2019-10-23 21:09 ` Toke Høiland-Jørgensen [this message]
2019-10-23 21:09 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e4vmaob.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=kevinhayes@google.com \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.