Re: [PATCH v6 2/4] drm/dp: add helpers for capture of frame CRCs

From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6 2/4] drm/dp: add helpers for capture of frame CRCs
Date: Tue, 07 Mar 2017 15:26:36 -0300	[thread overview]
Message-ID: <877f413pur.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <20170303133936.14964-3-tomeu.vizoso@collabora.com> (Tomeu Vizoso's message of "Fri, 3 Mar 2017 14:39:34 +0100")

Tomeu Vizoso <tomeu.vizoso@collabora.com> writes:

> +
> +/**
> + * drm_dp_start_crc() - start capture of frame CRCs
> + * @aux: DisplayPort AUX channel
> + *
> + * Returns 0 on success or a negative error code on failure.
> + */
> +int drm_dp_start_crc(struct drm_dp_aux *aux, struct drm_crtc *crtc)
> +{
> +	u8 buf;
> +	int ret;
> +
> +	ret = drm_dp_dpcd_readb(aux, DP_TEST_SINK, &buf);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = drm_dp_dpcd_writeb(aux, DP_TEST_SINK, buf | DP_TEST_SINK_START);
> +	if (ret < 0)
> +		return ret;
> +
> +	aux->crc_count = 0;
> +	aux->crtc = crtc;
> +	schedule_work(&aux->crc_work);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL(drm_dp_start_crc);
> +

Hi Tomeu,

This triggers a new warning when building documentation:

./drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description found
for parameter 'crtc'
./drivers/gpu/drm/drm_dp_helper.c:1166: warning: No description found
for parameter 'crtc'

-- 
Gabriel Krisman Bertazi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel