From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Sean Paul" <seanpaul@chromium.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
intel-gfx-trybot@lists.freedesktop.org,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Mark Yao" <mark.yao@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
"David Airlie" <airlied@linux.ie>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API
Date: Mon, 6 Mar 2017 17:58:14 +0000 [thread overview]
Message-ID: <CACvgo50hmYjTe=jvet5miv3UTk8eM5XF8qatG3Uq_LTdsO5GYg@mail.gmail.com> (raw)
In-Reply-To: <20170303133936.14964-5-tomeu.vizoso@collabora.com>
Hi Tomeu,
Pardon for dropping in late.
On 3 March 2017 at 13:39, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Implement the .set_crc_source() callback and call the DP helpers
> accordingly to start and stop CRC capture.
>
> This is only done if this CRTC is currently using the eDP connector.
>
> v3: Remove superfluous check on rockchip_crtc_state->output_type
>
> v6: Remove superfluous variable
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
I think this won't fly (build).
Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is
the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps
adding a simple wrapper/stubs will be the easier option here ?
-Emil
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
intel-gfx-trybot@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API
Date: Mon, 6 Mar 2017 17:58:14 +0000 [thread overview]
Message-ID: <CACvgo50hmYjTe=jvet5miv3UTk8eM5XF8qatG3Uq_LTdsO5GYg@mail.gmail.com> (raw)
In-Reply-To: <20170303133936.14964-5-tomeu.vizoso@collabora.com>
Hi Tomeu,
Pardon for dropping in late.
On 3 March 2017 at 13:39, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Implement the .set_crc_source() callback and call the DP helpers
> accordingly to start and stop CRC capture.
>
> This is only done if this CRTC is currently using the eDP connector.
>
> v3: Remove superfluous check on rockchip_crtc_state->output_type
>
> v6: Remove superfluous variable
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
I think this won't fly (build).
Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is
the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps
adding a simple wrapper/stubs will be the easier option here ?
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: emil.l.velikov@gmail.com (Emil Velikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API
Date: Mon, 6 Mar 2017 17:58:14 +0000 [thread overview]
Message-ID: <CACvgo50hmYjTe=jvet5miv3UTk8eM5XF8qatG3Uq_LTdsO5GYg@mail.gmail.com> (raw)
In-Reply-To: <20170303133936.14964-5-tomeu.vizoso@collabora.com>
Hi Tomeu,
Pardon for dropping in late.
On 3 March 2017 at 13:39, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Implement the .set_crc_source() callback and call the DP helpers
> accordingly to start and stop CRC capture.
>
> This is only done if this CRTC is currently using the eDP connector.
>
> v3: Remove superfluous check on rockchip_crtc_state->output_type
>
> v6: Remove superfluous variable
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
I think this won't fly (build).
Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is
the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps
adding a simple wrapper/stubs will be the easier option here ?
-Emil
next prev parent reply other threads:[~2017-03-06 17:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 13:39 [PATCH v6 0/4] drm/dp: Implement CRC debugfs API Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-03 13:39 ` [PATCH v6 1/4] drm/dp: add crtc backpointer to drm_dp_aux Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-03 13:39 ` [PATCH v6 2/4] drm/dp: add helpers for capture of frame CRCs Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-07 18:26 ` Gabriel Krisman Bertazi
2017-03-07 20:35 ` [PATCH] drm/dp: Add missing description to parameter Tomeu Vizoso
2017-03-07 20:35 ` Tomeu Vizoso
2017-03-07 22:03 ` Sean Paul
2017-03-07 22:03 ` Sean Paul
2017-03-08 8:39 ` 0day 'make htmldocs' testing (was: Re: [PATCH] drm/dp: Add missing description to parameter) Jani Nikula
2017-03-08 8:41 ` Jani Nikula
2017-03-08 9:20 ` [kbuild-all] " Philip Li
2017-03-08 9:24 ` Fengguang Wu
2017-03-03 13:39 ` [PATCH v6 3/4] drm/bridge: analogix_dp: add helpers for capture of frame CRCs Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-03 13:39 ` [PATCH v6 4/4] drm/rockchip: Implement CRC debugfs API Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-03 13:39 ` Tomeu Vizoso
2017-03-06 0:55 ` Mark yao
2017-03-06 0:55 ` Mark yao
2017-03-06 0:55 ` Mark yao
2017-03-06 17:58 ` Emil Velikov [this message]
2017-03-06 17:58 ` Emil Velikov
2017-03-06 17:58 ` Emil Velikov
2017-03-06 17:19 ` [PATCH v6 0/4] drm/dp: " Sean Paul
2017-03-06 17:19 ` Sean Paul
2017-03-06 17:19 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo50hmYjTe=jvet5miv3UTk8eM5XF8qatG3Uq_LTdsO5GYg@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=intel-gfx-trybot@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.