All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi.
Date: Mon, 17 Aug 2015 10:56:23 -0700	[thread overview]
Message-ID: <877fotx0hk.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <55CEC3D8.7060103@wwwdotorg.org>

r<#secure method=pgpmime mode=sign>
Stephen Warren <swarren@wwwdotorg.org> writes:

> On 08/12/2015 06:56 PM, Eric Anholt wrote:
>> This is the start of a full VC4 driver.  Right now this just supports
>> configuring the display using a pre-existing video mode (because
>> changing the pixel clock isn't available yet, and doesn't work when it
>> is).  However, this is enough for fbcon and bringing up X using
>> xf86-video-modesetting.
>
>> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
>
>> +config DRM_VC4
>> +	tristate "Broadcom VC4 Graphics"
>
>> +	help
>> +	  Choose this option if you have a system that has a Broadcom
>> +	  VC4 GPU, such as the Raspberry Pi or other BCM2708/BCM2835.
>> +
>> +	  This driver requires that "avoid_warnings=2" be present in
>> +	  the config.txt for the firmware, to keep it from smashing
>> +	  our display setup.
>
> The need for "avoid_warnings=2" seems like it will trip people up. I
> don't think it's in any config.txt I've seen. Can you expand more on that?

The warnings thing is the firmware watching for undervoltage and then it
calls into dispmanx to overlay a little rainbow box on the screen.  This
of course interferes with our display setup.

I think we'll be able to wire up notifications to Linux for
undervoltage, at which point we can do something useful with that
information, ourselves.

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: devicetree@vger.kernel.org, Lee Jones <lee@kernel.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi.
Date: Mon, 17 Aug 2015 10:56:23 -0700	[thread overview]
Message-ID: <877fotx0hk.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <55CEC3D8.7060103@wwwdotorg.org>

r<#secure method=pgpmime mode=sign>
Stephen Warren <swarren@wwwdotorg.org> writes:

> On 08/12/2015 06:56 PM, Eric Anholt wrote:
>> This is the start of a full VC4 driver.  Right now this just supports
>> configuring the display using a pre-existing video mode (because
>> changing the pixel clock isn't available yet, and doesn't work when it
>> is).  However, this is enough for fbcon and bringing up X using
>> xf86-video-modesetting.
>
>> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
>
>> +config DRM_VC4
>> +	tristate "Broadcom VC4 Graphics"
>
>> +	help
>> +	  Choose this option if you have a system that has a Broadcom
>> +	  VC4 GPU, such as the Raspberry Pi or other BCM2708/BCM2835.
>> +
>> +	  This driver requires that "avoid_warnings=2" be present in
>> +	  the config.txt for the firmware, to keep it from smashing
>> +	  our display setup.
>
> The need for "avoid_warnings=2" seems like it will trip people up. I
> don't think it's in any config.txt I've seen. Can you expand more on that?

The warnings thing is the firmware watching for undervoltage and then it
calls into dispmanx to overlay a little rainbow box on the screen.  This
of course interferes with our display setup.

I think we'll be able to wire up notifications to Linux for
undervoltage, at which point we can do something useful with that
information, ourselves.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi.
Date: Mon, 17 Aug 2015 10:56:23 -0700	[thread overview]
Message-ID: <877fotx0hk.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <55CEC3D8.7060103@wwwdotorg.org>

r<#secure method=pgpmime mode=sign>
Stephen Warren <swarren@wwwdotorg.org> writes:

> On 08/12/2015 06:56 PM, Eric Anholt wrote:
>> This is the start of a full VC4 driver.  Right now this just supports
>> configuring the display using a pre-existing video mode (because
>> changing the pixel clock isn't available yet, and doesn't work when it
>> is).  However, this is enough for fbcon and bringing up X using
>> xf86-video-modesetting.
>
>> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
>
>> +config DRM_VC4
>> +	tristate "Broadcom VC4 Graphics"
>
>> +	help
>> +	  Choose this option if you have a system that has a Broadcom
>> +	  VC4 GPU, such as the Raspberry Pi or other BCM2708/BCM2835.
>> +
>> +	  This driver requires that "avoid_warnings=2" be present in
>> +	  the config.txt for the firmware, to keep it from smashing
>> +	  our display setup.
>
> The need for "avoid_warnings=2" seems like it will trip people up. I
> don't think it's in any config.txt I've seen. Can you expand more on that?

The warnings thing is the firmware watching for undervoltage and then it
calls into dispmanx to overlay a little rainbow box on the screen.  This
of course interferes with our display setup.

I think we'll be able to wire up notifications to Linux for
undervoltage, at which point we can do something useful with that
information, ourselves.

  reply	other threads:[~2015-08-17 17:56 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13  0:56 Raspberry Pi KMS-only driver Eric Anholt
2015-08-13  0:56 ` Eric Anholt
2015-08-13  0:56 ` Eric Anholt
2015-08-13  0:56 ` [PATCH 1/7] drm/vc4: Add devicetree bindings for VC4 Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-15  4:38   ` Stephen Warren
2015-08-15  4:38     ` Stephen Warren
2015-08-17 18:30     ` Eric Anholt
2015-08-17 18:30       ` Eric Anholt
2015-08-17 18:30       ` Eric Anholt
2015-08-24 13:47       ` Rob Herring
2015-08-24 13:47         ` Rob Herring
2015-08-24 13:47         ` Rob Herring
2015-08-25 20:42         ` Rob Clark
2015-08-25 20:42           ` Rob Clark
2015-08-25 20:42           ` Rob Clark
2015-08-25 23:22           ` Rob Herring
2015-08-25 23:22             ` Rob Herring
2015-08-25 23:22             ` Rob Herring
2015-08-26 11:52           ` Daniel Vetter
2015-08-26 11:52             ` Daniel Vetter
2015-08-26 11:52             ` Daniel Vetter
2015-08-26 12:09             ` Thierry Reding
2015-08-26 12:09               ` Thierry Reding
2015-08-26 12:09               ` Thierry Reding
2015-08-26 14:30               ` Rob Herring
2015-08-26 14:30                 ` Rob Herring
2015-08-26 14:30                 ` Rob Herring
2015-08-26 20:59                 ` Dave Airlie
2015-08-26 20:59                   ` Dave Airlie
2015-08-26 20:59                   ` Dave Airlie
2015-08-27  0:35                   ` Rob Herring
2015-08-27  0:35                     ` Rob Herring
2015-08-27  0:35                     ` Rob Herring
2015-08-26 11:51     ` Thierry Reding
2015-08-26 11:51       ` Thierry Reding
2015-08-26 11:51       ` Thierry Reding
2015-08-24 13:56   ` Rob Herring
2015-08-24 13:56     ` Rob Herring
2015-08-24 13:56     ` Rob Herring
2015-08-13  0:56 ` [PATCH 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-15  4:39   ` Stephen Warren
2015-08-15  4:39     ` Stephen Warren
2015-08-15  4:39     ` Stephen Warren
2015-08-17 18:47     ` Eric Anholt
2015-08-17 18:47       ` Eric Anholt
2015-08-17 18:47       ` Eric Anholt
2015-08-13  0:56 ` [PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  7:51   ` Daniel Vetter
2015-08-13  7:51     ` Daniel Vetter
2015-08-13  7:51     ` Daniel Vetter
2015-08-13 20:44     ` Eric Anholt
2015-08-13 20:44       ` Eric Anholt
2015-08-13 20:44       ` Eric Anholt
2015-08-13 21:17       ` Daniel Vetter
2015-08-13 21:17         ` Daniel Vetter
2015-08-13 21:17         ` Daniel Vetter
2015-08-18 20:56         ` Eric Anholt
2015-08-18 20:56           ` Eric Anholt
2015-08-18 20:56           ` Eric Anholt
2015-08-13 21:29       ` Russell King - ARM Linux
2015-08-13 21:29         ` Russell King - ARM Linux
2015-08-13 21:29         ` Russell King - ARM Linux
2015-08-13 23:03         ` Eric Anholt
2015-08-13 23:03           ` Eric Anholt
2015-08-13 23:03           ` Eric Anholt
2015-08-13 11:45   ` Emil Velikov
2015-08-13 11:45     ` Emil Velikov
2015-08-13 11:45     ` Emil Velikov
2015-08-15  4:45   ` Stephen Warren
2015-08-15  4:45     ` Stephen Warren
2015-08-15  4:45     ` Stephen Warren
2015-08-17 17:56     ` Eric Anholt [this message]
2015-08-17 17:56       ` Eric Anholt
2015-08-17 17:56       ` Eric Anholt
2015-08-13  0:56 ` [PATCH 4/7] drm/vc4: Use the fbdev_cma helpers Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56 ` [PATCH 5/7] drm/vc4: Allow vblank to be disabled Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56 ` [PATCH 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-15  4:51   ` Stephen Warren
2015-08-15  4:51     ` Stephen Warren
2015-08-15  4:51     ` Stephen Warren
2015-08-17 18:35     ` Eric Anholt
2015-08-17 18:35       ` Eric Anholt
2015-08-17 18:35       ` Eric Anholt
2015-08-13  0:56 ` [PATCH 7/7] ARM: bcm2835: Add VC4 " Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-13  0:56   ` Eric Anholt
2015-08-15  4:54   ` Stephen Warren
2015-08-15  4:54     ` Stephen Warren
2015-08-15  4:54     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fotx0hk.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.