From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Cooper <jason@lakedaemon.net>, Kees Cook <keescook@chromium.org>
Cc: "Roberts\, William C" <william.c.roberts@intel.com>,
Yann Droneaud <ydroneaud@opteya.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening\@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
"benh\@kernel.crashing.org" <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86\@kernel.org" <x86@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Nick Kralevich <nnk@google.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Daniel Cashman <dcashman@android.com>
Subject: Re: [kernel-hardening] Re: [PATCH v2 1/7] random: Simplify API for random address requests
Date: Tue, 02 Aug 2016 13:35:13 +1000 [thread overview]
Message-ID: <878twfonbi.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20160801231723.GG4541@io.lakedaemon.net>
Jason Cooper <jason@lakedaemon.net> writes:
> On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote:
>> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper <jason@lakedaemon.net> wrote:
>>
>> I have no new call sites in mind, but it seems safe to add a BUG_ON to
>> verify we don't gain callers that don't follow the correct
>> expectations. (Or maybe WARN and return start.)
>
> No, I think BUG_ON is appropriate. afaict, the only time this will be
> encountered is during the development process.
Unless it's not.
Why crash someone's system when you could just page align the value
you're given?
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Cooper <jason@lakedaemon.net>, Kees Cook <keescook@chromium.org>
Cc: "Roberts, William C" <william.c.roberts@intel.com>,
Yann Droneaud <ydroneaud@opteya.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Nick Kralevich <nnk@google.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Daniel Cashman <dcashman@android.com>
Subject: Re: [kernel-hardening] Re: [PATCH v2 1/7] random: Simplify API for random address requests
Date: Tue, 02 Aug 2016 13:35:13 +1000 [thread overview]
Message-ID: <878twfonbi.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20160801231723.GG4541@io.lakedaemon.net>
Jason Cooper <jason@lakedaemon.net> writes:
> On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote:
>> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper <jason@lakedaemon.net> wrote:
>>
>> I have no new call sites in mind, but it seems safe to add a BUG_ON to
>> verify we don't gain callers that don't follow the correct
>> expectations. (Or maybe WARN and return start.)
>
> No, I think BUG_ON is appropriate. afaict, the only time this will be
> encountered is during the development process.
Unless it's not.
Why crash someone's system when you could just page align the value
you're given?
cheers
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Cooper <jason@lakedaemon.net>, Kees Cook <keescook@chromium.org>
Cc: "Roberts, William C" <william.c.roberts@intel.com>,
Yann Droneaud <ydroneaud@opteya.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Nick Kralevich <nnk@google.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Daniel Cashman <dcashman@android.com>
Subject: Re: [kernel-hardening] Re: [PATCH v2 1/7] random: Simplify API for random address requests
Date: Tue, 02 Aug 2016 13:35:13 +1000 [thread overview]
Message-ID: <878twfonbi.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20160801231723.GG4541@io.lakedaemon.net>
Jason Cooper <jason@lakedaemon.net> writes:
> On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote:
>> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper <jason@lakedaemon.net> wrote:
>>
>> I have no new call sites in mind, but it seems safe to add a BUG_ON to
>> verify we don't gain callers that don't follow the correct
>> expectations. (Or maybe WARN and return start.)
>
> No, I think BUG_ON is appropriate. afaict, the only time this will be
> encountered is during the development process.
Unless it's not.
Why crash someone's system when you could just page align the value
you're given?
cheers
next prev parent reply other threads:[~2016-08-02 3:37 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 20:47 [PATCH 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 1/7] random: Simplify API for " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-29 8:59 ` Yann Droneaud
2016-07-29 8:59 ` [kernel-hardening] " Yann Droneaud
2016-07-29 8:59 ` Yann Droneaud
2016-07-29 18:20 ` Jason Cooper
2016-07-29 18:20 ` [kernel-hardening] " Jason Cooper
2016-07-29 18:20 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 2/7] x86: Use simpler " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 3/7] ARM: " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 4/7] arm64: " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-29 13:48 ` Will Deacon
2016-07-29 13:48 ` [kernel-hardening] " Will Deacon
2016-07-29 13:48 ` Will Deacon
2016-07-28 20:47 ` [PATCH 5/7] tile: " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 6/7] unicore32: " Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-28 20:47 ` [PATCH 7/7] random: Remove unused randomize_range() Jason Cooper
2016-07-28 20:47 ` [kernel-hardening] " Jason Cooper
2016-07-28 20:47 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 0/7] char/random: Simplify random address requests Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 1/7] random: Simplify API for " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-31 16:46 ` Kees Cook
2016-07-31 16:46 ` [kernel-hardening] " Kees Cook
2016-07-31 16:46 ` Kees Cook
2016-07-31 20:56 ` Jason Cooper
2016-07-31 20:56 ` [kernel-hardening] " Jason Cooper
2016-07-31 20:56 ` Jason Cooper
2016-08-01 19:47 ` Kees Cook
2016-08-01 19:47 ` [kernel-hardening] " Kees Cook
2016-08-01 19:47 ` Kees Cook
2016-08-01 23:17 ` Jason Cooper
2016-08-01 23:17 ` [kernel-hardening] " Jason Cooper
2016-08-01 23:17 ` Jason Cooper
2016-08-02 3:35 ` Michael Ellerman [this message]
2016-08-02 3:35 ` [kernel-hardening] " Michael Ellerman
2016-08-02 3:35 ` Michael Ellerman
2016-08-03 18:42 ` Jason Cooper
2016-08-03 18:42 ` Jason Cooper
2016-08-03 18:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 2/7] x86: Use simpler " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 3/7] ARM: " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 4/7] arm64: " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 5/7] tile: " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 6/7] unicore32: " Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-07-30 15:42 ` [PATCH v2 7/7] random: Remove unused randomize_range() Jason Cooper
2016-07-30 15:42 ` [kernel-hardening] " Jason Cooper
2016-07-30 15:42 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 0/7] char/random: Simplify random address requests Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 1/7] random: Simplify API for " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-04 12:47 ` Yann Droneaud
2016-08-04 12:47 ` [kernel-hardening] " Yann Droneaud
2016-08-04 12:47 ` Yann Droneaud
2016-08-03 23:39 ` [PATCH v3 2/7] x86: Use simpler " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 3/7] ARM: " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 4/7] arm64: " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 5/7] tile: " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 6/7] unicore32: " Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:39 ` [PATCH v3 7/7] random: Remove unused randomize_range() Jason Cooper
2016-08-03 23:39 ` [kernel-hardening] " Jason Cooper
2016-08-03 23:39 ` Jason Cooper
2016-08-03 23:48 ` Andrew Morton
2016-08-03 23:48 ` [kernel-hardening] " Andrew Morton
2016-08-03 23:48 ` Andrew Morton
2016-08-04 0:19 ` Jason Cooper
2016-08-04 0:19 ` [kernel-hardening] " Jason Cooper
2016-08-04 0:19 ` Jason Cooper
2016-08-04 2:41 ` [PATCH v3 0/7] char/random: Simplify random address requests Kees Cook
2016-08-04 2:41 ` [kernel-hardening] " Kees Cook
2016-08-04 2:41 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878twfonbi.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dcashman@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=nnk@google.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=william.c.roberts@intel.com \
--cc=x86@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.