From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Pawel Moll <pawel.moll@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Alan Cooper <alcooperx@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings
Date: Fri, 10 Jun 2016 12:21:33 +0300 [thread overview]
Message-ID: <878tyd761u.fsf@linux.intel.com> (raw)
In-Reply-To: <1465543962-11678-3-git-send-email-chunfeng.yun@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
Hi,
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> + - enable-manual-drd : supports manual dual-role switch via sysfs; only used
> + when receptacle is TYPE-A and also wants to support dual-role mode.
sorry, but this manual-drd can't be accepted. You should rely on a DT
property for this and you shouldn't expose it to sysfs. Use DebugFS for
that.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Alan Cooper <alcooperx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chunfeng Yun
<chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings
Date: Fri, 10 Jun 2016 12:21:33 +0300 [thread overview]
Message-ID: <878tyd761u.fsf@linux.intel.com> (raw)
In-Reply-To: <1465543962-11678-3-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Hi,
Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> writes:
> + - enable-manual-drd : supports manual dual-role switch via sysfs; only used
> + when receptacle is TYPE-A and also wants to support dual-role mode.
sorry, but this manual-drd can't be accepted. You should rely on a DT
property for this and you shouldn't expose it to sysfs. Use DebugFS for
that.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: felipe.balbi@linux.intel.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings
Date: Fri, 10 Jun 2016 12:21:33 +0300 [thread overview]
Message-ID: <878tyd761u.fsf@linux.intel.com> (raw)
In-Reply-To: <1465543962-11678-3-git-send-email-chunfeng.yun@mediatek.com>
Hi,
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> + - enable-manual-drd : supports manual dual-role switch via sysfs; only used
> + when receptacle is TYPE-A and also wants to support dual-role mode.
sorry, but this manual-drd can't be accepted. You should rely on a DT
property for this and you shouldn't expose it to sysfs. Use DebugFS for
that.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/ae48bff0/attachment.sig>
next prev parent reply other threads:[~2016-06-10 9:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 7:32 Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` [PATCH v3,1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode Chunfeng Yun
2016-06-10 7:32 ` [PATCH v3, 1/5] " Chunfeng Yun
2016-06-10 7:32 ` [PATCH v3,1/5] " Chunfeng Yun
2016-06-13 18:54 ` Rob Herring
2016-06-13 18:54 ` Rob Herring
2016-06-14 2:20 ` chunfeng yun
2016-06-14 2:20 ` chunfeng yun
2016-06-14 2:20 ` chunfeng yun
2016-06-10 7:32 ` [PATCH v3,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 9:21 ` Felipe Balbi [this message]
2016-06-10 9:21 ` Felipe Balbi
2016-06-10 9:21 ` Felipe Balbi
2016-06-14 2:19 ` chunfeng yun
2016-06-14 2:19 ` chunfeng yun
2016-06-14 2:19 ` chunfeng yun
2016-06-10 7:32 ` [PATCH v3,3/5] usb: xhci-mtk: make IPPC register optional Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` [PATCH v3,4/5] usb: Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-11 21:08 ` kbuild test robot
2016-06-11 21:08 ` kbuild test robot
2016-06-11 21:08 ` kbuild test robot
2016-06-12 4:14 ` kbuild test robot
2016-06-12 4:14 ` kbuild test robot
2016-06-12 4:14 ` kbuild test robot
2016-08-08 13:10 ` Greg Kroah-Hartman
2016-08-08 13:10 ` Greg Kroah-Hartman
2016-08-09 8:08 ` chunfeng yun
2016-08-09 8:08 ` chunfeng yun
2016-08-09 8:08 ` chunfeng yun
2016-06-10 7:32 ` [PATCH v3,5/5] arm64: dts: mediatek: add USB3 DRD driver Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 7:32 ` Chunfeng Yun
2016-06-10 9:15 ` Add MediaTek USB3 DRD Driver chunfeng yun
2016-06-10 9:15 ` chunfeng yun
2016-06-10 9:15 ` chunfeng yun
2016-06-10 9:27 ` Felipe Balbi
2016-06-10 9:27 ` Felipe Balbi
2016-06-10 9:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tyd761u.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=alcooperx@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.