From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP2+: PM: fix watchdog boot when runtime PM is disabled
Date: Tue, 12 Jul 2011 07:55:00 -0700 [thread overview]
Message-ID: <878vs3v9a3.fsf@ti.com> (raw)
In-Reply-To: <4E1B8B47.3020904@ti.com> (Santosh Shilimkar's message of "Mon, 11 Jul 2011 16:46:15 -0700")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On 7/11/2011 4:21 PM, Kevin Hilman wrote:
>> Fix boot crash in watchdog driver when runtime PM is disabled.
>>
>> When runtime PM is disabled, devices should be left enabled so that
>> all device accesses in drivers will succeed even though the runtime PM
>> get/put calls are noops.
>>
>> This is already the case for all devices, but the WDT init has its
>> own hwmod postsetup which was not taking this into account.
>>
>> This fixes a boot crash where the first device access in the WDT probe
>> function would crash a booting kernel.
>>
>> Cc: Paul Walmsley<paul@pwsan.com>
>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>> ---
>> Tony, as this is a boot crash, it should probably be queued for v3.0.
>> However, since OMAP2PLUS_TYPICAL always enables runtime PM, this is
>> unlikely to be seen unless specifically testing with runtime PM disabled.
>>
> This patch is exactly same as the one I submitted on Jan 5, 2011 for
> the same issue. Here is the patchwork link for the same.
>
> https://patchwork.kernel.org/patch/453481/
>
> Paul had a valid concern about the boot-loader leaving the watchdog
> enabled. More on this in below thread.
>
> http://www.spinics.net/lists/arm-kernel/msg110937.html
>
Paul's concern is valid, and could be addressed by making that init code
actually check if the WDT is currently active (as suggested by the
comment there.)
In the mean time, this simple fix should be applied to prevent a boot
crash, IMO.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2+: PM: fix watchdog boot when runtime PM is disabled
Date: Tue, 12 Jul 2011 07:55:00 -0700 [thread overview]
Message-ID: <878vs3v9a3.fsf@ti.com> (raw)
In-Reply-To: <4E1B8B47.3020904@ti.com> (Santosh Shilimkar's message of "Mon, 11 Jul 2011 16:46:15 -0700")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On 7/11/2011 4:21 PM, Kevin Hilman wrote:
>> Fix boot crash in watchdog driver when runtime PM is disabled.
>>
>> When runtime PM is disabled, devices should be left enabled so that
>> all device accesses in drivers will succeed even though the runtime PM
>> get/put calls are noops.
>>
>> This is already the case for all devices, but the WDT init has its
>> own hwmod postsetup which was not taking this into account.
>>
>> This fixes a boot crash where the first device access in the WDT probe
>> function would crash a booting kernel.
>>
>> Cc: Paul Walmsley<paul@pwsan.com>
>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>> ---
>> Tony, as this is a boot crash, it should probably be queued for v3.0.
>> However, since OMAP2PLUS_TYPICAL always enables runtime PM, this is
>> unlikely to be seen unless specifically testing with runtime PM disabled.
>>
> This patch is exactly same as the one I submitted on Jan 5, 2011 for
> the same issue. Here is the patchwork link for the same.
>
> https://patchwork.kernel.org/patch/453481/
>
> Paul had a valid concern about the boot-loader leaving the watchdog
> enabled. More on this in below thread.
>
> http://www.spinics.net/lists/arm-kernel/msg110937.html
>
Paul's concern is valid, and could be addressed by making that init code
actually check if the WDT is currently active (as suggested by the
comment there.)
In the mean time, this simple fix should be applied to prevent a boot
crash, IMO.
Kevin
next prev parent reply other threads:[~2011-07-12 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 23:21 [PATCH] OMAP2+: PM: fix watchdog boot when runtime PM is disabled Kevin Hilman
2011-07-11 23:21 ` Kevin Hilman
2011-07-11 23:38 ` Hilman, Kevin
2011-07-11 23:38 ` Hilman, Kevin
2011-07-11 23:46 ` Santosh Shilimkar
2011-07-11 23:46 ` Santosh Shilimkar
2011-07-12 14:55 ` Kevin Hilman [this message]
2011-07-12 14:55 ` Kevin Hilman
2011-07-13 7:54 ` Paul Walmsley
2011-07-13 7:54 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vs3v9a3.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.