Re: [PATCH 10/12] ath11k: Send PPDU_STATS_CFG with proper pdev mask to firmware

From: Kalle Valo <kvalo@codeaurora.org>
To: Jouni Malinen <jouni@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Rameshkumar Sundaram <ramess@codeaurora.org>,
	Sathishkumar Muruganandam <murugana@codeaurora.org>
Subject: Re: [PATCH 10/12] ath11k: Send PPDU_STATS_CFG with proper pdev mask to firmware
Date: Tue, 28 Sep 2021 13:46:58 +0300	[thread overview]
Message-ID: <87a6jxq8nx.fsf@codeaurora.org> (raw)
In-Reply-To: <20210721212029.142388-10-jouni@codeaurora.org> (Jouni Malinen's message of "Thu, 22 Jul 2021 00:20:27 +0300")

Jouni Malinen <jouni@codeaurora.org> writes:

> From: Rameshkumar Sundaram <ramess@codeaurora.org>
>
> HTT_PPDU_STATS_CFG_PDEV_ID bit mask for target FW PPDU stats request
> message was set as bit 8 to 15. Bit 8 is reserved for soc stats and
> pdev id starts from bit 9. Hence change the bitmask as bit 9 to 15
> and fill the proper pdev id in the request message.
>
> Tested on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01092-QCAHKSWPL_SILICONZ-1
> Tested on: IPQ6018 hw1.0 WLAN.HK.2.5.0.1-01067-QCAHKSWPL_SILICONZ-1
>
> Fixes: 701e48a43e15 ("ath11k: add packet log support for QCA6390")
>
> Co-developed-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> Signed-off-by: Rameshkumar Sundaram <ramess@codeaurora.org>
> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath11k/dp.h    | 3 ++-
>  drivers/net/wireless/ath/ath11k/dp_tx.c | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp.h b/drivers/net/wireless/ath/ath11k/dp.h
> index b2e7621969c5..522d3a6ce253 100644
> --- a/drivers/net/wireless/ath/ath11k/dp.h
> +++ b/drivers/net/wireless/ath/ath11k/dp.h
> @@ -541,7 +541,8 @@ struct htt_ppdu_stats_cfg_cmd {
>  } __packed;
>  
>  #define HTT_PPDU_STATS_CFG_MSG_TYPE		GENMASK(7, 0)
> -#define HTT_PPDU_STATS_CFG_PDEV_ID		GENMASK(15, 8)
> +#define HTT_PPDU_STATS_CFG_SOC_STATS		BIT(8)
> +#define HTT_PPDU_STATS_CFG_PDEV_ID		GENMASK(15, 9)

This part is clear after reading the commit log.

> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -906,7 +906,7 @@ int ath11k_dp_tx_htt_h2t_ppdu_stats_req(struct ath11k *ar, u32 mask)
>  		cmd->msg = FIELD_PREP(HTT_PPDU_STATS_CFG_MSG_TYPE,
>  				      HTT_H2T_MSG_TYPE_PPDU_STATS_CFG);
>  
> -		pdev_mask = 1 << (i + 1);
> +		pdev_mask = 1 << (ar->pdev_idx + i);
>  		cmd->msg |= FIELD_PREP(HTT_PPDU_STATS_CFG_PDEV_ID, pdev_mask);
>  		cmd->msg |= FIELD_PREP(HTT_PPDU_STATS_CFG_TLV_TYPE_BITMASK, mask);

But this part isn't. All I can see in the commit log is a vague comment
"and fill the proper pdev id in the request message" and nothing else.
Please provide a proper explanation for this change and I can then add
that to the commit log.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches