From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, ebiggers@google.com, drosen@google.com,
ebiggers@kernel.org, yuchao0@huawei.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, kernel@collabora.com,
andre.almeida@collabora.com
Subject: Re: [PATCH v5 4/4] fs: unicode: Add utf8 module and a unicode layer
Date: Mon, 29 Mar 2021 19:10:45 -0400 [thread overview]
Message-ID: <87a6qlr1xm.fsf@collabora.com> (raw)
In-Reply-To: <bf430ae7-16a1-d4ca-3241-6f654524e7f9@collabora.com> (Shreeya Patel's message of "Tue, 30 Mar 2021 04:08:40 +0530")
Shreeya Patel <shreeya.patel@collabora.com> writes:
> On 30/03/21 2:50 am, Gabriel Krisman Bertazi wrote:
>>> +DEFINE_STATIC_CALL(_unicode_strncmp, unicode_strncmp_default);
>>> +EXPORT_STATIC_CALL(_unicode_strncmp);
>>> -int unicode_strncmp(const struct unicode_map *um,
>>> - const struct qstr *s1, const struct qstr *s2)
>>> -{
>>> - const struct utf8data *data = utf8nfdi(um->version);
>>> - struct utf8cursor cur1, cur2;
>>> - int c1, c2;
>>> +DEFINE_STATIC_CALL(_unicode_strncasecmp, unicode_strncasecmp_default);
>>> +EXPORT_STATIC_CALL(_unicode_strncasecmp);
>> Why are these here if the _default functions are defined in the header
>> file? I think the definitions could be in this file. No?
>
>
> Inline functions defined in header file are using these functions so
> cannot define them here in .c file.
That is not a problem. It is regular C code, you can just move the
definition to the C code and add the declaration to the header file, and
it will work fine.
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: tytso@mit.edu, drosen@google.com, ebiggers@google.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org,
kernel@collabora.com, adilger.kernel@dilger.ca,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
andre.almeida@collabora.com, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v5 4/4] fs: unicode: Add utf8 module and a unicode layer
Date: Mon, 29 Mar 2021 19:10:45 -0400 [thread overview]
Message-ID: <87a6qlr1xm.fsf@collabora.com> (raw)
In-Reply-To: <bf430ae7-16a1-d4ca-3241-6f654524e7f9@collabora.com> (Shreeya Patel's message of "Tue, 30 Mar 2021 04:08:40 +0530")
Shreeya Patel <shreeya.patel@collabora.com> writes:
> On 30/03/21 2:50 am, Gabriel Krisman Bertazi wrote:
>>> +DEFINE_STATIC_CALL(_unicode_strncmp, unicode_strncmp_default);
>>> +EXPORT_STATIC_CALL(_unicode_strncmp);
>>> -int unicode_strncmp(const struct unicode_map *um,
>>> - const struct qstr *s1, const struct qstr *s2)
>>> -{
>>> - const struct utf8data *data = utf8nfdi(um->version);
>>> - struct utf8cursor cur1, cur2;
>>> - int c1, c2;
>>> +DEFINE_STATIC_CALL(_unicode_strncasecmp, unicode_strncasecmp_default);
>>> +EXPORT_STATIC_CALL(_unicode_strncasecmp);
>> Why are these here if the _default functions are defined in the header
>> file? I think the definitions could be in this file. No?
>
>
> Inline functions defined in header file are using these functions so
> cannot define them here in .c file.
That is not a problem. It is regular C code, you can just move the
definition to the C code and add the declaration to the header file, and
it will work fine.
--
Gabriel Krisman Bertazi
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-03-29 23:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 20:42 [PATCH v5 0/4] Make UTF-8 encoding loadable Shreeya Patel
2021-03-29 20:42 ` [f2fs-dev] " Shreeya Patel
2021-03-29 20:42 ` [PATCH v5 1/4] fs: unicode: Use strscpy() instead of strncpy() Shreeya Patel
2021-03-29 20:42 ` [f2fs-dev] " Shreeya Patel
2021-03-29 20:42 ` [PATCH v5 2/4] fs: unicode: Rename function names from utf8 to unicode Shreeya Patel
2021-03-29 20:42 ` [f2fs-dev] " Shreeya Patel
2021-03-30 1:53 ` Eric Biggers
2021-03-30 1:53 ` [f2fs-dev] " Eric Biggers
2021-03-30 9:49 ` Shreeya Patel
2021-03-30 9:49 ` [f2fs-dev] " Shreeya Patel
2021-03-29 20:42 ` [PATCH v5 3/4] fs: unicode: Rename utf8-core file to unicode-core Shreeya Patel
2021-03-29 20:42 ` [f2fs-dev] " Shreeya Patel
2021-03-29 20:42 ` [PATCH v5 4/4] fs: unicode: Add utf8 module and a unicode layer Shreeya Patel
2021-03-29 20:42 ` [f2fs-dev] " Shreeya Patel
2021-03-29 21:20 ` Gabriel Krisman Bertazi
2021-03-29 21:20 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-03-29 22:38 ` Shreeya Patel
2021-03-29 22:38 ` [f2fs-dev] " Shreeya Patel
2021-03-29 23:10 ` Gabriel Krisman Bertazi [this message]
2021-03-29 23:10 ` Gabriel Krisman Bertazi
2021-03-30 2:01 ` Eric Biggers
2021-03-30 2:01 ` [f2fs-dev] " Eric Biggers
2021-03-30 2:16 ` Gabriel Krisman Bertazi
2021-03-30 2:16 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-03-30 5:47 ` Eric Biggers
2021-03-30 5:47 ` [f2fs-dev] " Eric Biggers
2021-03-30 16:00 ` Theodore Ts'o
2021-03-30 16:00 ` [f2fs-dev] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6qlr1xm.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=andre.almeida@collabora.com \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.