From: Kalle Valo <kvalo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org,
bbhatt@codeaurora.org, netdev@vger.kernel.org,
hemantk@codeaurora.org, ath11k@lists.infradead.org
Subject: Re: [PATCH] bus: mhi: Remove auto-start option
Date: Tue, 24 Nov 2020 17:45:35 +0200 [thread overview]
Message-ID: <87a6v6rc68.fsf@codeaurora.org> (raw)
In-Reply-To: <20201118093107.GC3286@work> (Manivannan Sadhasivam's message of "Wed, 18 Nov 2020 15:01:07 +0530")
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:
>> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>>
>> > From: Loic Poulain <loic.poulain@linaro.org>
>> >
>> > There is really no point having an auto-start for channels.
>> > This is confusing for the device drivers, some have to enable the
>> > channels, others don't have... and waste resources (e.g. pre allocated
>> > buffers) that may never be used.
>> >
>> > This is really up to the MHI device(channel) driver to manage the state
>> > of its channels.
>> >
>> > While at it, let's also remove the auto-start option from ath11k mhi
>> > controller.
>> >
>> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> > [mani: clubbed ath11k change]
>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>
>> Thanks and feel free to take this to the immutable branch:
>>
>> Acked-by: Kalle Valo <kvalo@codeaurora.org>
>
> Patch applied to mhi-ath11k-immutable branch and merged into mhi-next.
Tested on QCA6390 hw2.0 and pulled also to ath-next, thanks.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org,
bbhatt@codeaurora.org, netdev@vger.kernel.org,
hemantk@codeaurora.org, ath11k@lists.infradead.org
Subject: Re: [PATCH] bus: mhi: Remove auto-start option
Date: Tue, 24 Nov 2020 17:45:35 +0200 [thread overview]
Message-ID: <87a6v6rc68.fsf@codeaurora.org> (raw)
In-Reply-To: <20201118093107.GC3286@work> (Manivannan Sadhasivam's message of "Wed, 18 Nov 2020 15:01:07 +0530")
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:
>> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>>
>> > From: Loic Poulain <loic.poulain@linaro.org>
>> >
>> > There is really no point having an auto-start for channels.
>> > This is confusing for the device drivers, some have to enable the
>> > channels, others don't have... and waste resources (e.g. pre allocated
>> > buffers) that may never be used.
>> >
>> > This is really up to the MHI device(channel) driver to manage the state
>> > of its channels.
>> >
>> > While at it, let's also remove the auto-start option from ath11k mhi
>> > controller.
>> >
>> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> > [mani: clubbed ath11k change]
>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>
>> Thanks and feel free to take this to the immutable branch:
>>
>> Acked-by: Kalle Valo <kvalo@codeaurora.org>
>
> Patch applied to mhi-ath11k-immutable branch and merged into mhi-next.
Tested on QCA6390 hw2.0 and pulled also to ath-next, thanks.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-11-24 15:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 5:31 [PATCH] bus: mhi: Remove auto-start option Manivannan Sadhasivam
2020-11-18 5:31 ` Manivannan Sadhasivam
2020-11-18 5:43 ` Kalle Valo
2020-11-18 5:43 ` Kalle Valo
2020-11-18 9:31 ` Manivannan Sadhasivam
2020-11-18 9:31 ` Manivannan Sadhasivam
2020-11-18 11:55 ` Carl Huang
2020-11-18 11:55 ` Carl Huang
2020-11-18 11:57 ` Manivannan Sadhasivam
2020-11-18 11:57 ` Manivannan Sadhasivam
2020-11-18 17:46 ` Bhaumik Bhatt
2020-11-18 17:46 ` Bhaumik Bhatt
2020-11-24 15:45 ` Kalle Valo [this message]
2020-11-24 15:45 ` Kalle Valo
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 10:16 Loic Poulain
2020-09-19 2:38 ` bbhatt
2020-09-19 11:27 ` Manivannan Sadhasivam
2020-09-21 7:07 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6v6rc68.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.