From: Valentin Schneider <valentin.schneider@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field
Date: Sun, 24 Oct 2021 16:50:34 +0100 [thread overview]
Message-ID: <87bl3ejub9.mognet@arm.com> (raw)
In-Reply-To: <87r1cct8cw.wl-maz@kernel.org>
On 23/10/21 10:10, Marc Zyngier wrote:
> On Fri, 22 Oct 2021 11:33:05 +0100,
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>> -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +
>> +#define RDIST_FLAGS_LPI_ENABLED BIT(0)
>
> Just to reduce the churn and for me not to misread things (because
> RDIST/RDISTS is pretty confusing), how about leaving the original
> flags as is, and name the per-RD ones like:
>
> #define RD_LOCAL_LPI_ENABLED BIT(0)
>
> ?
>
> Or something else that'd be adequately different from the original
> flags?
>
Aye, sounds like the right thing to do!
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field
Date: Sun, 24 Oct 2021 16:50:34 +0100 [thread overview]
Message-ID: <87bl3ejub9.mognet@arm.com> (raw)
In-Reply-To: <87r1cct8cw.wl-maz@kernel.org>
On 23/10/21 10:10, Marc Zyngier wrote:
> On Fri, 22 Oct 2021 11:33:05 +0100,
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>> -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +
>> +#define RDIST_FLAGS_LPI_ENABLED BIT(0)
>
> Just to reduce the churn and for me not to misread things (because
> RDIST/RDISTS is pretty confusing), how about leaving the original
> flags as is, and name the per-RD ones like:
>
> #define RD_LOCAL_LPI_ENABLED BIT(0)
>
> ?
>
> Or something else that'd be adequately different from the original
> flags?
>
Aye, sounds like the right thing to do!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-24 15:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 10:33 [PATCH 0/3] irqchip/gic-v3-its: Fix LPI pending table handling vs PREEMPT_RT Valentin Schneider
2021-10-22 10:33 ` Valentin Schneider
2021-10-22 10:33 ` [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field Valentin Schneider
2021-10-22 10:33 ` Valentin Schneider
2021-10-23 9:10 ` Marc Zyngier
2021-10-23 9:10 ` Marc Zyngier
2021-10-24 15:50 ` Valentin Schneider [this message]
2021-10-24 15:50 ` Valentin Schneider
2021-10-22 10:33 ` [PATCH 2/3] irqchip/gic-v3-its: Postpone LPI pending table freeing and memreserve Valentin Schneider
2021-10-22 10:33 ` Valentin Schneider
2021-10-23 9:48 ` Marc Zyngier
2021-10-23 9:48 ` Marc Zyngier
2021-10-24 15:51 ` Valentin Schneider
2021-10-24 15:51 ` Valentin Schneider
2021-10-25 11:57 ` Marc Zyngier
2021-10-25 11:57 ` Marc Zyngier
2021-10-22 10:33 ` [PATCH 3/3] irqchip/gic-v3-its: Limit memreserve cpuhp state lifetime Valentin Schneider
2021-10-22 10:33 ` Valentin Schneider
2021-10-23 10:37 ` Marc Zyngier
2021-10-23 10:37 ` Marc Zyngier
2021-10-24 15:52 ` Valentin Schneider
2021-10-24 15:52 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl3ejub9.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=ardb@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.