From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Jason Ekstrand <jason@jlekstrand.net>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v2 11/11] drm/i915: Extract i915_module.c
Date: Wed, 25 Aug 2021 17:51:31 +0300 [thread overview]
Message-ID: <87bl5lefws.fsf@intel.com> (raw)
In-Reply-To: <20210727121037.2041102-11-daniel.vetter@ffwll.ch>
On Tue, 27 Jul 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +static void __exit i915_exit(void)
> +{
> + int i;
> +
> + for (i = init_progress - 1; i >= 0; i--) {
> + GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs));
Not introduced by you, but it's kind of silly we're using GEM_BUG_ON()
in generic driver code.
BR,
Jani.
> + if (init_funcs[i].exit)
> + init_funcs[i].exit();
> + }
> +}
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Jason Ekstrand <jason@jlekstrand.net>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c
Date: Wed, 25 Aug 2021 17:51:31 +0300 [thread overview]
Message-ID: <87bl5lefws.fsf@intel.com> (raw)
In-Reply-To: <20210727121037.2041102-11-daniel.vetter@ffwll.ch>
On Tue, 27 Jul 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +static void __exit i915_exit(void)
> +{
> + int i;
> +
> + for (i = init_progress - 1; i >= 0; i--) {
> + GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs));
Not introduced by you, but it's kind of silly we're using GEM_BUG_ON()
in generic driver code.
BR,
Jani.
> + if (init_funcs[i].exit)
> + init_funcs[i].exit();
> + }
> +}
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-08-25 14:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 12:10 [PATCH v2 01/11] drm/i915: Check for nomodeset in i915_init() first Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 02/11] drm/i915: move i915_active slab to direct module init/exit Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 03/11] drm/i915: move i915_buddy " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 04/11] drm/i915: move intel_context " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 05/11] drm/i915: move gem_context " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 06/11] drm/i915: move gem_objects " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 07/11] drm/i915: move request slabs " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 08/11] drm/i915: move scheduler " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 09/11] drm/i915: move vma slab " Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 10/11] drm/i915: Remove i915_globals Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 12:10 ` [PATCH v2 11/11] drm/i915: Extract i915_module.c Daniel Vetter
2021-07-27 12:10 ` [Intel-gfx] " Daniel Vetter
2021-07-27 14:44 ` Tvrtko Ursulin
2021-07-27 14:44 ` [Intel-gfx] " Tvrtko Ursulin
2021-07-27 18:25 ` Jason Ekstrand
2021-07-27 18:25 ` [Intel-gfx] " Jason Ekstrand
2021-08-23 15:22 ` Guenter Roeck
2021-08-23 16:15 ` Jani Nikula
2021-08-25 14:51 ` Jani Nikula [this message]
2021-08-25 14:51 ` Jani Nikula
2021-07-27 14:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,01/11] drm/i915: Check for nomodeset in i915_init() first Patchwork
2021-07-27 14:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-27 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-27 22:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl5lefws.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.