From: Eric Anholt <eric@anholt.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.
Date: Tue, 08 Mar 2016 10:04:35 -0800 [thread overview]
Message-ID: <87bn6ozw0c.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <56DE6A80.1060707@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
Stephen Warren <swarren@wwwdotorg.org> writes:
> On 03/04/2016 01:32 PM, Eric Anholt wrote:
>> VC4 is the GPU (display and 3D) present on the 283x.
>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>
>> +&hdmi {
>> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
>> +};
>
> Isn't that the same everywhere? If so, adding it to bcm2835-rpi.dtsi
> seems like a better idea; it'd avoid duplicating it everywhere.
It's not the same everywhere (_HIGH vs _LOW), which is why it's in the
individual files.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>
Subject: Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.
Date: Tue, 08 Mar 2016 10:04:35 -0800 [thread overview]
Message-ID: <87bn6ozw0c.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <56DE6A80.1060707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> writes:
> On 03/04/2016 01:32 PM, Eric Anholt wrote:
>> VC4 is the GPU (display and 3D) present on the 283x.
>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>
>> +&hdmi {
>> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
>> +};
>
> Isn't that the same everywhere? If so, adding it to bcm2835-rpi.dtsi
> seems like a better idea; it'd avoid duplicating it everywhere.
It's not the same everywhere (_HIGH vs _LOW), which is why it's in the
individual files.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.
Date: Tue, 08 Mar 2016 10:04:35 -0800 [thread overview]
Message-ID: <87bn6ozw0c.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <56DE6A80.1060707@wwwdotorg.org>
Stephen Warren <swarren@wwwdotorg.org> writes:
> On 03/04/2016 01:32 PM, Eric Anholt wrote:
>> VC4 is the GPU (display and 3D) present on the 283x.
>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>
>> +&hdmi {
>> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
>> +};
>
> Isn't that the same everywhere? If so, adding it to bcm2835-rpi.dtsi
> seems like a better idea; it'd avoid duplicating it everywhere.
It's not the same everywhere (_HIGH vs _LOW), which is why it's in the
individual files.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160308/1566a353/attachment.sig>
next prev parent reply other threads:[~2016-03-08 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 20:32 [PATCH 0/3] ARM: bcm2835: Include VC4 GPU in the DT Eric Anholt
2016-03-04 20:32 ` Eric Anholt
2016-03-04 20:32 ` [PATCH 1/3] dt-bindings: Add binding docs for V3D Eric Anholt
2016-03-04 20:32 ` Eric Anholt
2016-03-17 11:53 ` Rob Herring
2016-03-17 11:53 ` Rob Herring
2016-03-17 11:53 ` Rob Herring
2016-03-04 20:32 ` [PATCH 2/3] drm/vc4: Recognize a more specific compatible string " Eric Anholt
2016-03-04 20:32 ` Eric Anholt
2016-03-04 20:32 ` [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree Eric Anholt
2016-03-04 20:32 ` Eric Anholt
2016-03-08 6:00 ` Stephen Warren
2016-03-08 6:00 ` Stephen Warren
2016-03-08 6:00 ` Stephen Warren
2016-03-08 18:04 ` Eric Anholt [this message]
2016-03-08 18:04 ` Eric Anholt
2016-03-08 18:04 ` Eric Anholt
2016-03-08 18:12 ` Stephen Warren
2016-03-08 18:12 ` Stephen Warren
2016-03-08 18:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn6ozw0c.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.