From: Gregory CLEMENT <gregory.clement@bootlin.com> To: "Marek Behún" <kabel@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, pali@kernel.org, "Marek Behún" <kabel@kernel.org>, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Date: Fri, 12 Mar 2021 09:58:34 +0100 [thread overview] Message-ID: <87czw4kath.fsf@BL-laptop> (raw) In-Reply-To: <20210308153703.23097-4-kabel@kernel.org> Hello Marek, > From: Pali Rohár <pali@kernel.org> > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file. I disagree with this patch. This firmware is specific to Turris MOX so it is not something that should be exposed to all the Armada 3700 based boards. If you want you still can create an dtsi for this and include it when needed. Gregory > > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Signed-off-by: Marek Behún <kabel@kernel.org> > Cc: <stable@vger.kernel.org> # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node") > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 8 -------- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index d239ab70ed99..8447f303a294 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -107,14 +107,6 @@ sfp: sfp { > /* enabled by U-Boot if SFP module is present */ > status = "disabled"; > }; > - > - firmware { > - turris-mox-rwtm { > - compatible = "cznic,turris-mox-rwtm"; > - mboxes = <&rwtm 0>; > - status = "okay"; > - }; > - }; > }; > > &i2c0 { > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 7a2df148c6a3..31126f1ffe5b 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -503,4 +503,12 @@ pcie_intc: interrupt-controller { > }; > }; > }; > + > + firmware { > + turris-mox-rwtm { > + compatible = "cznic,turris-mox-rwtm"; > + mboxes = <&rwtm 0>; > + status = "okay"; > + }; > + }; > }; > -- > 2.26.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com> To: "Marek Behún" <kabel@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, pali@kernel.org, "Marek Behún" <kabel@kernel.org>, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Date: Fri, 12 Mar 2021 09:58:34 +0100 [thread overview] Message-ID: <87czw4kath.fsf@BL-laptop> (raw) In-Reply-To: <20210308153703.23097-4-kabel@kernel.org> Hello Marek, > From: Pali Rohár <pali@kernel.org> > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file. I disagree with this patch. This firmware is specific to Turris MOX so it is not something that should be exposed to all the Armada 3700 based boards. If you want you still can create an dtsi for this and include it when needed. Gregory > > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Signed-off-by: Marek Behún <kabel@kernel.org> > Cc: <stable@vger.kernel.org> # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node") > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 8 -------- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index d239ab70ed99..8447f303a294 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -107,14 +107,6 @@ sfp: sfp { > /* enabled by U-Boot if SFP module is present */ > status = "disabled"; > }; > - > - firmware { > - turris-mox-rwtm { > - compatible = "cznic,turris-mox-rwtm"; > - mboxes = <&rwtm 0>; > - status = "okay"; > - }; > - }; > }; > > &i2c0 { > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 7a2df148c6a3..31126f1ffe5b 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -503,4 +503,12 @@ pcie_intc: interrupt-controller { > }; > }; > }; > + > + firmware { > + turris-mox-rwtm { > + compatible = "cznic,turris-mox-rwtm"; > + mboxes = <&rwtm 0>; > + status = "okay"; > + }; > + }; > }; > -- > 2.26.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-12 8:59 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-08 15:37 [PATCH mvebu + mvebu/dt64 1/4] firmware: turris-mox-rwtm: fix reply status decoding function Marek Behún 2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 2/4] firmware: turris-mox-rwtm: report failures better Marek Behún 2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 3/4] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Marek Behún 2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Marek Behún 2021-03-08 15:37 ` Marek Behún 2021-03-12 8:58 ` Gregory CLEMENT [this message] 2021-03-12 8:58 ` Gregory CLEMENT 2021-03-12 9:10 ` Marek Behún 2021-03-12 9:10 ` Marek Behún 2021-03-12 14:48 ` Andrew Lunn 2021-03-12 14:48 ` Andrew Lunn 2021-03-12 15:17 ` Marek Behún 2021-03-12 15:17 ` Marek Behún 2021-03-12 15:53 ` Andrew Lunn 2021-03-12 15:53 ` Andrew Lunn 2021-03-12 16:18 ` Pali Rohár 2021-03-12 16:18 ` Pali Rohár 2021-03-12 16:32 ` Marek Behún 2021-03-12 16:32 ` Marek Behún 2021-03-15 10:14 ` Pali Rohár 2021-03-15 10:14 ` Pali Rohár 2021-03-15 12:08 ` Andrew Lunn 2021-03-15 12:08 ` Andrew Lunn 2021-04-26 18:36 ` Pali Rohár 2021-04-26 18:36 ` Pali Rohár 2021-04-26 19:52 ` Andrew Lunn 2021-04-26 19:52 ` Andrew Lunn 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Pali Rohár 2021-04-29 8:36 ` Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 2/6] firmware: turris-mox-rwtm: report failures better Pali Rohár 2021-04-29 8:36 ` Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 3/6] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár 2021-04-29 8:36 ` Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 4/6] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár 2021-04-29 8:36 ` Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware compatible string Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár 2021-04-29 8:36 ` [PATCH v2 mvebu + mvebu/dt64 6/6] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár 2021-04-29 8:36 ` Pali Rohár 2021-05-03 12:22 ` [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Andrew Lunn 2021-05-03 12:22 ` Andrew Lunn 2021-05-05 16:04 ` Marek Behún 2021-05-05 16:04 ` Marek Behún 2021-05-05 16:20 ` Andrew Lunn 2021-05-05 16:20 ` Andrew Lunn 2021-05-11 21:46 ` Pali Rohár 2021-05-11 21:46 ` Pali Rohár 2021-05-06 9:07 ` [PATCH v3 " Pali Rohár 2021-05-06 9:07 ` Pali Rohár 2021-05-06 9:07 ` [PATCH v3 mvebu + mvebu/dt64 2/6] firmware: turris-mox-rwtm: report failures better Pali Rohár 2021-05-06 9:07 ` Pali Rohár 2021-05-06 9:07 ` [PATCH v3 mvebu + mvebu/dt64 3/6] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár 2021-05-06 9:07 ` Pali Rohár 2021-05-12 0:56 ` Andrew Lunn 2021-05-12 0:56 ` Andrew Lunn 2021-05-20 11:38 ` Pali Rohár 2021-05-20 11:38 ` Pali Rohár 2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 4/6] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár 2021-05-06 9:08 ` Pali Rohár 2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware compatible string Pali Rohár 2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 5/6] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár 2021-05-06 9:08 ` [PATCH v3 mvebu + mvebu/dt64 6/6] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár 2021-05-06 9:08 ` Pali Rohár 2021-05-12 0:59 ` Andrew Lunn 2021-05-12 0:59 ` Andrew Lunn 2021-05-20 11:40 ` Pali Rohár 2021-05-20 11:40 ` Pali Rohár 2021-05-12 0:49 ` [PATCH v3 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Andrew Lunn 2021-05-12 0:49 ` Andrew Lunn 2021-05-20 11:35 ` [PATCH v4 mvebu 0/4] firmware: turris-mox-rwtm: fixups Pali Rohár 2021-05-20 11:35 ` Pali Rohár 2021-05-20 11:35 ` [PATCH v4 mvebu 1/4] firmware: turris-mox-rwtm: fix reply status decoding function Pali Rohár 2021-05-20 11:35 ` Pali Rohár 2021-05-20 11:35 ` [PATCH v4 mvebu 2/4] firmware: turris-mox-rwtm: report failures better Pali Rohár 2021-05-20 11:35 ` Pali Rohár 2021-05-21 1:38 ` Andrew Lunn 2021-05-21 1:38 ` Andrew Lunn 2021-05-20 11:35 ` [PATCH v4 mvebu 3/4] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Pali Rohár 2021-05-20 11:35 ` Pali Rohár 2021-05-21 1:39 ` Andrew Lunn 2021-05-21 1:39 ` Andrew Lunn 2021-05-20 11:35 ` [PATCH v4 mvebu 4/4] firmware: turris-mox-rwtm: show message about HWRNG registration Pali Rohár 2021-05-20 11:35 ` Pali Rohár 2021-05-21 1:40 ` Andrew Lunn 2021-05-21 1:40 ` Andrew Lunn 2021-06-17 13:06 ` [PATCH v4 mvebu 0/4] firmware: turris-mox-rwtm: fixups Gregory CLEMENT 2021-06-17 13:06 ` Gregory CLEMENT 2021-07-07 18:14 ` Pali Rohár 2021-07-07 18:14 ` Pali Rohár 2021-07-23 12:45 ` Gregory CLEMENT 2021-07-23 12:45 ` Gregory CLEMENT 2021-07-23 12:47 ` Pali Rohár 2021-07-23 12:47 ` Pali Rohár 2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 0/2] firmware: turris-mox-rwtm: new compatible string Pali Rohár 2021-05-20 11:38 ` Pali Rohár 2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware " Pali Rohár 2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell, armada-3700-rwtm-firmware " Pali Rohár 2021-05-21 1:41 ` [PATCH v4 mvebu + mvebu/dt64 1/2] firmware: turris-mox-rwtm: add marvell,armada-3700-rwtm-firmware " Andrew Lunn 2021-05-21 1:41 ` Andrew Lunn 2021-06-17 13:07 ` Gregory CLEMENT 2021-06-17 13:07 ` Gregory CLEMENT 2021-05-20 11:38 ` [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Pali Rohár 2021-05-20 11:38 ` Pali Rohár 2021-05-21 1:42 ` Andrew Lunn 2021-05-21 1:42 ` Andrew Lunn 2021-06-17 13:08 ` Gregory CLEMENT 2021-06-17 13:08 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87czw4kath.fsf@BL-laptop \ --to=gregory.clement@bootlin.com \ --cc=kabel@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=pali@kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.