From: Baruch Siach <baruch@tkos.co.il> To: Sean Anderson <sean.anderson@seco.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Balaji Prakash J <bjagadee@codeaurora.org>, linux-kernel@vger.kernel.org, Robert Hancock <robert.hancock@calian.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Wed, 19 Jan 2022 20:14:06 +0200 [thread overview] Message-ID: <87ee53fv01.fsf@tarshish> (raw) In-Reply-To: <20220119002438.106079-1-sean.anderson@seco.com> Hi Sean, On Tue, Jan 18 2022, Sean Anderson wrote: > This is a rework of patches 3-5 of [1]. It attempts to correctly program > REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since > we no longer need a special property duplicating this configuration, > snps,ref-clock-period-ns is deprecated. > > Please test this! Patches 3/4 in this series have the effect of > programming REFCLKPER and REFCLK_FLADJ on boards which already configure > the "ref" clock. I have build tested, but not much else. Tested here on IPQ6010 based system. USB still works. But the with "ref" clock at 24MHz, period is calculated as 0x29. Previous snps,ref-clock-period-ns value used to be 0x32. Is that expected? Thanks, baruch > > [1] https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ > > Changes in v2: > - Document clock members > - Also program GFLADJ.240MHZDECR > - Don't program GFLADJ if the version is < 2.50a > - Add snps,ref-clock-frequency-hz property for ACPI > > Sean Anderson (7): > dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns > usb: dwc3: Get clocks individually > usb: dwc3: Calculate REFCLKPER based on reference clock > usb: dwc3: Program GFLADJ > usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI > arm64: dts: zynqmp: Move USB clocks to dwc3 node > arm64: dts: ipq6018: Use reference clock to set dwc3 period > > .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- > .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- > drivers/usb/dwc3/core.c | 112 +++++++++++++++--- > drivers/usb/dwc3/core.h | 17 ++- > 6 files changed, 120 insertions(+), 27 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il> To: Sean Anderson <sean.anderson@seco.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Balaji Prakash J <bjagadee@codeaurora.org>, linux-kernel@vger.kernel.org, Robert Hancock <robert.hancock@calian.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Wed, 19 Jan 2022 20:14:06 +0200 [thread overview] Message-ID: <87ee53fv01.fsf@tarshish> (raw) In-Reply-To: <20220119002438.106079-1-sean.anderson@seco.com> Hi Sean, On Tue, Jan 18 2022, Sean Anderson wrote: > This is a rework of patches 3-5 of [1]. It attempts to correctly program > REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since > we no longer need a special property duplicating this configuration, > snps,ref-clock-period-ns is deprecated. > > Please test this! Patches 3/4 in this series have the effect of > programming REFCLKPER and REFCLK_FLADJ on boards which already configure > the "ref" clock. I have build tested, but not much else. Tested here on IPQ6010 based system. USB still works. But the with "ref" clock at 24MHz, period is calculated as 0x29. Previous snps,ref-clock-period-ns value used to be 0x32. Is that expected? Thanks, baruch > > [1] https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ > > Changes in v2: > - Document clock members > - Also program GFLADJ.240MHZDECR > - Don't program GFLADJ if the version is < 2.50a > - Add snps,ref-clock-frequency-hz property for ACPI > > Sean Anderson (7): > dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns > usb: dwc3: Get clocks individually > usb: dwc3: Calculate REFCLKPER based on reference clock > usb: dwc3: Program GFLADJ > usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI > arm64: dts: zynqmp: Move USB clocks to dwc3 node > arm64: dts: ipq6018: Use reference clock to set dwc3 period > > .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- > .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- > drivers/usb/dwc3/core.c | 112 +++++++++++++++--- > drivers/usb/dwc3/core.h | 17 ++- > 6 files changed, 120 insertions(+), 27 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-19 18:20 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-19 0:24 [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Sean Anderson 2022-01-19 0:24 ` Sean Anderson 2022-01-19 0:24 ` [PATCH v2 1/7] dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns Sean Anderson 2022-01-19 0:24 ` [PATCH v2 2/7] usb: dwc3: Get clocks individually Sean Anderson 2022-01-20 16:52 ` Robert Hancock 2022-01-19 0:24 ` [PATCH v2 3/7] usb: dwc3: Calculate REFCLKPER based on reference clock Sean Anderson 2022-01-20 16:53 ` Robert Hancock 2022-01-19 0:24 ` [PATCH v2 4/7] usb: dwc3: Program GFLADJ Sean Anderson 2022-01-20 16:55 ` Robert Hancock 2022-01-24 22:46 ` Thinh Nguyen 2022-01-24 23:06 ` Sean Anderson 2022-01-25 2:11 ` Thinh Nguyen 2022-01-25 6:17 ` Felipe Balbi 2022-01-25 20:02 ` Thinh Nguyen 2022-01-25 16:22 ` Sean Anderson 2022-01-25 19:36 ` Thinh Nguyen 2022-01-26 10:56 ` Felipe Balbi 2022-01-26 10:53 ` Felipe Balbi 2022-01-27 16:45 ` Sean Anderson 2022-01-19 0:24 ` [PATCH v2 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI Sean Anderson 2022-01-24 22:44 ` Thinh Nguyen 2022-01-24 23:07 ` Sean Anderson 2022-01-24 23:14 ` Sean Anderson 2022-01-25 2:21 ` Thinh Nguyen 2022-01-19 0:24 ` [PATCH v2 6/7] arm64: dts: zynqmp: Move USB clocks to dwc3 node Sean Anderson 2022-01-19 0:24 ` Sean Anderson 2022-01-20 16:56 ` Robert Hancock 2022-01-20 16:56 ` Robert Hancock 2022-01-19 0:24 ` [PATCH v2 7/7] arm64: dts: ipq6018: Use reference clock to set dwc3 period Sean Anderson 2022-01-19 18:14 ` Baruch Siach [this message] 2022-01-19 18:14 ` [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Baruch Siach 2022-01-19 18:23 ` Sean Anderson 2022-01-19 18:23 ` Sean Anderson 2022-01-20 5:23 ` Kathiravan T 2022-01-20 10:29 ` Baruch Siach 2022-01-20 10:29 ` Baruch Siach 2022-01-24 15:11 ` Kathiravan Thirumoorthy 2022-01-24 15:11 ` Kathiravan Thirumoorthy 2022-01-24 23:01 ` Thinh Nguyen 2022-01-24 23:01 ` Thinh Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87ee53fv01.fsf@tarshish \ --to=baruch@tkos.co.il \ --cc=Thinh.Nguyen@synopsys.com \ --cc=agross@kernel.org \ --cc=balbi@kernel.org \ --cc=bjagadee@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=robert.hancock@calian.com \ --cc=robh+dt@kernel.org \ --cc=sean.anderson@seco.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.